Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_trigger - Support starting ON_DEMAND triggers via enabled flag #17488

Merged
merged 3 commits into from
Feb 26, 2021
Merged

r/glue_trigger - Support starting ON_DEMAND triggers via enabled flag #17488

merged 3 commits into from
Feb 26, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17413

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueTrigger_'
--- PASS: TestAccAWSGlueTrigger_disappears (86.34s)
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (87.34s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (87.97s)
--- PASS: TestAccAWSGlueTrigger_basic (91.18s)
--- PASS: TestAccAWSGlueTrigger_Description (147.68s)
--- PASS: TestAccAWSGlueTrigger_Schedule (152.14s)
--- PASS: TestAccAWSGlueTrigger_Tags (162.07s)
--- PASS: TestAccAWSGlueTrigger_Crawler (164.02s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (166.83s)
--- PASS: TestAccAWSGlueTrigger_onDemandDisable (169.79s)
--- PASS: TestAccAWSGlueTrigger_Predicate (183.41s)
--- PASS: TestAccAWSGlueTrigger_Enabled (193.86s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner February 5, 2021 18:06
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 5, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Feb 5, 2021
ewbankkit
ewbankkit approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueTrigger_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueTrigger_ -timeout 120m
=== RUN   TestAccAWSGlueTrigger_basic
=== PAUSE TestAccAWSGlueTrigger_basic
=== RUN   TestAccAWSGlueTrigger_Crawler
=== PAUSE TestAccAWSGlueTrigger_Crawler
=== RUN   TestAccAWSGlueTrigger_Description
=== PAUSE TestAccAWSGlueTrigger_Description
=== RUN   TestAccAWSGlueTrigger_Enabled
=== PAUSE TestAccAWSGlueTrigger_Enabled
=== RUN   TestAccAWSGlueTrigger_Predicate
=== PAUSE TestAccAWSGlueTrigger_Predicate
=== RUN   TestAccAWSGlueTrigger_Schedule
=== PAUSE TestAccAWSGlueTrigger_Schedule
=== RUN   TestAccAWSGlueTrigger_Tags
=== PAUSE TestAccAWSGlueTrigger_Tags
=== RUN   TestAccAWSGlueTrigger_WorkflowName
=== PAUSE TestAccAWSGlueTrigger_WorkflowName
=== RUN   TestAccAWSGlueTrigger_actions_notify
=== PAUSE TestAccAWSGlueTrigger_actions_notify
=== RUN   TestAccAWSGlueTrigger_actions_securityConfig
=== PAUSE TestAccAWSGlueTrigger_actions_securityConfig
=== RUN   TestAccAWSGlueTrigger_onDemandDisable
=== PAUSE TestAccAWSGlueTrigger_onDemandDisable
=== RUN   TestAccAWSGlueTrigger_disappears
=== PAUSE TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_basic
=== CONT  TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_onDemandDisable
=== CONT  TestAccAWSGlueTrigger_actions_securityConfig
=== CONT  TestAccAWSGlueTrigger_actions_notify
=== CONT  TestAccAWSGlueTrigger_Predicate
=== CONT  TestAccAWSGlueTrigger_Tags
=== CONT  TestAccAWSGlueTrigger_Schedule
=== CONT  TestAccAWSGlueTrigger_Description
=== CONT  TestAccAWSGlueTrigger_Enabled
=== CONT  TestAccAWSGlueTrigger_Crawler
--- PASS: TestAccAWSGlueTrigger_disappears (42.87s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (57.47s)
--- PASS: TestAccAWSGlueTrigger_Description (61.73s)
--- PASS: TestAccAWSGlueTrigger_basic (73.77s)
--- PASS: TestAccAWSGlueTrigger_Tags (95.53s)
--- PASS: TestAccAWSGlueTrigger_onDemandDisable (107.22s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (113.28s)
--- PASS: TestAccAWSGlueTrigger_Predicate (115.55s)
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (133.25s)
--- PASS: TestAccAWSGlueTrigger_Crawler (143.94s)
--- PASS: TestAccAWSGlueTrigger_Schedule (191.64s)
--- PASS: TestAccAWSGlueTrigger_Enabled (204.63s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	204.786s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @DrFaust92!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueTrigger_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueTrigger_ -timeout 120m
=== RUN   TestAccAWSGlueTrigger_basic
=== PAUSE TestAccAWSGlueTrigger_basic
=== RUN   TestAccAWSGlueTrigger_Crawler
=== PAUSE TestAccAWSGlueTrigger_Crawler
=== RUN   TestAccAWSGlueTrigger_Description
=== PAUSE TestAccAWSGlueTrigger_Description
=== RUN   TestAccAWSGlueTrigger_Enabled
=== PAUSE TestAccAWSGlueTrigger_Enabled
=== RUN   TestAccAWSGlueTrigger_Predicate
=== PAUSE TestAccAWSGlueTrigger_Predicate
=== RUN   TestAccAWSGlueTrigger_Schedule
=== PAUSE TestAccAWSGlueTrigger_Schedule
=== RUN   TestAccAWSGlueTrigger_Tags
=== PAUSE TestAccAWSGlueTrigger_Tags
=== RUN   TestAccAWSGlueTrigger_WorkflowName
=== PAUSE TestAccAWSGlueTrigger_WorkflowName
=== RUN   TestAccAWSGlueTrigger_actions_notify
=== PAUSE TestAccAWSGlueTrigger_actions_notify
=== RUN   TestAccAWSGlueTrigger_actions_securityConfig
=== PAUSE TestAccAWSGlueTrigger_actions_securityConfig
=== RUN   TestAccAWSGlueTrigger_onDemandDisable
=== PAUSE TestAccAWSGlueTrigger_onDemandDisable
=== RUN   TestAccAWSGlueTrigger_disappears
=== PAUSE TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_basic
=== CONT  TestAccAWSGlueTrigger_onDemandDisable
=== CONT  TestAccAWSGlueTrigger_Crawler
=== CONT  TestAccAWSGlueTrigger_Enabled
=== CONT  TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_Schedule
=== CONT  TestAccAWSGlueTrigger_Predicate
=== CONT  TestAccAWSGlueTrigger_actions_notify
=== CONT  TestAccAWSGlueTrigger_Description
=== CONT  TestAccAWSGlueTrigger_actions_securityConfig
=== CONT  TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_Tags
--- PASS: TestAccAWSGlueTrigger_basic (30.69s)
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (32.02s)
--- PASS: TestAccAWSGlueTrigger_Description (46.00s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (51.58s)
--- PASS: TestAccAWSGlueTrigger_disappears (51.97s)
--- PASS: TestAccAWSGlueTrigger_onDemandDisable (61.85s)
--- PASS: TestAccAWSGlueTrigger_Schedule (71.90s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (72.36s)
--- PASS: TestAccAWSGlueTrigger_Tags (80.04s)
--- PASS: TestAccAWSGlueTrigger_Crawler (88.90s)
--- PASS: TestAccAWSGlueTrigger_Predicate (90.10s)
--- PASS: TestAccAWSGlueTrigger_Enabled (113.83s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       116.844s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSGlueTrigger_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueTrigger_ -timeout 120m
=== RUN   TestAccAWSGlueTrigger_basic
=== PAUSE TestAccAWSGlueTrigger_basic
=== RUN   TestAccAWSGlueTrigger_Crawler
=== PAUSE TestAccAWSGlueTrigger_Crawler
=== RUN   TestAccAWSGlueTrigger_Description
=== PAUSE TestAccAWSGlueTrigger_Description
=== RUN   TestAccAWSGlueTrigger_Enabled
=== PAUSE TestAccAWSGlueTrigger_Enabled
=== RUN   TestAccAWSGlueTrigger_Predicate
=== PAUSE TestAccAWSGlueTrigger_Predicate
=== RUN   TestAccAWSGlueTrigger_Schedule
=== PAUSE TestAccAWSGlueTrigger_Schedule
=== RUN   TestAccAWSGlueTrigger_Tags
=== PAUSE TestAccAWSGlueTrigger_Tags
=== RUN   TestAccAWSGlueTrigger_WorkflowName
=== PAUSE TestAccAWSGlueTrigger_WorkflowName
=== RUN   TestAccAWSGlueTrigger_actions_notify
=== PAUSE TestAccAWSGlueTrigger_actions_notify
=== RUN   TestAccAWSGlueTrigger_actions_securityConfig
=== PAUSE TestAccAWSGlueTrigger_actions_securityConfig
=== RUN   TestAccAWSGlueTrigger_onDemandDisable
=== PAUSE TestAccAWSGlueTrigger_onDemandDisable
=== RUN   TestAccAWSGlueTrigger_disappears
=== PAUSE TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_basic
=== CONT  TestAccAWSGlueTrigger_WorkflowName
=== CONT  TestAccAWSGlueTrigger_actions_securityConfig
=== CONT  TestAccAWSGlueTrigger_Predicate
=== CONT  TestAccAWSGlueTrigger_Tags
=== CONT  TestAccAWSGlueTrigger_Schedule
=== CONT  TestAccAWSGlueTrigger_onDemandDisable
=== CONT  TestAccAWSGlueTrigger_disappears
=== CONT  TestAccAWSGlueTrigger_Description
=== CONT  TestAccAWSGlueTrigger_Enabled
=== CONT  TestAccAWSGlueTrigger_Crawler
=== CONT  TestAccAWSGlueTrigger_actions_notify
--- PASS: TestAccAWSGlueTrigger_disappears (49.33s)
--- PASS: TestAccAWSGlueTrigger_actions_securityConfig (59.23s)
--- PASS: TestAccAWSGlueTrigger_Tags (88.15s)
--- PASS: TestAccAWSGlueTrigger_basic (95.90s)
--- PASS: TestAccAWSGlueTrigger_Predicate (99.02s)
--- PASS: TestAccAWSGlueTrigger_actions_notify (108.90s)
--- PASS: TestAccAWSGlueTrigger_Enabled (116.30s)
--- PASS: TestAccAWSGlueTrigger_Crawler (120.07s)
--- PASS: TestAccAWSGlueTrigger_Description (121.08s)
--- PASS: TestAccAWSGlueTrigger_WorkflowName (123.00s)
--- PASS: TestAccAWSGlueTrigger_onDemandDisable (140.74s)
--- PASS: TestAccAWSGlueTrigger_Schedule (186.32s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       189.354s

@breathingdust breathingdust merged commit 585f3d2 into hashicorp:main Feb 26, 2021
@github-actions github-actions bot added this to the v3.30.0 milestone Feb 26, 2021
@ghost
Copy link

ghost commented Feb 26, 2021

This has been released in version 3.30.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 28, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 28, 2021
@DrFaust92 DrFaust92 deleted the r/glue_trigger_on_demand_state_change branch April 15, 2021 10:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. service/glue Issues and PRs that pertain to the glue service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.30.0
Development

Successfully merging this pull request may close these issues.

ON_DEMAND triggers cannot be started via enabled flag
3 participants
@DrFaust92 @breathingdust @ewbankkit