Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data-source/iam_policy_document: Deprecate source_json and override_json #17555

Closed
YakDriver opened this issue Feb 10, 2021 · 3 comments · Fixed by #22890
Closed

data-source/iam_policy_document: Deprecate source_json and override_json #17555

YakDriver opened this issue Feb 10, 2021 · 3 comments · Fixed by #22890
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Milestone

Comments

@YakDriver
Copy link
Member

YakDriver commented Feb 10, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Now that aws_iam_policy_document has the override_policy_documents and source_policy_documents arguments, override_json and source_json are redundant and not needed. The exact functionality these arguments provided can now be accomplished with a length 1 list in the override_policy_documents and source_policy_documents arguments.

New or Affected Resource(s)

  • data-source/aws_iam_policy_document

References

@YakDriver YakDriver added enhancement Requests to existing resources that expand the functionality or scope. breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. labels Feb 10, 2021
@ghost ghost added the service/iam Issues and PRs that pertain to the iam service. label Feb 10, 2021
@YakDriver YakDriver added this to the v4.0.0 milestone Feb 25, 2021
@anGie44 anGie44 assigned anGie44 and zhelding and unassigned anGie44 Jan 18, 2022
@anGie44 anGie44 changed the title data-source/iam_policy_document: Deprecate & remove source_json and override_json data-source/iam_policy_document: Deprecate source_json and override_json Feb 2, 2022
@anGie44
Copy link
Contributor

anGie44 commented Feb 2, 2022

Argument removal will be addressed as part of #22906

@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. enhancement Requests to existing resources that expand the functionality or scope. service/iam Issues and PRs that pertain to the iam service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants