data_source/aws_outposts_outpost and aws_outposts_outposts: add argument for owner_id #17585

farhanangullia · 2021-02-12T06:51:32Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

enhancement:

data_source/aws_outposts_outpost: Add support for `owner_id` argument

data_source/aws_outposts_outposts: Add support for `owner_id` argument

Affected Resource(s)

data_source: aws_outposts_outpost
data_source: aws_outposts_outposts

Terraform Configuration

data "aws_outposts_outpost" "foo" {
  owner_id = "123456789012"
}

data "aws_outposts_outposts" "foo" {
  owner_id = "123456789012"
}

Output from acceptance testing for data_source/aws_outposts_outpost:

$ make testacc TESTARGS='-run=TestAccAWSOutpostsOutpostDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSOutpostsOutpostDataSource -timeout 120m
=== RUN   TestAccAWSOutpostsOutpostDataSource_Id
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Id
=== RUN   TestAccAWSOutpostsOutpostDataSource_Name
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Name
=== RUN   TestAccAWSOutpostsOutpostDataSource_Arn
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Arn
=== RUN   TestAccAWSOutpostsOutpostDataSource_OwnerId
=== PAUSE TestAccAWSOutpostsOutpostDataSource_OwnerId
=== CONT  TestAccAWSOutpostsOutpostDataSource_Id
=== CONT  TestAccAWSOutpostsOutpostDataSource_OwnerId
=== CONT  TestAccAWSOutpostsOutpostDataSource_Arn
=== CONT  TestAccAWSOutpostsOutpostDataSource_Name
--- PASS: TestAccAWSOutpostsOutpostDataSource_Id (99.88s)
--- PASS: TestAccAWSOutpostsOutpostDataSource_Arn (100.06s)
--- PASS: TestAccAWSOutpostsOutpostDataSource_Name (102.92s)
--- PASS: TestAccAWSOutpostsOutpostDataSource_OwnerId (110.32s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       112.209s

...

Output from acceptance testing for data_source/aws_outposts_outposts:

$ make testacc TESTARGS='-run=TestAccAWSOutpostsOutpostsDataSource'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSOutpostsOutpostsDataSource -timeout 120m
=== RUN   TestAccAWSOutpostsOutpostsDataSource_basic
=== PAUSE TestAccAWSOutpostsOutpostsDataSource_basic
=== CONT  TestAccAWSOutpostsOutpostsDataSource_basic
--- PASS: TestAccAWSOutpostsOutpostsDataSource_basic (58.41s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       59.618s

...

…low allow different account id from testAccProvider in the ARN. Replaced testAccCheckResourceAttrAccountID in acceptance test to allow different account id from testAccProvider as owner_id.

…dded owner_id for outposts site.

ewbankkit

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSOutpostsOutpostDataSource_\|TestAccAWSOutpostsOutpostsDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSOutpostsOutpostDataSource_\|TestAccAWSOutpostsOutpostsDataSource_ -timeout 180m
=== RUN   TestAccAWSOutpostsOutpostDataSource_Id
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Id
=== RUN   TestAccAWSOutpostsOutpostDataSource_Name
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Name
=== RUN   TestAccAWSOutpostsOutpostDataSource_Arn
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Arn
=== RUN   TestAccAWSOutpostsOutpostDataSource_OwnerId
=== PAUSE TestAccAWSOutpostsOutpostDataSource_OwnerId
=== RUN   TestAccAWSOutpostsOutpostsDataSource_basic
=== PAUSE TestAccAWSOutpostsOutpostsDataSource_basic
=== CONT  TestAccAWSOutpostsOutpostDataSource_Id
=== CONT  TestAccAWSOutpostsOutpostDataSource_OwnerId
=== CONT  TestAccAWSOutpostsOutpostDataSource_Name
=== CONT  TestAccAWSOutpostsOutpostDataSource_Arn
=== CONT  TestAccAWSOutpostsOutpostsDataSource_basic
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostsDataSource_basic (1.70s)
=== CONT  TestAccAWSOutpostsOutpostDataSource_OwnerId
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostDataSource_OwnerId (1.73s)
=== CONT  TestAccAWSOutpostsOutpostDataSource_Id
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostDataSource_Id (1.76s)
=== CONT  TestAccAWSOutpostsOutpostDataSource_Name
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostDataSource_Name (1.97s)
=== CONT  TestAccAWSOutpostsOutpostDataSource_Arn
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostDataSource_Arn (2.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	5.252s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSOutpostsOutpostDataSource_\|TestAccAWSOutpostsOutpostsDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSOutpostsOutpostDataSource_\|TestAccAWSOutpostsOutpostsDataSource_ -timeout 180m
=== RUN   TestAccAWSOutpostsOutpostDataSource_Id
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Id
=== RUN   TestAccAWSOutpostsOutpostDataSource_Name
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Name
=== RUN   TestAccAWSOutpostsOutpostDataSource_Arn
=== PAUSE TestAccAWSOutpostsOutpostDataSource_Arn
=== RUN   TestAccAWSOutpostsOutpostDataSource_OwnerId
=== PAUSE TestAccAWSOutpostsOutpostDataSource_OwnerId
=== RUN   TestAccAWSOutpostsOutpostsDataSource_basic
=== PAUSE TestAccAWSOutpostsOutpostsDataSource_basic
=== CONT  TestAccAWSOutpostsOutpostDataSource_Id
=== CONT  TestAccAWSOutpostsOutpostDataSource_OwnerId
=== CONT  TestAccAWSOutpostsOutpostDataSource_Arn
=== CONT  TestAccAWSOutpostsOutpostsDataSource_basic
=== CONT  TestAccAWSOutpostsOutpostDataSource_Name
=== CONT  TestAccAWSOutpostsOutpostsDataSource_basic
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostsDataSource_basic (2.02s)
=== CONT  TestAccAWSOutpostsOutpostDataSource_Name
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostDataSource_Name (2.04s)
=== CONT  TestAccAWSOutpostsOutpostDataSource_OwnerId
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostDataSource_OwnerId (2.20s)
=== CONT  TestAccAWSOutpostsOutpostDataSource_Id
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostDataSource_Id (7.07s)
=== CONT  TestAccAWSOutpostsOutpostDataSource_Arn
    data_source_aws_outposts_outposts_test.go:67: skipping since no Outposts found
--- SKIP: TestAccAWSOutpostsOutpostDataSource_Arn (7.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	10.350s

ewbankkit · 2021-05-17T13:49:05Z

@farhanangullia Thanks for the contribution 👏.

farhanangullia · 2021-05-17T14:53:51Z

Thanks @ewbankkit 😄

ghost · 2021-05-19T01:07:31Z

This has been released in version 3.41.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

github-actions · 2021-06-18T02:14:17Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

farhanangullia requested a review from a team as a code owner February 12, 2021 06:51

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 12, 2021

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 17, 2021

farhanangullia and others added 5 commits May 17, 2021 09:23

Modified owner_id in outpost data_source to work as argument

930e216

Replaced testAccMatchResourceAttrRegionalARN in acceptance test to al…

7f3e568

…low allow different account id from testAccProvider in the ARN. Replaced testAccCheckResourceAttrAccountID in acceptance test to allow different account id from testAccProvider as owner_id.

Added owner_id argument in outposts data source.

85cefce

Docs: Shift owner_id from attributes to arguments for outpost site. A…

5a20e24

…dded owner_id for outposts site.

Add CHANGELOG entry.

8c64433

ewbankkit force-pushed the f-ds_aws_outposts_outpost(s)-owner_id branch from bbe832c to 8c64433 Compare May 17, 2021 13:27

ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels May 17, 2021

Add missing 'ErrorCheck:'.

cc62271

ewbankkit approved these changes May 17, 2021

View reviewed changes

ewbankkit merged commit ea03cc6 into hashicorp:main May 17, 2021

github-actions bot added this to the v3.41.0 milestone May 17, 2021

github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2021

justinretzolk added the partner Contribution from a partner. label May 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

data_source/aws_outposts_outpost and aws_outposts_outposts: add argument for owner_id #17585

data_source/aws_outposts_outpost and aws_outposts_outposts: add argument for owner_id #17585

farhanangullia commented Feb 12, 2021 •

edited

Loading

ewbankkit left a comment

ewbankkit commented May 17, 2021

farhanangullia commented May 17, 2021

ghost commented May 19, 2021

github-actions bot commented Jun 18, 2021

data_source/aws_outposts_outpost and aws_outposts_outposts: add argument for owner_id #17585

data_source/aws_outposts_outpost and aws_outposts_outposts: add argument for owner_id #17585

Conversation

farhanangullia commented Feb 12, 2021 • edited Loading

Community Note

Affected Resource(s)

Terraform Configuration

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented May 17, 2021

farhanangullia commented May 17, 2021

ghost commented May 19, 2021

github-actions bot commented Jun 18, 2021

farhanangullia commented Feb 12, 2021 •

edited

Loading