Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update timeout on resourceAwsFmsAdminAccountCreate #17596

Merged

Conversation

mcalhoun
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17577

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsFms*'

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsFms* -timeout 120m
=== RUN   TestAccAwsFmsAdminAccount_basic
=== PAUSE TestAccAwsFmsAdminAccount_basic
=== CONT  TestAccAwsFmsAdminAccount_basic
    provider_test.go:781: skipping tests; this AWS account must not be an existing member of an AWS Organization
--- SKIP: TestAccAwsFmsAdminAccount_basic (1.76s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3.387s

@mcalhoun mcalhoun requested a review from a team as a code owner February 12, 2021 16:43
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/fms Issues and PRs that pertain to the fms service. labels Feb 12, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 12, 2021
@gdavison gdavison self-assigned this Mar 25, 2021
gdavison added a commit that referenced this pull request Mar 25, 2021
@gdavison gdavison merged commit ebf81d8 into hashicorp:main Mar 25, 2021
@github-actions github-actions bot added this to the v3.34.0 milestone Mar 25, 2021
@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/fms Issues and PRs that pertain to the fms service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_fms_admin_account timeout before completion
3 participants