Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/ses_receipt_rule_set - add arn attribute #17611

Merged
merged 4 commits into from
Feb 18, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSESReceiptRuleSet_'
--- PASS: TestAccAWSSESReceiptRuleSet_disappears (27.97s)
--- PASS: TestAccAWSSESReceiptRuleSet_basic (38.07s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner February 14, 2021 14:36
@ghost ghost added size/S Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/ses Issues and PRs that pertain to the ses service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 14, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Feb 14, 2021
@YakDriver YakDriver self-assigned this Feb 18, 2021
@YakDriver YakDriver force-pushed the r/ses_receipt_rule_set_arn2 branch from f5e9f8a to 70efba1 Compare February 18, 2021 22:10
@ghost ghost added size/M Managed by automation to categorize the size of a PR. and removed size/S Managed by automation to categorize the size of a PR. labels Feb 18, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🎉

Acceptance tests on GovCloud:

--- SKIP: TestAccAWSSESReceiptRuleSet_basic (1.98s)
--- SKIP: TestAccAWSSESReceiptRuleSet_disappears (2.21s)

us-west-2:

--- PASS: TestAccAWSSESReceiptRuleSet_disappears (9.99s)
--- PASS: TestAccAWSSESReceiptRuleSet_basic (13.17s)

@YakDriver YakDriver added this to the v3.29.0 milestone Feb 18, 2021
@YakDriver YakDriver merged commit c7f9a88 into hashicorp:main Feb 18, 2021
@ghost
Copy link

ghost commented Feb 19, 2021

This has been released in version 3.29.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 21, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 21, 2021
@DrFaust92 DrFaust92 deleted the r/ses_receipt_rule_set_arn2 branch April 15, 2021 10:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/ses Issues and PRs that pertain to the ses service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants