Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: AWS Shield Protection #1769

Closed
countergram opened this issue Sep 28, 2017 · 13 comments · Fixed by #7721
Closed

Feature Request: AWS Shield Protection #1769

countergram opened this issue Sep 28, 2017 · 13 comments · Fixed by #7721
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/shield Issues and PRs that pertain to the shield service.
Milestone

Comments

@countergram
Copy link

I would like to be able to manage "protection" objects within AWS Shield so that I can declaratively add protections to my resources (which are also managed through Terraform)

@Ninir Ninir added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 11, 2017
@atsushi-ishibashi
Copy link
Contributor

I'm developing this resource. But ShieldProtection requires ShiledSubscription and I'm having a trouble to find the way of activating shield advanced...
It costs $3,000 / month...

@countergram
Copy link
Author

My company has it - how can I help?

@radeksimko radeksimko added the service/shield Issues and PRs that pertain to the shield service. label Jan 28, 2018
@vianellod
Copy link

Hey, any progress on this one?

@grealish
Copy link

grealish commented Apr 5, 2018

@atsushi-ishibashi I maybe able to get you access to a test account to setup shield advanced as I have this subscription already ;)
Let me know how I can help

@atsushi-ishibashi
Copy link
Contributor

This depends on the policy of the acceptance test🤔

@thakkerdhawal
Copy link

+1

@jcornell123
Copy link

How can we test this for the community? @akataz

@iwasnobody
Copy link

+1

@akataz
Copy link

akataz commented Jul 18, 2018

I was able to successfully test only the shield advanced part via 'make testacc' by adding '-run=TestAccAWSShieldSubscription' the makefile, as I showed in: PR #1899 . I have not had success testing the complete run-through of 'make testacc'; if anyone has any suggestions they would be appreciated.
screen shot 2018-07-17 at 5 07 24 pm

@akataz
Copy link

akataz commented Oct 25, 2018

I've talked to Hashicorp Support and they said they need another company to test the PR before they can merge this, is there anyone with a Shield Advanced Subscription that can test this? @grealish @countergram

@bflad
Copy link
Contributor

bflad commented May 15, 2019

A new aws_shield_protection resource has been merged and will release with version 2.11.0 of the Terraform AWS Provider, likely tomorrow. 👍

For future bug reports or feature requests with the Shield Advanced service, please submit a new GitHub issue. Thanks!

@bflad
Copy link
Contributor

bflad commented May 17, 2019

The new aws_shield_protection resource has been released in version 2.11.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/shield Issues and PRs that pertain to the shield service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.