Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-source/iam_policy_document: Keep empty conditions #17752

Merged
merged 3 commits into from
Feb 22, 2021
Merged

data-source/iam_policy_document: Keep empty conditions #17752

merged 3 commits into from
Feb 22, 2021

Conversation

YakDriver
Copy link
Member

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17711

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSDataSourceIAMPolicyDocument_basic (11.88s)

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSDataSourceIAMPolicyDocument_basic (8.57s)

@YakDriver YakDriver requested a review from a team as a code owner February 22, 2021 19:07
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Feb 22, 2021
@YakDriver YakDriver mentioned this pull request Feb 22, 2021
Closed
@YakDriver
Copy link
Member Author

All acceptance tests (GovCloud):

--- SKIP: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_multiplePrincipals (1.26s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceListConflicting (4.69s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceConflicting (17.45s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementMerge (17.79s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_basic (17.80s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceList (17.88s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_stringAndSlice (17.93s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_override (17.93s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_multiplePrincipalsGov (17.94s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementOverride (17.94s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_overrideList (17.98s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_duplicateSid (18.77s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_version20081017 (24.60s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_source (26.72s)

us-west-2:

--- SKIP: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_multiplePrincipalsGov (0.70s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceListConflicting (3.67s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_stringAndSlice (13.67s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_statementPrincipalIdentifiers_multiplePrincipals (14.03s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceConflicting (14.26s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementMerge (14.26s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_override (14.27s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_noStatementOverride (14.27s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_sourceList (14.27s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_overrideList (14.40s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_basic (14.40s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_duplicateSid (14.43s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_version20081017 (18.76s)
--- PASS: TestAccAWSDataSourceIAMPolicyDocument_source (20.07s)

anGie44
anGie44 reviewed Feb 22, 2021
View reviewed changes
.changelog/17752.txt Outdated Show resolved Hide resolved
@YakDriver @anGie44
Update .changelog/17752.txt
6cd0ff1 
Co-authored-by: angie pinilla <angelinepinilla@gmail.com>
anGie44
anGie44 approved these changes Feb 22, 2021
View reviewed changes
Copy link
Contributor

@anGie44 anGie44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@YakDriver YakDriver modified the milestones: v.3.29.1, v3.29.1 Feb 22, 2021
@YakDriver YakDriver merged commit d79b6c3 into main Feb 22, 2021
@YakDriver YakDriver deleted the b-iam-regressions branch February 22, 2021 21:40
@github-actions github-actions bot modified the milestones: v3.29.1, v3.30.0 Feb 22, 2021
github-actions bot pushed a commit that referenced this pull request Feb 22, 2021
Update CHANGELOG.md for #17752
a39a16a
@YakDriver YakDriver modified the milestones: v3.30.0, v3.29.1 Feb 22, 2021
@ghost
Copy link

ghost commented Feb 23, 2021

This has been released in version 3.29.1 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Mar 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@anGie44 anGie44 anGie44 approved these changes

Assignees
No one assigned
Labels
service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.29.1
Development

Successfully merging this pull request may close these issues.

Empty strings are removed from aws_iam_policy_document condition statements
2 participants
@YakDriver @anGie44