Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_acmpca_certificate_authority: Remove returned status value #17832

Closed
gdavison opened this issue Feb 25, 2021 · 4 comments
Closed
Assignees
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/acmpca Issues and PRs that pertain to the acmpca service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@gdavison
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When an aws_acmpca_certificate_authority is created, it enters the state CERTIFICATE_PENDING, where it needs to have a certificate imported before it can be used. A root CA can create its own self-signed certificate when in this state.

A certificate can be imported using the console, API, or CLI, and there is work in progress to add the aws_acmpca_certificate_authority_certificate resource. When a certificate is imported, the status of the certificate authority changes to ACTIVE. In all of the above cases, Terraform will still report the status CERTIFICATE_PENDING.

The only other practitioner-controllable status is DISABLED. All other states are transitional, and the providers waits until the resource reaches a non-transitional state. https://docs.aws.amazon.com/acm-pca/latest/userguide/PCAUpdateCA.html details the possible states.

Switching between ACTIVE and DISABLED is controlled by the enabled flag on the resource.

These factors make the status field superfluous and sometimes-incorrect, so it should be removed.

Affected Resource

  • aws_acmpca_certificate_authority
@gdavison gdavison added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. technical-debt Addresses areas of the codebase that need refactoring or redesign. labels Feb 25, 2021
@gdavison gdavison added this to the v4.0.0 milestone Feb 25, 2021
@ghost ghost added the service/acmpca Issues and PRs that pertain to the acmpca service. label Feb 25, 2021
@anGie44 anGie44 assigned anGie44 and zhelding and unassigned anGie44 Jan 18, 2022
@zhelding
Copy link
Contributor

zhelding commented Feb 2, 2022

PR #22878 has deprecated the status attribute as part of release v4.0.

The status attribute is scheduled to be removed as part of major version release v5.0.

@jar-b
Copy link
Member

jar-b commented May 23, 2023

Closed by #31084, merged to main via #31392

@jar-b jar-b closed this as completed May 23, 2023
@github-actions
Copy link

This functionality has been released in v5.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. service/acmpca Issues and PRs that pertain to the acmpca service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
Development

No branches or pull requests

5 participants