New Data Source: aws_dx_connection #17852

yzguy · 2021-02-27T03:14:55Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18400.
Closes #10472.
Closes #17853.

Output from acceptance testing:

-> make testacc TESTARGS='-run=TestAccDataSourceAwsDxConnection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDxConnection -timeout 120m
=== RUN   TestAccDataSourceAwsDxConnection_basic
=== PAUSE TestAccDataSourceAwsDxConnection_basic
=== CONT  TestAccDataSourceAwsDxConnection_basic
--- PASS: TestAccDataSourceAwsDxConnection_basic (23.06s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	25.404s

github-actions

Welcome @yzguy 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

ewbankkit · 2021-02-28T22:15:08Z

Similar:

d/aws_dx_connection: Adding new data source for Direct Connect connection #9705

ewbankkit · 2021-02-28T22:29:42Z

@yzguy Thanks for the contribution 👏.
There is a stale PR #9705 that adds the same data source.
Could you please add the additional attributes from that PR?

yzguy · 2021-03-01T14:33:08Z

@ewbankkit Absolutely! Will update PR soon.

yzguy · 2021-03-01T20:03:10Z

Couple things I believe I did right, but am unsure.

You can search by ID or Name. If you used both, it would search for the connection with the specific ID, then only continue if it found the one with the specified name. If it didn't it would error out. Not sure if it's necessary to actually make them mutually exclusive.
It looks like AWS does not allow filtering on DirectConnect connections so I left this out, but I'm unsure if searching by tags would still be a good idea.
A couple of the fields (vlan, partner_name, provider_name, lag_id) are not present in the JSON response from AWS all the time, and I believe depending on if it's a Hosted versus Dedicated connection they will show up, or if you have 2 or more connections in LAG. I don't have access to an environment that uses hosted connections, only dedicated. Therefore I have made them only added when they are present in the JSON.

I referenced @robh007 #9705 and @beezly branch and want to make sure to give credit as some parts were copy+paste.

ewbankkit · 2021-03-01T22:12:36Z

@yzguy The better way here I think would be to add an additional data source aws_dx_connections where connections can be filtered by name or tags. This DS would output just a set of IDs. The aws_dx_connection would have the one required attribute connection_id and output all the other connection attributes.
You can look at the aws_apigatewayv2_apis and aws_apigatewayv2_api data sources for an example for how to approach this.
BTW you don't need the != nil check for fields missing from the API response, d.Set() handles nil input.

Let me know if this is not clear or if you are unable to make progress.
Thanks.

yzguy · 2021-03-12T04:08:13Z

-> make testacc TESTARGS='-run=TestAccDataSourceAwsDxConnection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDxConnection -timeout 120m
^[[A=== RUN   TestAccDataSourceAwsDxConnection_basic
=== PAUSE TestAccDataSourceAwsDxConnection_basic
=== RUN   TestAccDataSourceAwsDxConnections_Name
--- PASS: TestAccDataSourceAwsDxConnections_Name (21.49s)
=== RUN   TestAccDataSourceAwsDxConnections_Tags
--- PASS: TestAccDataSourceAwsDxConnections_Tags (19.61s)
=== CONT  TestAccDataSourceAwsDxConnection_basic
--- PASS: TestAccDataSourceAwsDxConnection_basic (19.90s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	63.153s

yzguy · 2021-03-12T04:28:33Z

@ewbankkit I was able to get back to this after, completing the changes you suggested. Using the API Gateway v2 Datasource as a reference.

Couple things I'm not sure about are on data.aws_dx_connection there are a bunch of attributes that are not returned by aws_dx_connection, so I'm not checking they match in the test. I'm not sure best way to go about that, perhaps just checking that the attributes are set on the data source.

Other thing is that I pass in the Bandwidth and Locations in the tests, and that works, but I believe because both are us-east-1 resources, and that's my default region that works fine, but we can't be 100% certain that the tests run in us-east-1, or that they would be forever. I believe maybe a better choice would be to have perhaps a map of locations per regions, then just randomly select one for whatever region the tests run it.

aws/data_source_aws_dx_connections.go

ewbankkit · 2021-03-14T20:30:19Z

@yzguy The location/bandwidth issue will be resolvable once #9735, aws_dx_location(s) data sources, has been merged.
Don't worry about checking for specific values of any of those attributes, just checking that they are set is sufficient.
There are also some formatting issues with the acceptance test configurations.
Thanks.

ewbankkit · 2021-03-25T13:22:13Z

@yzguy Could you please add "Closes #18400" to the initial comment; Thanks.

yzguy · 2021-03-25T16:14:15Z

@ewbankkit Done!

Acceptance test output: % make testacc TESTARGS='-run=TestAccAwsDxConnection_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDxConnection_ -timeout 180m === RUN TestAccAwsDxConnection_basic === PAUSE TestAccAwsDxConnection_basic === RUN TestAccAwsDxConnection_disappears === PAUSE TestAccAwsDxConnection_disappears === RUN TestAccAwsDxConnection_Tags === PAUSE TestAccAwsDxConnection_Tags === CONT TestAccAwsDxConnection_basic === CONT TestAccAwsDxConnection_Tags === CONT TestAccAwsDxConnection_disappears --- PASS: TestAccAwsDxConnection_disappears (24.65s) --- PASS: TestAccAwsDxConnection_basic (30.83s) --- PASS: TestAccAwsDxConnection_Tags (68.13s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 74.122s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAwsDxConnection_\|TestAccAwsDxLag_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDxConnection_\|TestAccAwsDxLag_ -timeout 180m === RUN TestAccAwsDxConnection_basic === PAUSE TestAccAwsDxConnection_basic === RUN TestAccAwsDxConnection_disappears === PAUSE TestAccAwsDxConnection_disappears === RUN TestAccAwsDxConnection_Tags === PAUSE TestAccAwsDxConnection_Tags === RUN TestAccAwsDxLag_basic === PAUSE TestAccAwsDxLag_basic === RUN TestAccAwsDxLag_disappears === PAUSE TestAccAwsDxLag_disappears === RUN TestAccAwsDxLag_Tags === PAUSE TestAccAwsDxLag_Tags === CONT TestAccAwsDxConnection_basic === CONT TestAccAwsDxLag_disappears === CONT TestAccAwsDxLag_Tags === CONT TestAccAwsDxConnection_disappears === CONT TestAccAwsDxConnection_Tags === CONT TestAccAwsDxLag_basic --- PASS: TestAccAwsDxLag_disappears (19.44s) --- PASS: TestAccAwsDxConnection_disappears (19.49s) --- PASS: TestAccAwsDxConnection_basic (23.77s) --- PASS: TestAccAwsDxLag_basic (36.78s) --- PASS: TestAccAwsDxConnection_Tags (52.49s) --- PASS: TestAccAwsDxLag_Tags (53.92s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 57.070s

Acceptance test output: % make testacc TESTARGS='-run=TestAccAWSDxConnectionAssociation_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDxConnectionAssociation_ -timeout 180m === RUN TestAccAWSDxConnectionAssociation_basic === PAUSE TestAccAWSDxConnectionAssociation_basic === RUN TestAccAWSDxConnectionAssociation_multiConns === PAUSE TestAccAWSDxConnectionAssociation_multiConns === CONT TestAccAWSDxConnectionAssociation_basic === CONT TestAccAWSDxConnectionAssociation_multiConns --- PASS: TestAccAWSDxConnectionAssociation_basic (25.72s) --- PASS: TestAccAWSDxConnectionAssociation_multiConns (26.54s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 34.593s

r/aws_dx_lag: Add 'owner_account_id' attribute. Acceptance test output: % make testacc TESTARGS='-run=TestAccAwsDxConnection_basic\|TestAccAwsDxLag_basic' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDxConnection_basic\|TestAccAwsDxLag_basic -timeout 180m === RUN TestAccAwsDxConnection_basic === PAUSE TestAccAwsDxConnection_basic === RUN TestAccAwsDxLag_basic === PAUSE TestAccAwsDxLag_basic === CONT TestAccAwsDxConnection_basic === CONT TestAccAwsDxLag_basic --- PASS: TestAccAwsDxConnection_basic (19.66s) --- PASS: TestAccAwsDxLag_basic (33.61s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 36.900s

Acceptance test output: % make testacc TESTARGS='-run=TestAccDataSourceAwsDxConnection_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDxConnection_ -timeout 180m === RUN TestAccDataSourceAwsDxConnection_basic === PAUSE TestAccDataSourceAwsDxConnection_basic === CONT TestAccDataSourceAwsDxConnection_basic --- PASS: TestAccDataSourceAwsDxConnection_basic (16.58s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 21.036s

r/aws_dx_lag: Add 'provider_name' argument. Acceptance test output: % make testacc TESTARGS='-run=TestAccAwsDxConnection_basic\|TestAccAwsDxConnection_ProviderName' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDxConnection_basic\|TestAccAwsDxConnection_ProviderName -timeout 180m === RUN TestAccAwsDxConnection_basic === PAUSE TestAccAwsDxConnection_basic === RUN TestAccAwsDxConnection_ProviderName === PAUSE TestAccAwsDxConnection_ProviderName === CONT TestAccAwsDxConnection_basic === CONT TestAccAwsDxConnection_ProviderName --- PASS: TestAccAwsDxConnection_basic (23.95s) --- PASS: TestAccAwsDxConnection_ProviderName (26.53s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 32.586s % make testacc TESTARGS='-run=TestAccAwsDxLag_basic\|TestAccAwsDxLag_ProviderName' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsDxLag_basic\|TestAccAwsDxLag_ProviderName -timeout 180m === RUN TestAccAwsDxLag_basic === PAUSE TestAccAwsDxLag_basic === RUN TestAccAwsDxLag_ProviderName === PAUSE TestAccAwsDxLag_ProviderName === CONT TestAccAwsDxLag_basic === CONT TestAccAwsDxLag_ProviderName --- PASS: TestAccAwsDxLag_ProviderName (24.24s) --- PASS: TestAccAwsDxLag_basic (33.67s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 39.380s

Acceptance test output: % make testacc TESTARGS='-run=TestAccDataSourceAwsDxConnection_' ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDxConnection_ -timeout 180m === RUN TestAccDataSourceAwsDxConnection_basic === PAUSE TestAccDataSourceAwsDxConnection_basic === CONT TestAccDataSourceAwsDxConnection_basic --- PASS: TestAccDataSourceAwsDxConnection_basic (24.67s) PASS ok github.com/terraform-providers/terraform-provider-aws/aws 29.105s

ewbankkit

LGTM 🚀.

Commercial

% make testacc TESTARGS='-run=TestAccDataSourceAwsDxConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDxConnection_ -timeout 180m
=== RUN   TestAccDataSourceAwsDxConnection_basic
=== PAUSE TestAccDataSourceAwsDxConnection_basic
=== CONT  TestAccDataSourceAwsDxConnection_basic
--- PASS: TestAccDataSourceAwsDxConnection_basic (24.67s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       29.105s

GovCloud

% make testacc TESTARGS='-run=TestAccDataSourceAwsDxConnection_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsDxConnection_ -timeout 180m
=== RUN   TestAccDataSourceAwsDxConnection_basic
=== PAUSE TestAccDataSourceAwsDxConnection_basic
=== CONT  TestAccDataSourceAwsDxConnection_basic
--- PASS: TestAccDataSourceAwsDxConnection_basic (31.53s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	36.544s

ewbankkit · 2021-08-25T18:22:04Z

@yzguy Thanks for the contribution 🎉 👏.
I went ahead and added some additional attributes to the data source.

github-actions · 2021-08-31T17:15:26Z

This functionality has been released in v3.56.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-06-18T02:34:17Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

yzguy requested a review from a team as a code owner February 27, 2021 03:14

github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Feb 27, 2021

yzguy mentioned this pull request Feb 27, 2021

Add aws_dx_connection data source #17853

Closed

github-actions bot reviewed Feb 27, 2021

View reviewed changes

ewbankkit mentioned this pull request Feb 28, 2021

d/aws_dx_connection: Adding new data source for Direct Connect connection #9705

Closed

ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Feb 28, 2021

ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 1, 2021

ewbankkit reviewed Mar 14, 2021

View reviewed changes

aws/data_source_aws_dx_connections.go Outdated Show resolved Hide resolved

github-actions bot removed provider Pertains to the provider itself, rather than any interaction with AWS. documentation Introduces or discusses updates to documentation. size/XL Managed by automation to categorize the size of a PR. labels Aug 5, 2021

ewbankkit and others added 10 commits August 24, 2021 15:25

Use 'tfresource.NewTooManyResultsError'.

1274562

data_source_aws_dx_connection

e32ffd8

Add CHANGELOG entry.

95dc48b

ewbankkit added new-data-source Introduces a new data source. and removed service/location Issues and PRs that pertain to the location service. labels Aug 25, 2021

ewbankkit added 2 commits August 25, 2021 14:05

Fix 'XAT001: missing ErrorCheck'.

20a66e9

Remove trailing whitespace.

7b99f14

github-actions bot added the service/location Issues and PRs that pertain to the location service. label Aug 25, 2021

ewbankkit approved these changes Aug 25, 2021

View reviewed changes

ewbankkit removed the service/location Issues and PRs that pertain to the location service. label Aug 25, 2021

ewbankkit merged commit 709e4a0 into hashicorp:main Aug 25, 2021

github-actions bot added this to the v3.56.0 milestone Aug 25, 2021

yzguy deleted the data_source_aws_dx_connection branch August 25, 2021 21:18

ewbankkit mentioned this pull request Sep 29, 2021

DirectConnect Connection & LAG: provider_name -> Computed #21085

Merged

github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New Data Source: aws_dx_connection #17852

New Data Source: aws_dx_connection #17852

yzguy commented Feb 27, 2021 •

edited by ewbankkit

Loading

github-actions bot left a comment

ewbankkit commented Feb 28, 2021

ewbankkit commented Feb 28, 2021

yzguy commented Mar 1, 2021

yzguy commented Mar 1, 2021 •

edited

Loading

ewbankkit commented Mar 1, 2021

yzguy commented Mar 12, 2021 •

edited

Loading

yzguy commented Mar 12, 2021

ewbankkit commented Mar 14, 2021

ewbankkit commented Mar 25, 2021 •

edited

Loading

yzguy commented Mar 25, 2021

ewbankkit left a comment

ewbankkit commented Aug 25, 2021

github-actions bot commented Aug 31, 2021

github-actions bot commented Jun 18, 2022

New Data Source: aws_dx_connection #17852

New Data Source: aws_dx_connection #17852

Conversation

yzguy commented Feb 27, 2021 • edited by ewbankkit Loading

Community Note

github-actions bot left a comment

Choose a reason for hiding this comment

ewbankkit commented Feb 28, 2021

ewbankkit commented Feb 28, 2021

yzguy commented Mar 1, 2021

yzguy commented Mar 1, 2021 • edited Loading

ewbankkit commented Mar 1, 2021

yzguy commented Mar 12, 2021 • edited Loading

yzguy commented Mar 12, 2021

ewbankkit commented Mar 14, 2021

ewbankkit commented Mar 25, 2021 • edited Loading

yzguy commented Mar 25, 2021

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Aug 25, 2021

github-actions bot commented Aug 31, 2021

github-actions bot commented Jun 18, 2022

yzguy commented Feb 27, 2021 •

edited by ewbankkit

Loading

yzguy commented Mar 1, 2021 •

edited

Loading

yzguy commented Mar 12, 2021 •

edited

Loading

ewbankkit commented Mar 25, 2021 •

edited

Loading