Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add partner_event_bus_name as an argument for "aws_cloudwatch_event_rule" & "aws_cloudwatch_event_target" #17887

Closed
fadwamen opened this issue Mar 2, 2021 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudwatch Issues and PRs that pertain to the cloudwatch service.

Comments

@fadwamen
Copy link

fadwamen commented Mar 2, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

ADD a "partner_event_bus_name" argument that support the / character of the autogenerated name of partner_event_bus " into ressource "aws_cloudwatch_event_rule" & "aws_cloudwatch_event_target" in order to make possible the association of these ressources with an existing partner_event_bus

New argument(s)

partner_event_bus_name

###Affected Resource(s)

  • aws_cloudwatch_event_rule
  • aws_cloudwatch_event_target

Terraform CLI and Terraform AWS Provider Version

> terraform -v 

Terraform v0.13.5 
+ provider registry.terraform.io/hashicorp/aws v3.30.0

Potential Terraform Configuration

resource "aws_cloudwatch_event_rule" "Example" {
  name        = "capture-aws-sign-in"
  partner_event_bus_name = "aws.partner/appflow/salesforce.com/example"
  description = "Capture each AWS Console Sign In"

  event_pattern = <<EOF
{
  "detail-type": [
    "AWS Console Sign In via CloudTrail"
  ]
}
EOF
}

References

pull-requests
#16815
Issue:
#16431

@fadwamen fadwamen added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 2, 2021
@ghost ghost added service/cloudwatchevents service/cloudwatch Issues and PRs that pertain to the cloudwatch service. labels Mar 2, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 2, 2021
@fadwamen fadwamen changed the title ADD: partner_event_bus_name as an argument for "aws_cloudwatch_event_rule" & "aws_cloudwatch_event_target" Feature request: Add partner_event_bus_name as an argument for "aws_cloudwatch_event_rule" & "aws_cloudwatch_event_target" Mar 2, 2021
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 3, 2021
@bflad
Copy link
Contributor

bflad commented Mar 3, 2021

Hi @fadwamen 👋 Thank you for raising this.

It appears that the underlying EventBridge API (PutRule / PutTarget) supports only a single EventBusName field matching the event_bus_name argument in Terraform across the various aws_cloudwatch_event_bus, aws_cloudwatch_event_rule, and aws_cloudwatch_event_target resources. What seems to be missing is that the validation for the existing arguments in Terraform should allow / characters, so that aws.partner/... can be passed in.

This change appears to be covered already by #16431 and #16815, so to consolidate efforts and discussions on this topic and since this feature request would not match the design of the Terraform AWS Provider as written, I'm going to close this issue. Please 👍 react and subscribe to those for further updates on this. Thank you again for submitting this proposal.

@bflad bflad closed this as completed Mar 3, 2021
@ghost
Copy link

ghost commented Apr 3, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/cloudwatch Issues and PRs that pertain to the cloudwatch service.
Projects
None yet
Development

No branches or pull requests

2 participants