Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "storage-optimization" to Neptune cluster instance create/update pending states #17901

Merged
merged 2 commits into from
Mar 4, 2021
Merged

Add "storage-optimization" to Neptune cluster instance create/update pending states #17901

merged 2 commits into from
Mar 4, 2021

Conversation

jbmchuck
Copy link
Contributor

@jbmchuck jbmchuck commented Mar 3, 2021

I've found when a Neptune instance is resized I now get the following
error:

 Error: unexpected state 'storage-optimization', wanted target 'available'. last error: %!s(<nil>)

This is very similar to #15284

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #0000

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

I've found when a Neptune instance is resized I now get the following
error:

     Error: unexpected state 'storage-optimization', wanted target 'available'. last error: %!s(<nil>)

This is very similar to #15284
@jbmchuck jbmchuck requested a review from a team as a code owner March 3, 2021 17:38
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/neptune Issues and PRs that pertain to the neptune service. labels Mar 3, 2021
@jbmchuck jbmchuck changed the title [WIP] Add storage-optimization to Neptune instance pending state [WIP] Add storage-optimization to Neptune instance pending states Mar 3, 2021
@jbmchuck jbmchuck changed the title [WIP] Add storage-optimization to Neptune instance pending states [WIP] Add "storage-optimization" to Neptune cluster instance create/update pending states Mar 3, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 3, 2021
@jbmchuck jbmchuck changed the title [WIP] Add "storage-optimization" to Neptune cluster instance create/update pending states Add "storage-optimization" to Neptune cluster instance create/update pending states Mar 3, 2021
@bflad bflad removed the needs-triage Waiting for first response or review from a maintainer. label Mar 4, 2021
@bflad bflad self-assigned this Mar 4, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you, @jbmchuck 🚀

Output from acceptance testing:

--- PASS: TestAccAWSNeptuneClusterInstance_generatedName (568.53s)
--- PASS: TestAccAWSNeptuneClusterInstance_namePrefix (588.57s)
--- PASS: TestAccAWSNeptuneClusterInstance_withSubnetGroup (754.94s)
--- PASS: TestAccAWSNeptuneClusterInstance_kmsKey (775.82s)
--- PASS: TestAccAWSNeptuneClusterInstance_withaz (834.37s)
--- PASS: TestAccAWSNeptuneClusterInstance_basic (859.18s)

@bflad bflad added the bug Addresses a defect in current functionality. label Mar 4, 2021
@bflad bflad merged commit 9773cad into hashicorp:main Mar 4, 2021
@github-actions github-actions bot added this to the v3.31.0 milestone Mar 4, 2021
@ghost
Copy link

ghost commented Mar 5, 2021

This has been released in version 3.31.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 4, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/neptune Issues and PRs that pertain to the neptune service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants