Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_appautoscaling_scheduled_action: Some optional fields are actually required by AWS API #17963

Closed
gdavison opened this issue Mar 5, 2021 · 3 comments
Milestone

Comments

@gdavison
Copy link
Contributor

gdavison commented Mar 5, 2021

The resource aws_appautoscaling_scheduled_action considers the parameters scalable_dimension, scalable_target_action, and schedule to be optional. However, they are required by the AWS API to create a new scheduled action. Since the AWS API provides only a Put operation, these parameters are technically optional, since they do not need to be passed on update if the values are not changing.

Mark these parameters are required in code and documentation.

Typically, converting a parameter from optional to required is a breaking change. In this case, the AWS API is already returning an error, so there will be no impact on practitioners.

Affected Resource

  • aws_appautoscaling_scheduled_action
@gdavison gdavison added the bug Addresses a defect in current functionality. label Mar 5, 2021
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Mar 5, 2021
@gdavison
Copy link
Contributor Author

gdavison commented Mar 9, 2021

This was resolved by #8777

@gdavison gdavison closed this as completed Mar 9, 2021
@gdavison gdavison added this to the v3.32.0 milestone Mar 9, 2021
@ghost
Copy link

ghost commented Mar 12, 2021

This has been released in version 3.32.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 8, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant