Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/iam_saml_provider - add tagging support + validations #17965

Merged
merged 3 commits into from
Mar 25, 2021
Merged

r/iam_saml_provider - add tagging support + validations #17965

merged 3 commits into from
Mar 25, 2021

Conversation

DrFaust92
Copy link
Collaborator

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17594

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSIAMSamlProvider_'
--- PASS: TestAccAWSIAMSamlProvider_disappears (26.74s)
--- PASS: TestAccAWSIAMSamlProvider_basic (58.14s)
--- PASS: TestAccAWSIAMSamlProvider_tags (84.33s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner March 5, 2021 22:55
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 5, 2021
@ghost ghost added size/L Managed by automation to categorize the size of a PR. and removed size/M Managed by automation to categorize the size of a PR. labels Mar 5, 2021
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 6, 2021
@ewbankkit
Copy link
Contributor

Verified acceptance tests:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSIAMSamlProvider_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMSamlProvider_ -timeout 120m
=== RUN   TestAccAWSIAMSamlProvider_basic
=== PAUSE TestAccAWSIAMSamlProvider_basic
=== RUN   TestAccAWSIAMSamlProvider_tags
=== PAUSE TestAccAWSIAMSamlProvider_tags
=== RUN   TestAccAWSIAMSamlProvider_disappears
=== PAUSE TestAccAWSIAMSamlProvider_disappears
=== CONT  TestAccAWSIAMSamlProvider_basic
=== CONT  TestAccAWSIAMSamlProvider_disappears
=== CONT  TestAccAWSIAMSamlProvider_tags
--- PASS: TestAccAWSIAMSamlProvider_disappears (12.28s)
--- PASS: TestAccAWSIAMSamlProvider_basic (24.49s)
--- PASS: TestAccAWSIAMSamlProvider_tags (32.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	32.505s

@bflad bflad self-assigned this Mar 25, 2021
bflad
bflad approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @DrFaust92 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSIAMSamlProvider_disappears (9.84s)
--- PASS: TestAccAWSIAMSamlProvider_basic (20.71s)
--- PASS: TestAccAWSIAMSamlProvider_tags (29.18s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSIAMSamlProvider_disappears (16.38s)
--- PASS: TestAccAWSIAMSamlProvider_basic (34.37s)
--- PASS: TestAccAWSIAMSamlProvider_tags (45.99s)

website/docs/r/iam_saml_provider.html.markdown
@@ -32,6 +32,7 @@ In addition to all arguments above, the following attributes are exported:

* `arn` - The ARN assigned by AWS for this provider.
* `valid_until` - The expiration date and time for the SAML provider in RFC1123 format, e.g. `Mon, 02 Jan 2006 15:04:05 MST`.
* `tags` - Key-value map of tags for the IAM SAML provider.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argument, not just attribute 👍 Will fix on merge.

@bflad bflad merged commit 90f6829 into hashicorp:main Mar 25, 2021
@github-actions github-actions bot added this to the v3.34.0 milestone Mar 25, 2021
@ghost
Copy link

ghost commented Mar 26, 2021

This has been released in version 3.34.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@DrFaust92 DrFaust92 deleted the r/iam_saml_provider_tags branch April 15, 2021 10:35
@ghost
Copy link

ghost commented Apr 25, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. provider Pertains to the provider itself, rather than any interaction with AWS. service/iam Issues and PRs that pertain to the iam service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.34.0
Development

Successfully merging this pull request may close these issues.
3 participants
@DrFaust92 @ewbankkit @bflad