Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support time zone parameter for aws_autoscaling_schedule #18098

Closed
nbr opened this issue Mar 15, 2021 · 7 comments
Closed

Support time zone parameter for aws_autoscaling_schedule #18098

nbr opened this issue Mar 15, 2021 · 7 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.

Comments

@nbr
Copy link

nbr commented Mar 15, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS recently announced support for local time zones for scheduled scaling actions. PutScheduledUpdateGroupAction now supports a TimeZone parameter.

New or Affected Resource(s)

  • aws_autoscaling_schedule

Potential Terraform Configuration

resource "aws_autoscaling_schedule" "foobar" {
  scheduled_action_name  = "foobar"
  min_size               = 0
  max_size               = 1
  desired_capacity       = 0
  recurrence             = "0 9 * * *"
  time_zone              = "America/New_York"
  autoscaling_group_name = aws_autoscaling_group.foobar.name
}

References

@nbr nbr added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 15, 2021
@ghost ghost added the service/autoscaling Issues and PRs that pertain to the autoscaling service. label Mar 15, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 15, 2021
@ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2021
@gpanula
Copy link

gpanula commented Mar 16, 2021

timezone config knob was added to aws_appautoscaling_scheduled_action in PR #17689

I am uncertain if aws_appautoscaling_scheduled_action could used as a work-around/replacement for aws_autoscaling_schedule. It would still be good to have the timezone config knob in aws_autoscaling_schedule.

@nbr
Copy link
Author

nbr commented Mar 16, 2021

timezone config knob was added to aws_appautoscaling_scheduled_action in PR #17689

I am uncertain if aws_appautoscaling_scheduled_action could used as a work-around/replacement for aws_autoscaling_schedule. It would still be good to have the timezone config knob in aws_autoscaling_schedule.

@gpanula According to the Application Auto Scaling API reference, EC2 Auto Scaling Groups are not valid targets.

@JBSoul
Copy link

JBSoul commented Aug 4, 2021

Any updates on this?

@gpanula
Copy link

gpanula commented Aug 11, 2021

Requires AWS SDK v1.37.27:

aws-sdk-go was bumped up to 1.38.0 in PR #18274

@lachlancooper
Copy link
Contributor

It looks like the time_zone parameter was added in #19829, released with provider version 3.52.0.

@nbr nbr closed this as completed Oct 19, 2021
@github-actions
Copy link

github-actions bot commented Jun 2, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/autoscaling Issues and PRs that pertain to the autoscaling service.
Projects
None yet
Development

No branches or pull requests

5 participants