Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS Failure Injection Simulator (FIS) experiment template resource #18125

Closed
mwarkentin opened this issue Mar 16, 2021 · 7 comments · Fixed by #20179
Closed

AWS Failure Injection Simulator (FIS) experiment template resource #18125

mwarkentin opened this issue Mar 16, 2021 · 7 comments · Fixed by #20179
Assignees
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource.
Milestone

Comments

@mwarkentin
Copy link
Contributor

mwarkentin commented Mar 16, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Amazon just launched AWS FIS (Failure Injection Simulator) in GA (blog post). The experiment templates look like a good fit for terraform.

New or Affected Resource(s)

  • aws_fis_experiment_template

Potential Terraform Configuration

This seems like a pretty complex resource so I've filled out most of the available options, but the structure is very likely not what it should look like in the end.

resource "aws_fis_experiment_template" "main" {
  description = "Description of the experiment template."

  # Note: This is a list of conditions in the AWS API
  stop_condition = {
    source = "aws:cloudwatch:alarm"
    value = "aws:cloudwatch:arn"
  }

  # Note: This is a list of targets in the AWS API
  target = {
    # There are 6 resource types currently
    resource_type = "aws:ec2:instance"

    resource_arns = [
       "arn:to:ec2:instance1",
       "arn:to:ec2:instance2",
    ]

    resource_tags = [
      {
        key = "TagName"
        value = "TagValue"
      }
    ]

    filters = [
      {
        path = "string",
        values = ["val1", "val2"]
      }
    ]

    # One of ALL, count(n), percent(n)
    selection_mode = "percent(25)"
  }

  # Note: this is a list of actions in the AWS API
  action {
    action_id = "actionId1"
    description = "This is an action description."

    start_after = [
      "actionId2"
    ]
   
    # List of parameters
    parameter {
      
    }

    # List of targets
    { 

    }
  }
}

References

@mwarkentin mwarkentin added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 16, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 16, 2021
@ewbankkit
Copy link
Contributor

Requires AWS SDK v1.37.31:

@ewbankkit ewbankkit added the new-resource Introduces a new resource. label Mar 16, 2021
@bill-rich bill-rich removed the needs-triage Waiting for first response or review from a maintainer. label Mar 17, 2021
@puneet739
Copy link

Hi there, any update on this, This is a good service and should be available. Its already been more then 1 year

@dknz2008
Copy link

Hi, would love an update on this, FIS has been out for a while now

@ashutoshupadhyay
Copy link

ashutoshupadhyay commented May 4, 2022

You may already know and using it already, something along the lines is currently available via "awscc" provider. Obviously it means using a different provider but it is quite handy as compared to writing custom scripts. Happy to share sample code if anyone needs. https://registry.terraform.io/providers/hashicorp/awscc/latest/docs/resources/fis_experiment_template

@breathingdust
Copy link
Member

Hi all 👋 Just letting you know that this is issue is featured on this quarters roadmap. If a PR exists to close the issue a maintainer will review and either make changes directly, or work with the original author to get the contribution merged. If you have written a PR to resolve the issue please ensure the "Allow edits from maintainers" box is checked. Thanks for your patience and we are looking forward to getting this merged soon!

@YakDriver YakDriver self-assigned this Jul 19, 2022
@github-actions github-actions bot added this to the v4.23.0 milestone Jul 20, 2022
@github-actions
Copy link

This functionality has been released in v4.23.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. new-resource Introduces a new resource.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants