r/aws_lakeformation_permissions: Fix bug where SELECT permissions are not properly read in from AWS

[jackbatzner]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #17299

Output from acceptance testing:

=== RUN TestAccAWSLakeFormation_serial
=== RUN TestAccAWSLakeFormation_serial/Permissions
=== RUN TestAccAWSLakeFormation_serial/Permissions/selectPermissions
--- PASS: TestAccAWSLakeFormation_serial (38.65s)
--- PASS: TestAccAWSLakeFormation_serial/Permissions (38.65s)
--- PASS: TestAccAWSLakeFormation_serial/Permissions/selectPermissions (38.65s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 43.488s

$ make testacc TESTARGS='-run= TestAccAWSLakeFormation_serial'

...

[github-actions]

Welcome @Brunhil 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[YakDriver]

@Brunhil Thanks for this contribution! I'll look at this in the near future. Let me know when this is complete. To save time, if we need minor changes, I will make them directly so make sure to check the box to allow edits by maintainers.

[jackbatzner]

Thanks for checking in @YakDriver , this should be ready for your review. I believe I covered most of the steps as defined in the CONTRIBUTING readme. Let me know if I missed anything!

I added a test for this case that should fail on current the current main branch to confirm the referenced issue.

[YakDriver]

@Brunhil If you have further interest in this resource, we could use some help! Lake Formation, and permissions in particular, seem to have especially bad eventual consistency problems (for example, errors that will eventually go away like "AccessDeniedException: Resource does not exist" or "error reading Lake Formation permissions: no permissions found" type errors). If you're interested in tackling asynchronous challenges, this documentation will get you started: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/retries-and-waiters.md. Because of these AWS challenges, the AWS provider Lake Formation resources are only marginally stable.

[YakDriver]

Looks good! 🎉

Acceptance tests in GovCloud:

--- PASS: TestAccAWSLakeFormation_serial (323.30s)
    --- PASS: TestAccAWSLakeFormation_serial/Permissions (99.47s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/database (23.88s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/selectPermissions (23.27s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basic (26.50s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocation (25.82s)
    --- PASS: TestAccAWSLakeFormation_serial/TablePermissions (92.36s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableName (23.11s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWildcard (22.38s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWithColumns (23.29s)
        --- PASS: TestAccAWSLakeFormation_serial/TablePermissions/tableWithColumnsAndTable (23.59s)
    --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions (131.47s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/basicDataSource (22.70s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/dataLocationDataSource (27.81s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/databaseDataSource (30.64s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/tableDataSource (26.47s)
        --- PASS: TestAccAWSLakeFormation_serial/DataSourcePermissions/tableWithColumnsDataSource (23.85s)

Acceptance tests on Commercial:

    --- PASS: TestAccAWSLakeFormation_serial/Permissions (102.99s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/dataLocation (27.37s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/database (21.15s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/selectPermissions (25.43s)
        --- PASS: TestAccAWSLakeFormation_serial/Permissions/basic (29.04s)

[ghost]

This has been released in version 3.33.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[jackbatzner]

Because of these AWS challenges, the AWS provider Lake Formation resources are only marginally stable.

This sounds interesting and fun @YakDriver ! Looking at the existing resource it already has retry logic in place. Is there something different we wanted to do here?

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!