Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_dynamodb_table: update gsi provisioned throughput settings #18215

Conversation

Madh93
Copy link
Contributor

@Madh93 Madh93 commented Mar 18, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Fixes #9671

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDynamoDbTable_gsi'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSDynamoDbTable_gsi -timeout 180m
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan (44.95s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (61.57s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (190.39s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (522.81s)

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/dynamodb Issues and PRs that pertain to the dynamodb service. labels Mar 18, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 18, 2021
@Madh93 Madh93 force-pushed the b-aws_dynamodb_table-gsi-provisioned-throughput-update branch from dccbab9 to 09ccb59 Compare March 18, 2021 23:09
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @Madh93 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

Verified

This commit was signed with the committer’s verified signature.
Madh93 Miguel Hernández
…ghput settings
@Madh93 Madh93 force-pushed the b-aws_dynamodb_table-gsi-provisioned-throughput-update branch from 09ccb59 to 89a03e4 Compare March 18, 2021 23:18
@Madh93 Madh93 marked this pull request as ready for review March 18, 2021 23:18
@Madh93 Madh93 requested a review from a team as a code owner March 18, 2021 23:18
@YakDriver YakDriver self-assigned this Apr 12, 2021
@YakDriver YakDriver removed the needs-triage Waiting for first response or review from a maintainer. label Apr 12, 2021
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Madh93 Great work! 🎉

Results of acceptance tests on commercial:

--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan (40.62s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (50.49s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (395.45s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (728.08s)

Results of acceptance tests on GovCloud:

--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes_emptyPlan (47.25s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateCapacity (59.13s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateNonKeyAttributes (260.31s)
--- PASS: TestAccAWSDynamoDbTable_gsiUpdateOtherAttributes (558.05s)

@YakDriver YakDriver added this to the v3.37.0 milestone Apr 12, 2021
@YakDriver YakDriver merged commit ed8ee5e into hashicorp:main Apr 12, 2021
@ghost
Copy link

ghost commented Apr 16, 2021

This has been released in version 3.37.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 13, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/dynamodb Issues and PRs that pertain to the dynamodb service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_dynamodb_table not updating when values changed
2 participants