Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation on r/elasticache_replication_group availability_zones is incomplete. #18238

Closed
grimm26 opened this issue Mar 19, 2021 · 3 comments
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service.

Comments

@grimm26
Copy link
Contributor

grimm26 commented Mar 19, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

documentation on r/elasticache_replication_group availability_zones is incomplete based on looking at the AWS documentation at https://docs.aws.amazon.com/AmazonElastiCache/latest/APIReference/API_CreateReplicationGroup.html#API_CreateReplicationGroup_RequestParameters

New or Affected Resource(s)

  • aws_elasticache_replication_group

Potential Terraform Configuration

N/A

References

@grimm26 grimm26 added the enhancement Requests to existing resources that expand the functionality or scope. label Mar 19, 2021
@ghost ghost added the service/elasticache Issues and PRs that pertain to the elasticache service. label Mar 19, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 19, 2021
@bill-rich bill-rich added documentation Introduces or discusses updates to documentation. and removed enhancement Requests to existing resources that expand the functionality or scope. needs-triage Waiting for first response or review from a maintainer. labels Mar 19, 2021
@grimm26
Copy link
Contributor Author

grimm26 commented Mar 19, 2021

#18239 submitted

@gdavison
Copy link
Contributor

Hi @grimm26, thanks for submitting this issue and PR #18239. You're correct that the Terraform documentation doesn't match the AWS API documentation. Unfortunately, as noted in #5104, the resource does not correctly implement the PreferredCacheClusterAZs parameter in the AWS API, and the Terraform documentation reflects how the resource behaves.

Fully fixing this problem will involve potentially breaking changes, which means it will have to be done as part of v4.0 of the provider, though we may be able to address parts of the solution before then. We intend to release v4.0 in the summer of 2021.

Since the documentation will be updated along with the code fix, I'm going to close the issue and PR. Thanks again!

@ghost
Copy link

ghost commented Apr 26, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

No branches or pull requests

3 participants