-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rd/iam_policy - tagging support #18276
Conversation
Verified acceptance tests: $ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSIAMPolicy_\|TestAccAWSDataSourceIAMPolicy_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSIAMPolicy_\|TestAccAWSDataSourceIAMPolicy_ -timeout 180m
=== RUN TestAccAWSDataSourceIAMPolicy_basic
=== PAUSE TestAccAWSDataSourceIAMPolicy_basic
=== RUN TestAccAWSIAMPolicy_basic
=== PAUSE TestAccAWSIAMPolicy_basic
=== RUN TestAccAWSIAMPolicy_description
=== PAUSE TestAccAWSIAMPolicy_description
=== RUN TestAccAWSIAMPolicy_tags
=== PAUSE TestAccAWSIAMPolicy_tags
=== RUN TestAccAWSIAMPolicy_disappears
=== PAUSE TestAccAWSIAMPolicy_disappears
=== RUN TestAccAWSIAMPolicy_namePrefix
=== PAUSE TestAccAWSIAMPolicy_namePrefix
=== RUN TestAccAWSIAMPolicy_path
=== PAUSE TestAccAWSIAMPolicy_path
=== RUN TestAccAWSIAMPolicy_policy
=== PAUSE TestAccAWSIAMPolicy_policy
=== CONT TestAccAWSDataSourceIAMPolicy_basic
=== CONT TestAccAWSIAMPolicy_disappears
=== CONT TestAccAWSIAMPolicy_namePrefix
=== CONT TestAccAWSIAMPolicy_policy
=== CONT TestAccAWSIAMPolicy_path
=== CONT TestAccAWSIAMPolicy_tags
=== CONT TestAccAWSIAMPolicy_description
=== CONT TestAccAWSIAMPolicy_basic
--- PASS: TestAccAWSIAMPolicy_disappears (23.59s)
--- PASS: TestAccAWSDataSourceIAMPolicy_basic (26.33s)
--- PASS: TestAccAWSIAMPolicy_basic (29.82s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (29.98s)
--- PASS: TestAccAWSIAMPolicy_description (29.98s)
--- PASS: TestAccAWSIAMPolicy_path (30.00s)
--- PASS: TestAccAWSIAMPolicy_policy (38.79s)
--- PASS: TestAccAWSIAMPolicy_tags (46.39s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 46.523s |
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you, @DrFaust92 🚀
Output from acceptance testing in AWS Commercial:
--- PASS: TestAccAWSDataSourceIAMPolicy_basic (20.45s)
--- PASS: TestAccAWSIAMPolicy_basic (22.11s)
--- PASS: TestAccAWSIAMPolicy_description (21.92s)
--- PASS: TestAccAWSIAMPolicy_disappears (18.51s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (22.36s)
--- PASS: TestAccAWSIAMPolicy_path (22.27s)
--- PASS: TestAccAWSIAMPolicy_policy (29.66s)
--- PASS: TestAccAWSIAMPolicy_tags (36.52s)
Output from acceptance testing in AWS GovCloud (US):
--- PASS: TestAccAWSDataSourceIAMPolicy_basic (25.35s)
--- PASS: TestAccAWSIAMPolicy_basic (27.37s)
--- PASS: TestAccAWSIAMPolicy_description (27.37s)
--- PASS: TestAccAWSIAMPolicy_disappears (21.46s)
--- PASS: TestAccAWSIAMPolicy_namePrefix (27.86s)
--- PASS: TestAccAWSIAMPolicy_path (27.19s)
--- PASS: TestAccAWSIAMPolicy_policy (41.21s)
--- PASS: TestAccAWSIAMPolicy_tags (53.53s)
This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
Community Note
Relates #17594
Output from acceptance testing: