Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_backup - Add support for RDS continuous backup #18315

Merged
merged 2 commits into from
Apr 1, 2021
Merged

r/aws_backup - Add support for RDS continuous backup #18315

merged 2 commits into from
Apr 1, 2021

Conversation

kppullin
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18055

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAwsBackupPlan_EnableContinuousBackup'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_EnableContinuousBackup -timeout 180m
=== RUN   TestAccAwsBackupPlan_EnableContinuousBackup
=== PAUSE TestAccAwsBackupPlan_EnableContinuousBackup
=== CONT  TestAccAwsBackupPlan_EnableContinuousBackup
--- PASS: TestAccAwsBackupPlan_EnableContinuousBackup (17.79s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       17.837s

@kppullin kppullin requested a review from a team as a code owner March 20, 2021 17:44
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/backup Issues and PRs that pertain to the backup service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 20, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 20, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Mar 20, 2021
@ewbankkit ewbankkit self-assigned this Mar 20, 2021
ewbankkit
ewbankkit approved these changes Mar 20, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAwsBackupPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_ -timeout 180m
=== RUN   TestAccAwsBackupPlan_basic
=== PAUSE TestAccAwsBackupPlan_basic
=== RUN   TestAccAwsBackupPlan_withTags
=== PAUSE TestAccAwsBackupPlan_withTags
=== RUN   TestAccAwsBackupPlan_withRules
=== PAUSE TestAccAwsBackupPlan_withRules
=== RUN   TestAccAwsBackupPlan_withLifecycle
=== PAUSE TestAccAwsBackupPlan_withLifecycle
=== RUN   TestAccAwsBackupPlan_withRecoveryPointTags
=== PAUSE TestAccAwsBackupPlan_withRecoveryPointTags
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== RUN   TestAccAwsBackupPlan_AdvancedBackupSetting
=== PAUSE TestAccAwsBackupPlan_AdvancedBackupSetting
=== RUN   TestAccAwsBackupPlan_EnableContinuousBackup
=== PAUSE TestAccAwsBackupPlan_EnableContinuousBackup
=== RUN   TestAccAwsBackupPlan_disappears
=== PAUSE TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_basic
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== CONT  TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_EnableContinuousBackup
=== CONT  TestAccAwsBackupPlan_AdvancedBackupSetting
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== CONT  TestAccAwsBackupPlan_withRecoveryPointTags
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== CONT  TestAccAwsBackupPlan_withRules
=== CONT  TestAccAwsBackupPlan_withLifecycle
=== CONT  TestAccAwsBackupPlan_withTags
--- PASS: TestAccAwsBackupPlan_disappears (49.69s)
--- PASS: TestAccAwsBackupPlan_EnableContinuousBackup (52.11s)
--- PASS: TestAccAwsBackupPlan_basic (55.14s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_Multiple (57.03s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (65.04s)
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (83.63s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle (100.48s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (102.56s)
--- PASS: TestAccAwsBackupPlan_withRules (103.46s)
--- PASS: TestAccAwsBackupPlan_withTags (103.69s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_SameRegion (104.61s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (115.12s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	115.320s

@breathingdust
Copy link
Member

LGTM 🚀 Thanks @kppullin!

Verified Acceptance Tests in Commercial (us-west-2)

make testacc TESTARGS='-run=TestAccAwsBackupPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_ -timeout 180m
=== RUN   TestAccAwsBackupPlan_basic
=== PAUSE TestAccAwsBackupPlan_basic
=== RUN   TestAccAwsBackupPlan_withTags
=== PAUSE TestAccAwsBackupPlan_withTags
=== RUN   TestAccAwsBackupPlan_withRules
=== PAUSE TestAccAwsBackupPlan_withRules
=== RUN   TestAccAwsBackupPlan_withLifecycle
=== PAUSE TestAccAwsBackupPlan_withLifecycle
=== RUN   TestAccAwsBackupPlan_withRecoveryPointTags
=== PAUSE TestAccAwsBackupPlan_withRecoveryPointTags
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== RUN   TestAccAwsBackupPlan_AdvancedBackupSetting
=== PAUSE TestAccAwsBackupPlan_AdvancedBackupSetting
=== RUN   TestAccAwsBackupPlan_EnableContinuousBackup
=== PAUSE TestAccAwsBackupPlan_EnableContinuousBackup
=== RUN   TestAccAwsBackupPlan_disappears
=== PAUSE TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_basic
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== CONT  TestAccAwsBackupPlan_withTags
=== CONT  TestAccAwsBackupPlan_EnableContinuousBackup
=== CONT  TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== CONT  TestAccAwsBackupPlan_withRules
=== CONT  TestAccAwsBackupPlan_withLifecycle
=== CONT  TestAccAwsBackupPlan_AdvancedBackupSetting
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== CONT  TestAccAwsBackupPlan_withRecoveryPointTags
--- PASS: TestAccAwsBackupPlan_disappears (18.92s)
--- PASS: TestAccAwsBackupPlan_basic (21.82s)
--- PASS: TestAccAwsBackupPlan_EnableContinuousBackup (21.93s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_Multiple (22.21s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (28.31s)
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (32.61s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (42.95s)
--- PASS: TestAccAwsBackupPlan_withRules (43.50s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle (44.17s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_SameRegion (45.83s)
--- PASS: TestAccAwsBackupPlan_withTags (48.50s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (59.32s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.880s

Verified Acceptance Tests in GovCloud (us-gov-west-1)

make testacc TESTARGS='-run=TestAccAwsBackupPlan_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAwsBackupPlan_ -timeout 180m
=== RUN   TestAccAwsBackupPlan_basic
=== PAUSE TestAccAwsBackupPlan_basic
=== RUN   TestAccAwsBackupPlan_withTags
=== PAUSE TestAccAwsBackupPlan_withTags
=== RUN   TestAccAwsBackupPlan_withRules
=== PAUSE TestAccAwsBackupPlan_withRules
=== RUN   TestAccAwsBackupPlan_withLifecycle
=== PAUSE TestAccAwsBackupPlan_withLifecycle
=== RUN   TestAccAwsBackupPlan_withRecoveryPointTags
=== PAUSE TestAccAwsBackupPlan_withRecoveryPointTags
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== RUN   TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== PAUSE TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== RUN   TestAccAwsBackupPlan_AdvancedBackupSetting
=== PAUSE TestAccAwsBackupPlan_AdvancedBackupSetting
=== RUN   TestAccAwsBackupPlan_EnableContinuousBackup
=== PAUSE TestAccAwsBackupPlan_EnableContinuousBackup
=== RUN   TestAccAwsBackupPlan_disappears
=== PAUSE TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_basic
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_Multiple
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_SameRegion
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion
=== CONT  TestAccAwsBackupPlan_withLifecycle
=== CONT  TestAccAwsBackupPlan_withRecoveryPointTags
=== CONT  TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle
=== CONT  TestAccAwsBackupPlan_withRules
=== CONT  TestAccAwsBackupPlan_disappears
=== CONT  TestAccAwsBackupPlan_EnableContinuousBackup
=== CONT  TestAccAwsBackupPlan_AdvancedBackupSetting
=== CONT  TestAccAwsBackupPlan_withTags
--- PASS: TestAccAwsBackupPlan_disappears (18.78s)
--- PASS: TestAccAwsBackupPlan_basic (19.47s)
--- PASS: TestAccAwsBackupPlan_EnableContinuousBackup (21.51s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_Multiple (21.91s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_CrossRegion (26.51s)
--- PASS: TestAccAwsBackupPlan_AdvancedBackupSetting (27.93s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_NoLifecycle (38.02s)
--- PASS: TestAccAwsBackupPlan_withRecoveryPointTags (38.27s)
--- PASS: TestAccAwsBackupPlan_withRules (39.26s)
--- PASS: TestAccAwsBackupPlan_withTags (40.31s)
--- PASS: TestAccAwsBackupPlan_Rule_CopyAction_SameRegion (40.88s)
--- PASS: TestAccAwsBackupPlan_withLifecycle (47.82s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.818s

@breathingdust breathingdust merged commit 6f3b57f into hashicorp:main Apr 1, 2021
@github-actions github-actions bot added this to the v3.35.0 milestone Apr 1, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented May 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. service/backup Issues and PRs that pertain to the backup service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.

Point-in-time recovery and continuous backup for Amazon RDS with AWS Backup
4 participants
@kppullin @breathingdust @ewbankkit @kppullin-nt