Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws_efs_file_system: Support single Availability Zone storage classes #18319

Merged
merged 4 commits into from
Mar 31, 2021
Merged

aws_efs_file_system: Support single Availability Zone storage classes #18319

merged 4 commits into from
Mar 31, 2021

Conversation

shuheiktgw
Copy link
Collaborator

@shuheiktgw shuheiktgw commented Mar 21, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18016

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSEFSFileSystem_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEFSFileSystem_ -timeout 180m
=== RUN   TestAccAWSEFSFileSystem_basic
=== PAUSE TestAccAWSEFSFileSystem_basic
=== RUN   TestAccAWSEFSFileSystem_availabilityZoneName
=== PAUSE TestAccAWSEFSFileSystem_availabilityZoneName
=== RUN   TestAccAWSEFSFileSystem_tags
=== PAUSE TestAccAWSEFSFileSystem_tags
=== RUN   TestAccAWSEFSFileSystem_pagedTags
=== PAUSE TestAccAWSEFSFileSystem_pagedTags
=== RUN   TestAccAWSEFSFileSystem_kmsKey
=== PAUSE TestAccAWSEFSFileSystem_kmsKey
=== RUN   TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== PAUSE TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== RUN   TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== PAUSE TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== RUN   TestAccAWSEFSFileSystem_ThroughputMode
=== PAUSE TestAccAWSEFSFileSystem_ThroughputMode
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== RUN   TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== PAUSE TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== RUN   TestAccAWSEFSFileSystem_disappears
=== PAUSE TestAccAWSEFSFileSystem_disappears
=== CONT  TestAccAWSEFSFileSystem_basic
=== CONT  TestAccAWSEFSFileSystem_ThroughputMode
=== CONT  TestAccAWSEFSFileSystem_disappears
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy_removal
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy_update
=== CONT  TestAccAWSEFSFileSystem_lifecyclePolicy
=== CONT  TestAccAWSEFSFileSystem_kmsKey
=== CONT  TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps
=== CONT  TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption
=== CONT  TestAccAWSEFSFileSystem_tags
=== CONT  TestAccAWSEFSFileSystem_availabilityZoneName
=== CONT  TestAccAWSEFSFileSystem_pagedTags
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (43.36s)
--- PASS: TestAccAWSEFSFileSystem_disappears (73.41s)
--- PASS: TestAccAWSEFSFileSystem_availabilityZoneName (109.55s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (123.93s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (132.33s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (136.02s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (147.03s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (151.07s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (156.76s)
--- PASS: TestAccAWSEFSFileSystem_basic (157.14s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (172.96s)
--- PASS: TestAccAWSEFSFileSystem_tags (196.84s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	198.815s

$ make testacc TESTARGS='-run=TestAccDataSourceAwsEfsFileSystem_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsEfsFileSystem_ -timeout 180m
=== RUN   TestAccDataSourceAwsEfsFileSystem_id
=== PAUSE TestAccDataSourceAwsEfsFileSystem_id
=== RUN   TestAccDataSourceAwsEfsFileSystem_name
=== PAUSE TestAccDataSourceAwsEfsFileSystem_name
=== RUN   TestAccDataSourceAwsEfsFileSystem_availabilityZone
=== PAUSE TestAccDataSourceAwsEfsFileSystem_availabilityZone
=== RUN   TestAccDataSourceAwsEfsFileSystem_NonExistent
=== PAUSE TestAccDataSourceAwsEfsFileSystem_NonExistent
=== CONT  TestAccDataSourceAwsEfsFileSystem_id
=== CONT  TestAccDataSourceAwsEfsFileSystem_name
=== CONT  TestAccDataSourceAwsEfsFileSystem_NonExistent
=== CONT  TestAccDataSourceAwsEfsFileSystem_availabilityZone
--- PASS: TestAccDataSourceAwsEfsFileSystem_NonExistent (11.69s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_id (45.53s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (45.54s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_availabilityZone (45.91s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	47.897s

@shuheiktgw shuheiktgw requested a review from a team as a code owner March 21, 2021 06:27
@ghost ghost added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/efs Issues and PRs that pertain to the efs service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Mar 21, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Mar 21, 2021
@shuheiktgw shuheiktgw changed the title r/aws_efs_file_system: Support single Availability Zone storage classes aws_efs_file_system: Support single Availability Zone storage classes Mar 21, 2021
@shuheiktgw shuheiktgw mentioned this pull request Mar 21, 2021
Closed
@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Mar 21, 2021
@bflad bflad self-assigned this Mar 26, 2021
bflad
bflad reviewed Mar 26, 2021
View reviewed changes
aws/data_source_aws_efs_file_system.go
@@ -22,6 +22,14 @@ func dataSourceAwsEfsFileSystem() *schema.Resource {
Type: schema.TypeString,
Computed: true,
},
"availability_zone_id": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @shuheiktgw 👋 Can you please add changelog entries for these new schema attributes? Reference: https://github.com/hashicorp/terraform-provider-aws/blob/main/docs/contributing/pullrequest-submission-and-lifecycle.md#changelog-process

e.g. a new file called .changelog/18319.txt with contents:

```release-note:enhancement
data-source/aws_efs_file_system: Add `availability_zone_id` and `availability_zone_name` attributes
```

```release-note:enhancement
resource/aws_efs_file_system: Add `availability_zone_id` attribute and `availability_zone_name` argument
```

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry that I haven't noticed the new change log format! I'll fix it now!

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Mar 26, 2021
@shuheiktgw
Copy link
Collaborator Author

shuheiktgw commented Mar 30, 2021 •
edited
Loading

Thank you for your review, @bflad! I've added change logs and resolved the conflict. Would you review the PR again?

@ghost ghost removed waiting-response Maintainers are waiting on response from community or contributor. labels Mar 30, 2021
bflad
bflad approved these changes Mar 31, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you, @shuheiktgw 🚀

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSEFSFileSystem_availabilityZoneName (52.85s)
--- PASS: TestAccAWSEFSFileSystem_basic (100.05s)
--- PASS: TestAccAWSEFSFileSystem_disappears (89.46s)
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (11.16s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (78.45s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (135.47s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (151.08s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (86.82s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (50.41s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (100.30s)
--- PASS: TestAccAWSEFSFileSystem_tags (115.88s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (159.30s)

--- PASS: TestAccDataSourceAwsEfsFileSystem_availabilityZone (65.70s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_id (123.56s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (133.45s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_NonExistent (5.64s)

Output from acceptance testing in AWS GovCloud (US):

--- PASS: TestAccAWSEFSFileSystem_availabilityZoneName (152.34s)
--- PASS: TestAccAWSEFSFileSystem_basic (126.80s)
--- PASS: TestAccAWSEFSFileSystem_disappears (215.97s)
--- PASS: TestAccAWSEFSFileSystem_kmsConfigurationWithoutEncryption (14.42s)
--- PASS: TestAccAWSEFSFileSystem_kmsKey (83.93s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy (120.63s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_removal (146.67s)
--- PASS: TestAccAWSEFSFileSystem_lifecyclePolicy_update (116.64s)
--- PASS: TestAccAWSEFSFileSystem_pagedTags (144.91s)
--- PASS: TestAccAWSEFSFileSystem_ProvisionedThroughputInMibps (106.71s)
--- PASS: TestAccAWSEFSFileSystem_tags (149.15s)
--- PASS: TestAccAWSEFSFileSystem_ThroughputMode (97.13s)

--- PASS: TestAccDataSourceAwsEfsFileSystem_availabilityZone (147.25s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_id (70.23s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_name (110.46s)
--- PASS: TestAccDataSourceAwsEfsFileSystem_NonExistent (7.44s)

@bflad bflad merged commit cbc6dab into hashicorp:main Mar 31, 2021
@github-actions github-actions bot added this to the v3.35.0 milestone Mar 31, 2021
@ghost
Copy link

ghost commented Apr 1, 2021

This has been released in version 3.35.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Apr 30, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Apr 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/efs Issues and PRs that pertain to the efs service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.35.0
Development

Successfully merging this pull request may close these issues.

Amazon EFS now supports single Availability Zone storage classes
3 participants
@shuheiktgw @bflad @DrFaust92