Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_elasticache_replication_group: Migrate from availability_zones TypeSet attribute to preferred_cache_cluster_azs TypeList attribute #18438

Closed
gdavison opened this issue Mar 27, 2021 · 2 comments · Fixed by #22925
Assignees
Labels
service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Milestone

Comments

@gdavison
Copy link
Contributor

gdavison commented Mar 27, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

When creating a Redis cluster without sharding ("Cluster Mode Disabled" in AWS terminology), it is possible to specify a list of availability zones in which to place the cluster nodes. In the AWS API, the order of the list matters: the first AZ in the list is the primary AZ for the cluster, and the remainder of the nodes are assigned in order. The number of AZs in the list must match the number of nodes, and duplicates are allowed.

As currently implemented in the AWS Provider, the parameter availability_zones is of TypeSet, where order is not guaranteed and duplicates are not permitted. This means that the practitioner has no control over the location of the primary node and there can be at most one node in a given AZ.

Additionally, the current parameter name, availability_zones, does not match the AWS API parameter name PreferredCacheClusterAZs.

A new parameter preferred_cache_cluster_azs of TypeList should be added to aws_elasticache_replication_group. Changes to aws_elasticache_replication_group should not be marked ForceNew, as the primary AZ, the order of AZs, and the number of AZs can be changed in-place.

availability_zones will be removed as part of #18439.

Specifying AZs for sharded ("Cluster Mode Enabled" in AWS terminology) clusters is described in #5118.

References

@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/elasticache Issues and PRs that pertain to the elasticache service. technical-debt Addresses areas of the codebase that need refactoring or redesign.
Projects
None yet
2 participants