Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_elasticache_cluster: Add Outpost support #18460

Closed
gdavison opened this issue Mar 29, 2021 · 3 comments · Fixed by #27934
Closed

resource/aws_elasticache_cluster: Add Outpost support #18460

gdavison opened this issue Mar 29, 2021 · 3 comments · Fixed by #27934
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Milestone

Comments

@gdavison
Copy link
Contributor

gdavison commented Mar 29, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Add Outpost support to aws_elasticache_cluster.

Potential Terraform Configuration

New fields:

resource "aws_elasticache_cluster" "example" {
  ...
  outpost_mode = "single-outpost" # Valid values: "single-outpost" and "cross-outpost"

  preferred_outpost_arn = "<valid ARN>"
}

Note: only single-outpost is currently supported.

Note: CreateCacheClusterInput has both a single PreferredOutpostArn and list PreferredOutpostArns, but CacheCluster only has the field PreferredOutpostArn and does not have the field OutpostMode.

Affected Resource

  • resource/aws_elasticache_cluster
  • data source/aws_elasticache_cluster

Potential Terraform Configuration

# Copy-paste your Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

References

@gdavison gdavison added enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. labels Mar 29, 2021
@weizhangfd
Copy link
Contributor

weizhangfd commented Nov 20, 2022

👋 @gdavison I have made a PR for this enhancement, but I don't seem to have push right to the repo. Would you mind giving me the write access please? 🙏

Edit: I have just learned from https://github.com/hashicorp/packer/blob/main/.github/CONTRIBUTING.md that I should do a fork and open PR from there. Apologies for the unnecessary push right request.

Edit: I have attempted to implement this enhancement at #27934. Please could you kindly review at your earliest convenience? I apologies for not being able to run the acceptance tests on outpost myself. Thank you for your help in advance.

@github-actions
Copy link

This functionality has been released in v4.41.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants