Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_dx_gateway_association_proposal still recreated #18608

Closed
toelke opened this issue Apr 7, 2021 · 10 comments · Fixed by #19741
Closed

aws_dx_gateway_association_proposal still recreated #18608

toelke opened this issue Apr 7, 2021 · 10 comments · Fixed by #19741
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service.
Milestone

Comments

@toelke
Copy link

toelke commented Apr 7, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Issue

This is to note that issue #9209 is closed but not solved; creating a aws_dx_gateway_association_proposal and accepting it will still, after a few days, try to recreate the aws_dx_gateway_association_proposal. See #9209 for all information.

@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 7, 2021
@bill-rich bill-rich self-assigned this Apr 7, 2021
@bill-rich bill-rich added bug Addresses a defect in current functionality. and removed needs-triage Waiting for first response or review from a maintainer. labels Apr 7, 2021
@bill-rich bill-rich removed their assignment Apr 8, 2021
@bill-rich
Copy link
Contributor

Thanks for reporting this @toelke! @ewbankkit, do you have any feedback on what could be happening here?

@ewbankkit
Copy link
Contributor

@toelke Can you attach the output of a terraform plan or terraform apply that shows the proposal being recreated?
This will help greatly with our troubleshooting.
Thanks.

@ewbankkit ewbankkit added the waiting-response Maintainers are waiting on response from community or contributor. label Apr 9, 2021
@toelke
Copy link
Author

toelke commented Apr 9, 2021

image

When applying this it will work but break the association for a few minutes. In three days or so it will again want to re-create the proposal.

The original poster in #9209 has this quote from AWS: "Once the proposal is accepted, it will disappear after some time. There is no defined time duration as to how long the proposal is available after acceptance". See especially the comment #9209 (comment)

@ghost ghost removed the waiting-response Maintainers are waiting on response from community or contributor. label Apr 9, 2021
@ewbankkit
Copy link
Contributor

@toelke You could try adding

  lifecycle {
    ignore_changes = [
      proposal_id,
    ]
  }

to the aws_dx_gateway_association resource.

@toelke
Copy link
Author

toelke commented Apr 12, 2021

Yes, but the proposal will still be re-created, breaking the connection.

@ewbankkit
Copy link
Contributor

Aah, so it's the creation of the new proposal that causes the association to break (and thus the network outage) rather than the change of the proposal ID in the aws_dx_gateway_association (because from the code, updating proposal_id doesn't actually do anything)?

@toelke
Copy link
Author

toelke commented Apr 12, 2021

I can try to check that.

In any case terraform would recreate the proposal every few days which will show up as configuration drift. Even without outage that's not ideal.

@toelke
Copy link
Author

toelke commented Apr 13, 2021

I tested re-creating the proposal and not changing the aws_dx_gateway_association (by using ignore_changes) and the connection stays up even if I accept or reject the new proposal in the web-console.

So using ignore_changes is indeed a solution for not breaking the connection.

I would still prefer not to have config drift, though.

@ewbankkit ewbankkit added service/directconnect Issues and PRs that pertain to the directconnect service. enhancement Requests to existing resources that expand the functionality or scope. and removed bug Addresses a defect in current functionality. labels Apr 13, 2021
@github-actions github-actions bot added this to the v3.50.0 milestone Jul 12, 2021
@github-actions
Copy link

This functionality has been released in v3.50.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/directconnect Issues and PRs that pertain to the directconnect service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants