Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ElastiCache Tag Modification #18668

Closed
bondsb opened this issue Apr 8, 2021 · 5 comments
Closed

ElastiCache Tag Modification #18668

bondsb opened this issue Apr 8, 2021 · 5 comments
Assignees
Labels
bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.

Comments

@bondsb
Copy link

bondsb commented Apr 8, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Provide tag modification support to AWS ElastiCache resources.

Support for tag modification has recently been updated in Go SDK version 1.38.15.

New or Affected Resource(s)

  • aws_elasticache_*

Potential Terraform Configuration

resource "aws_elasticache_replication_group" "my_replication_group" {
  ...

  tags = {
    MyTagKey = "MyTagValue"
  }
}

References

@bondsb bondsb added the enhancement Requests to existing resources that expand the functionality or scope. label Apr 8, 2021
@ghost ghost added the service/elasticache Issues and PRs that pertain to the elasticache service. label Apr 8, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 8, 2021
@bondsb bondsb changed the title Elasticache Tag Modification ElastiCache Tag Modification Apr 8, 2021
@ewbankkit
Copy link
Contributor

Requires:

@gdavison gdavison self-assigned this Jun 4, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 4, 2021
@justinretzolk
Copy link
Member

Hey @bondsb 👋 Thank you for taking the time to file this issue! It looks like a fix for this was released with v3.62.0 of the provider, specifically with this pull request.

Can you verify that with the newer version of the provider, you're no longer experiencing this issue?

@justinretzolk justinretzolk added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 14, 2021
@bondsb
Copy link
Author

bondsb commented Nov 16, 2021

@justinretzolk Apologies for the delay.

That fix does not appear to work. v3.65.0 does not detect external tag changes and the result of a difference between actual tags and expected tags results in a plan with no changes.

@github-actions github-actions bot removed the waiting-response Maintainers are waiting on response from community or contributor. label Nov 16, 2021
@justinretzolk justinretzolk added the bug Addresses a defect in current functionality. label Nov 16, 2021
Copy link

Marking this issue as stale due to inactivity. This helps our maintainers find and focus on the active issues. If this issue receives no comments in the next 30 days it will automatically be closed. Maintainers can also remove the stale label.

If this issue was automatically closed and you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thank you!

@github-actions github-actions bot added the stale Old or inactive issues managed by automation, if no further action taken these will get closed. label Dec 10, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 9, 2024
Copy link

github-actions bot commented Feb 9, 2024

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. enhancement Requests to existing resources that expand the functionality or scope. service/elasticache Issues and PRs that pertain to the elasticache service. stale Old or inactive issues managed by automation, if no further action taken these will get closed.
Projects
None yet
Development

No branches or pull requests

5 participants