Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/rds_proxy_endpoint - new resource #18881

Merged
merged 16 commits into from
Apr 29, 2021
Merged

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Apr 15, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18128
Closes #18673

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSDBProxyEndpoint_'
--- PASS: TestAccAWSDBProxyEndpoint_basic (1100.66s)
--- PASS: TestAccAWSDBProxyEndpoint_disappears_proxy (1120.63s)
--- PASS: TestAccAWSDBProxyEndpoint_disappears (1129.69s)
--- PASS: TestAccAWSDBProxyEndpoint_tags (1058.69s)
--- PASS: TestAccAWSDBProxyEndpoint_targetRole (1296.83s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner April 15, 2021 10:25
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 15, 2021
@DrFaust92 DrFaust92 added the new-resource Introduces a new resource. label Apr 15, 2021
@bflad bflad self-assigned this Apr 29, 2021
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, @DrFaust92, just adding default tags support and will reverify 🚀

aws/resource_aws_db_proxy_endpoint.go Show resolved Hide resolved
aws/resource_aws_db_proxy_endpoint.go Outdated Show resolved Hide resolved
aws/resource_aws_db_proxy_endpoint.go Show resolved Hide resolved
aws/resource_aws_db_proxy_endpoint.go Outdated Show resolved Hide resolved
aws/resource_aws_db_proxy_endpoint.go Outdated Show resolved Hide resolved
aws/resource_aws_db_proxy_endpoint.go Outdated Show resolved Hide resolved
aws/resource_aws_db_proxy_endpoint.go Outdated Show resolved Hide resolved
aws/resource_aws_db_proxy_endpoint.go Outdated Show resolved Hide resolved
aws/resource_aws_db_proxy_endpoint.go Outdated Show resolved Hide resolved
@bflad
Copy link
Contributor

bflad commented Apr 29, 2021

Output from acceptance testing in AWS Commercial:

--- PASS: TestAccAWSDBProxyEndpoint_targetRole (1287.78s)
--- PASS: TestAccAWSDBProxyEndpoint_disappears (1299.92s)
--- PASS: TestAccAWSDBProxyEndpoint_disappears_proxy (1306.28s)
--- PASS: TestAccAWSDBProxyEndpoint_tags (1328.11s)
--- PASS: TestAccAWSDBProxyEndpoint_basic (1370.47s)
--- PASS: TestAccAWSDBProxyEndpoint_vpcSecurityGroupIds (1523.22s)

Output from acceptance testing in AWS GovCloud (US):

--- SKIP: TestAccAWSDBProxyEndpoint_basic (1.88s)
--- SKIP: TestAccAWSDBProxyEndpoint_tags (1.88s)
--- SKIP: TestAccAWSDBProxyEndpoint_vpcSecurityGroupIds (1.88s)
--- SKIP: TestAccAWSDBProxyEndpoint_disappears (1.88s)
--- SKIP: TestAccAWSDBProxyEndpoint_targetRole (1.89s)
--- SKIP: TestAccAWSDBProxyEndpoint_disappears_proxy (1.93s)

@bflad bflad merged commit 0783da7 into hashicorp:main Apr 29, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
@DrFaust92 DrFaust92 deleted the r/rds_proxy_endpoint branch February 23, 2022 19:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/rds Issues and PRs that pertain to the rds service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
2 participants