Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider: Tests failing with After applying this test step, the plan was not empty for tags_all #19005

Closed
anGie44 opened this issue Apr 20, 2021 · 2 comments · Fixed by #19006
Labels
bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Milestone

Comments

@anGie44
Copy link
Contributor

anGie44 commented Apr 20, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Merge of #18958 accounts for tags values not known until apply, however, in the event no tags are set on the resource, we end with perpetual diff, such that terraform suggests the value for tags_all must be updated

Affected Resource(s)

  • aws_* (those that now support default tags)

Test Output

------- Stdout: -------
=== RUN   TestAccAWSALBTargetGroup_generatedName
=== PAUSE TestAccAWSALBTargetGroup_generatedName
=== CONT  TestAccAWSALBTargetGroup_generatedName
    resource_aws_alb_target_group_test.go:120: Step 1/1 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_alb_target_group.test will be updated in-place
          ~ resource "aws_alb_target_group" "test" {
                id                                 = "arn:aws:elasticloadbalancing:us-west-2:*******:targetgroup/tf-20210420043346757400000001/98413905f615c1e8"
                name                               = "tf-20210420043346757400000001"
              ~ tags_all                           = {} -> (known after apply)
                # (12 unchanged attributes hidden)
        
        
                # (2 unchanged blocks hidden)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.
--- FAIL: TestAccAWSALBTargetGroup_generatedName (33.92s)

References

@ghost ghost added the service/elbv2 Issues and PRs that pertain to the elbv2 service. label Apr 20, 2021
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Apr 20, 2021
@github-actions github-actions bot removed the bug Addresses a defect in current functionality. label Apr 20, 2021
@anGie44 anGie44 changed the title provider: Tests failing with After applying this test step, the plan was not empty after #18958 provider: Tests failing with After applying this test step, the plan was not empty for tags_all Apr 20, 2021
@anGie44 anGie44 added bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 20, 2021
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 20, 2021
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. provider Pertains to the provider itself, rather than any interaction with AWS. service/elbv2 Issues and PRs that pertain to the elbv2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
1 participant