Fix aws_vpc_endpoint auto_accept failing on pending status

[shedimon]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #14604

Release note for CHANGELOG:

resource/aws_vpc_endpoint: Fix auto_accept failing while waiting for the VPC Endpoint Connection acceptance

aws_vpc_endpoint waits for the accept of the connection to the VPC Endpoint Service. Before connection is accepted status is pendingAcceptance. However, after it is accepted it changes to the pending which is not accounted for in the stateConf. This PR fixes this issue by adding the pending state as expected Pending value.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[bflad]

Reference: https://docs.aws.amazon.com/vpc/latest/privatelink/vpce-interface.html#vpce-interface-lifecycle

Hi @shedimon 👋 Thank you very much for this fix. Looks good to me!

Output from acceptance testing:

--- FAIL: TestAccAWSVpcEndpoint_VpcEndpointType_GatewayLoadBalancer (110.98s) # https://github.com/hashicorp/terraform-provider-aws/issues/16657
--- PASS: TestAccAWSVpcEndpoint_disappears (33.95s)
--- PASS: TestAccAWSVpcEndpoint_gatewayBasic (36.88s)
--- PASS: TestAccAWSVpcEndpoint_gatewayPolicy (63.32s)
--- PASS: TestAccAWSVpcEndpoint_gatewayWithRouteTableAndPolicy (76.98s)
--- PASS: TestAccAWSVpcEndpoint_interfaceBasic (53.83s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnCreate (266.51s)
--- PASS: TestAccAWSVpcEndpoint_interfaceNonAWSServiceAcceptOnUpdate (278.35s)
--- PASS: TestAccAWSVpcEndpoint_interfaceWithSubnetAndSecurityGroup (340.47s)
--- PASS: TestAccAWSVpcEndpoint_tags (87.33s)

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.