Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Eventbridge Schema Registry, Discoverer and Schema resources #19100

Merged
merged 10 commits into from
May 26, 2021
Merged

Add support for Eventbridge Schema Registry, Discoverer and Schema resources #19100

merged 10 commits into from
May 26, 2021

Conversation

jordanfinners
Copy link
Contributor

@jordanfinners jordanfinners commented Apr 24, 2021 •
edited by ewbankkit
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #11088

Output from acceptance testing:

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemas -timeout 180m
=== RUN   TestAccAWSSchemasDiscoverer_basic
=== PAUSE TestAccAWSSchemasDiscoverer_basic
=== RUN   TestAccAWSSchemasDiscoverer_tags
=== PAUSE TestAccAWSSchemasDiscoverer_tags
=== RUN   TestAccAWSSchemasDiscoverer_disappears
=== PAUSE TestAccAWSSchemasDiscoverer_disappears
=== RUN   TestAccAWSSchemasRegistry_basic
=== PAUSE TestAccAWSSchemasRegistry_basic
=== RUN   TestAccAWSSchemasRegistry_tags
=== PAUSE TestAccAWSSchemasRegistry_tags
=== RUN   TestAccAWSSchemasRegistry_disappears
=== PAUSE TestAccAWSSchemasRegistry_disappears
=== RUN   TestAccAWSSchemasSchema_basic
=== PAUSE TestAccAWSSchemasSchema_basic
=== RUN   TestAccAWSSchemasSchema_tags
=== PAUSE TestAccAWSSchemasSchema_tags
=== RUN   TestAccAWSSchemasSchema_disappears
=== PAUSE TestAccAWSSchemasSchema_disappears
=== CONT  TestAccAWSSchemasDiscoverer_basic
=== CONT  TestAccAWSSchemasRegistry_disappears
=== CONT  TestAccAWSSchemasSchema_disappears
=== CONT  TestAccAWSSchemasSchema_tags
=== CONT  TestAccAWSSchemasSchema_basic
=== CONT  TestAccAWSSchemasRegistry_tags
=== CONT  TestAccAWSSchemasDiscoverer_disappears
=== CONT  TestAccAWSSchemasDiscoverer_tags
=== CONT  TestAccAWSSchemasRegistry_basic
--- PASS: TestAccAWSSchemasRegistry_disappears (80.59s)
--- PASS: TestAccAWSSchemasDiscoverer_disappears (87.24s)
--- PASS: TestAccAWSSchemasSchema_disappears (87.34s)
--- PASS: TestAccAWSSchemasRegistry_basic (124.27s)
--- PASS: TestAccAWSSchemasSchema_basic (132.50s)
--- PASS: TestAccAWSSchemasDiscoverer_basic (132.63s)
--- PASS: TestAccAWSSchemasRegistry_tags (139.56s)
--- PASS: TestAccAWSSchemasSchema_tags (149.44s)
--- PASS: TestAccAWSSchemasDiscoverer_tags (151.75s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       151.830s

@jordanfinners jordanfinners requested a review from a team as a code owner April 24, 2021 20:43
@ghost ghost added size/XXL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 24, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label Apr 24, 2021
@jordanfinners jordanfinners changed the title WIP: Add support for Eventbridge Schema Registry, Discoverer and Schema re… Add support for Eventbridge Schema Registry, Discoverer and Schema re… Apr 24, 2021
@jordanfinners jordanfinners mentioned this pull request Apr 24, 2021
Closed
@jordanfinners
Copy link
Contributor Author

@YakDriver I've also opened this one with some more eventbridge related resources :)

@jordanfinners
Copy link
Contributor Author

jordanfinners commented Apr 30, 2021 •
edited
Loading

Hey @YakDriver, @ewbankkit @bflad would you mind reviewing this please 🙏 Would be great to get the builds approved to see if I need to make other changes 😃

@jordanfinners
Copy link
Contributor Author

Hey @sthulb , @heitorlessa mentioned you would be the person to speak to about this, would you be able to review the PR and let me know your thoughts please 🙏

@sthulb
Copy link
Contributor

sthulb commented May 21, 2021

@jordanfinners at a quick glance, this looks fine. I'll finish my initial review today.

@sthulb sthulb self-assigned this May 24, 2021
@sthulb sthulb removed the request for review from a team May 24, 2021 13:00
@jordanfinners
Copy link
Contributor Author

@ewbankkit would it be possible to have your review of this PR too for merging please 🙏

@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 26, 2021
@ewbankkit ewbankkit changed the title Add support for Eventbridge Schema Registry, Discoverer and Schema re… Add support for Eventbridge Schema Registry, Discoverer and Schema resources May 26, 2021
@ewbankkit ewbankkit assigned ewbankkit and unassigned sthulb May 26, 2021
ewbankkit
ewbankkit approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSchemasSchema_\|TestAccAWSSchemasRegistry_\|TestAccAWSSchemasDiscoverer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemasSchema_\|TestAccAWSSchemasRegistry_\|TestAccAWSSchemasDiscoverer_ -timeout 180m
=== RUN   TestAccAWSSchemasDiscoverer_basic
=== PAUSE TestAccAWSSchemasDiscoverer_basic
=== RUN   TestAccAWSSchemasDiscoverer_disappears
=== PAUSE TestAccAWSSchemasDiscoverer_disappears
=== RUN   TestAccAWSSchemasDiscoverer_Description
=== PAUSE TestAccAWSSchemasDiscoverer_Description
=== RUN   TestAccAWSSchemasDiscoverer_Tags
=== PAUSE TestAccAWSSchemasDiscoverer_Tags
=== RUN   TestAccAWSSchemasRegistry_basic
=== PAUSE TestAccAWSSchemasRegistry_basic
=== RUN   TestAccAWSSchemasRegistry_disappears
=== PAUSE TestAccAWSSchemasRegistry_disappears
=== RUN   TestAccAWSSchemasRegistry_Description
=== PAUSE TestAccAWSSchemasRegistry_Description
=== RUN   TestAccAWSSchemasRegistry_Tags
=== PAUSE TestAccAWSSchemasRegistry_Tags
=== RUN   TestAccAWSSchemasSchema_basic
=== PAUSE TestAccAWSSchemasSchema_basic
=== RUN   TestAccAWSSchemasSchema_disappears
=== PAUSE TestAccAWSSchemasSchema_disappears
=== RUN   TestAccAWSSchemasSchema_ContentDescription
=== PAUSE TestAccAWSSchemasSchema_ContentDescription
=== RUN   TestAccAWSSchemasSchema_Tags
=== PAUSE TestAccAWSSchemasSchema_Tags
=== CONT  TestAccAWSSchemasDiscoverer_basic
=== CONT  TestAccAWSSchemasRegistry_Tags
=== CONT  TestAccAWSSchemasSchema_Tags
=== CONT  TestAccAWSSchemasSchema_ContentDescription
=== CONT  TestAccAWSSchemasSchema_disappears
=== CONT  TestAccAWSSchemasRegistry_basic
=== CONT  TestAccAWSSchemasSchema_basic
=== CONT  TestAccAWSSchemasRegistry_disappears
=== CONT  TestAccAWSSchemasRegistry_Description
=== CONT  TestAccAWSSchemasDiscoverer_Description
=== CONT  TestAccAWSSchemasDiscoverer_Tags
=== CONT  TestAccAWSSchemasDiscoverer_disappears
--- PASS: TestAccAWSSchemasRegistry_disappears (14.95s)
--- PASS: TestAccAWSSchemasRegistry_basic (21.08s)
--- PASS: TestAccAWSSchemasDiscoverer_disappears (21.43s)
--- PASS: TestAccAWSSchemasSchema_disappears (21.47s)
--- PASS: TestAccAWSSchemasDiscoverer_basic (24.94s)
--- PASS: TestAccAWSSchemasSchema_basic (25.01s)
--- PASS: TestAccAWSSchemasRegistry_Description (43.05s)
--- PASS: TestAccAWSSchemasRegistry_Tags (43.05s)
--- PASS: TestAccAWSSchemasSchema_Tags (47.14s)
--- PASS: TestAccAWSSchemasDiscoverer_Description (49.91s)
--- PASS: TestAccAWSSchemasDiscoverer_Tags (50.05s)
--- PASS: TestAccAWSSchemasSchema_ContentDescription (50.14s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.189s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSchemasSchema_\|TestAccAWSSchemasRegistry_\|TestAccAWSSchemasDiscoverer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemasSchema_\|TestAccAWSSchemasRegistry_\|TestAccAWSSchemasDiscoverer_ -timeout 180m
=== RUN   TestAccAWSSchemasDiscoverer_basic
=== PAUSE TestAccAWSSchemasDiscoverer_basic
=== RUN   TestAccAWSSchemasDiscoverer_disappears
=== PAUSE TestAccAWSSchemasDiscoverer_disappears
=== RUN   TestAccAWSSchemasDiscoverer_Description
=== PAUSE TestAccAWSSchemasDiscoverer_Description
=== RUN   TestAccAWSSchemasDiscoverer_Tags
=== PAUSE TestAccAWSSchemasDiscoverer_Tags
=== RUN   TestAccAWSSchemasRegistry_basic
=== PAUSE TestAccAWSSchemasRegistry_basic
=== RUN   TestAccAWSSchemasRegistry_disappears
=== PAUSE TestAccAWSSchemasRegistry_disappears
=== RUN   TestAccAWSSchemasRegistry_Description
=== PAUSE TestAccAWSSchemasRegistry_Description
=== RUN   TestAccAWSSchemasRegistry_Tags
=== PAUSE TestAccAWSSchemasRegistry_Tags
=== RUN   TestAccAWSSchemasSchema_basic
=== PAUSE TestAccAWSSchemasSchema_basic
=== RUN   TestAccAWSSchemasSchema_disappears
=== PAUSE TestAccAWSSchemasSchema_disappears
=== RUN   TestAccAWSSchemasSchema_ContentDescription
=== PAUSE TestAccAWSSchemasSchema_ContentDescription
=== RUN   TestAccAWSSchemasSchema_Tags
=== PAUSE TestAccAWSSchemasSchema_Tags
=== CONT  TestAccAWSSchemasDiscoverer_basic
=== CONT  TestAccAWSSchemasRegistry_Tags
=== CONT  TestAccAWSSchemasSchema_Tags
=== CONT  TestAccAWSSchemasRegistry_basic
=== CONT  TestAccAWSSchemasSchema_basic
=== CONT  TestAccAWSSchemasDiscoverer_Description
=== CONT  TestAccAWSSchemasSchema_ContentDescription
=== CONT  TestAccAWSSchemasDiscoverer_Tags
=== CONT  TestAccAWSSchemasDiscoverer_disappears
=== CONT  TestAccAWSSchemasSchema_disappears
=== CONT  TestAccAWSSchemasRegistry_Description
=== CONT  TestAccAWSSchemasRegistry_disappears
=== CONT  TestAccAWSSchemasDiscoverer_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasDiscoverer_basic (1.52s)
=== CONT  TestAccAWSSchemasRegistry_Tags
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasRegistry_Tags (1.52s)
=== CONT  TestAccAWSSchemasSchema_Tags
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasSchema_Tags (1.52s)
=== CONT  TestAccAWSSchemasDiscoverer_Tags
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasDiscoverer_Tags (1.52s)
=== CONT  TestAccAWSSchemasDiscoverer_disappears
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasDiscoverer_disappears (1.52s)
=== CONT  TestAccAWSSchemasSchema_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasSchema_basic (1.52s)
=== CONT  TestAccAWSSchemasRegistry_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
=== CONT  TestAccAWSSchemasSchema_ContentDescription
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
=== CONT  TestAccAWSSchemasRegistry_Description
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasRegistry_basic (1.52s)
=== CONT  TestAccAWSSchemasRegistry_disappears
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasSchema_ContentDescription (1.52s)
--- SKIP: TestAccAWSSchemasRegistry_Description (1.52s)
=== CONT  TestAccAWSSchemasDiscoverer_Description
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasRegistry_disappears (1.52s)
--- SKIP: TestAccAWSSchemasDiscoverer_Description (1.52s)
=== CONT  TestAccAWSSchemasSchema_disappears
    provider_test.go:734: skipping tests; partition aws-us-gov does not support schemas service
--- SKIP: TestAccAWSSchemasSchema_disappears (1.52s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.543s

@ewbankkit
Copy link
Contributor

@jordanfinners Thanks for the contribution 🎉 👏.
Everything looks great.
In order to get this merged quickly I made a few changes:

  • Added tags_all attributes for default_tags support
  • Removed discoverer_id attribute (duplicative of id)
  • In aws_schemas_schema renamed registry to registry_name

ewbankkit added 7 commits May 26, 2021 16:49
@ewbankkit
Add 'schemas' to labelers.
3c46cc4
@ewbankkit
r/aws_schemas_discoverer: Remove 'discoverer_id' attribute.
7f35b75 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSchemasDiscoverer_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemasDiscoverer_ -timeout 180m
=== RUN   TestAccAWSSchemasDiscoverer_basic
=== PAUSE TestAccAWSSchemasDiscoverer_basic
=== RUN   TestAccAWSSchemasDiscoverer_disappears
=== PAUSE TestAccAWSSchemasDiscoverer_disappears
=== RUN   TestAccAWSSchemasDiscoverer_Description
=== PAUSE TestAccAWSSchemasDiscoverer_Description
=== RUN   TestAccAWSSchemasDiscoverer_Tags
=== PAUSE TestAccAWSSchemasDiscoverer_Tags
=== CONT  TestAccAWSSchemasDiscoverer_basic
=== CONT  TestAccAWSSchemasDiscoverer_Tags
=== CONT  TestAccAWSSchemasDiscoverer_Description
=== CONT  TestAccAWSSchemasDiscoverer_disappears
--- PASS: TestAccAWSSchemasDiscoverer_disappears (14.58s)
--- PASS: TestAccAWSSchemasDiscoverer_basic (17.70s)
--- PASS: TestAccAWSSchemasDiscoverer_Tags (40.38s)
--- PASS: TestAccAWSSchemasDiscoverer_Description (40.46s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	43.537s
@ewbankkit
r/aws_schemas_registry: Can't update 'name'.
4a99f87 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSchemasRegistry_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemasRegistry_ -timeout 180m
=== RUN   TestAccAWSSchemasRegistry_basic
=== PAUSE TestAccAWSSchemasRegistry_basic
=== RUN   TestAccAWSSchemasRegistry_disappears
=== PAUSE TestAccAWSSchemasRegistry_disappears
=== RUN   TestAccAWSSchemasRegistry_Description
=== PAUSE TestAccAWSSchemasRegistry_Description
=== RUN   TestAccAWSSchemasRegistry_Tags
=== PAUSE TestAccAWSSchemasRegistry_Tags
=== CONT  TestAccAWSSchemasRegistry_basic
=== CONT  TestAccAWSSchemasRegistry_Tags
=== CONT  TestAccAWSSchemasRegistry_Description
=== CONT  TestAccAWSSchemasRegistry_disappears
--- PASS: TestAccAWSSchemasRegistry_disappears (10.49s)
--- PASS: TestAccAWSSchemasRegistry_basic (16.15s)
--- PASS: TestAccAWSSchemasRegistry_Description (36.82s)
--- PASS: TestAccAWSSchemasRegistry_Tags (37.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	40.482s
@ewbankkit
r/aws_schemas_schema: 'registry' -> 'registry_name'.
d566593 
Acceptance test output:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSSchemasSchema_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSchemasSchema_ -timeout 180m
=== RUN   TestAccAWSSchemasSchema_basic
=== PAUSE TestAccAWSSchemasSchema_basic
=== RUN   TestAccAWSSchemasSchema_disappears
=== PAUSE TestAccAWSSchemasSchema_disappears
=== RUN   TestAccAWSSchemasSchema_ContentDescription
=== PAUSE TestAccAWSSchemasSchema_ContentDescription
=== RUN   TestAccAWSSchemasSchema_Tags
=== PAUSE TestAccAWSSchemasSchema_Tags
=== CONT  TestAccAWSSchemasSchema_basic
=== CONT  TestAccAWSSchemasSchema_Tags
=== CONT  TestAccAWSSchemasSchema_disappears
=== CONT  TestAccAWSSchemasSchema_ContentDescription
--- PASS: TestAccAWSSchemasSchema_disappears (13.71s)
--- PASS: TestAccAWSSchemasSchema_basic (17.04s)
--- PASS: TestAccAWSSchemasSchema_Tags (39.01s)
--- PASS: TestAccAWSSchemasSchema_ContentDescription (39.47s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	42.503s
@ewbankkit
Tidy up test sweepers for EventBus Schemas.
73058d6
@ewbankkit
Fix terrafmt errors.
fe3f5a0
@ewbankkit
Tweak CHANGELOG entry.
e4151a4
@ewbankkit ewbankkit merged commit fe284d9 into hashicorp:main May 26, 2021
@github-actions github-actions bot added this to the v3.43.0 milestone May 26, 2021
@jordanfinners jordanfinners deleted the f-eventbridge-schemas branch May 27, 2021 04:18
@jordanfinners
Copy link
Contributor Author

@jordanfinners Thanks for the contribution 🎉 👏.
Everything looks great.
In order to get this merged quickly I made a few changes:

  • Added tags_all attributes for default_tags support
  • Removed discoverer_id attribute (duplicative of id)
  • In aws_schemas_schema renamed registry to registry_name

Thank you for sorting those bits! 😊

@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@sthulb sthulb sthulb approved these changes

Assignees

@ewbankkit ewbankkit

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. size/XXL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.43.0
Development

Successfully merging this pull request may close these issues.

Support Amazon EventBridge Schema Registry
3 participants
@jordanfinners @sthulb @ewbankkit