F/resource aws elasticache subnet group: Support Tags

[nikhil-goenka]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #18884.

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheSubnetGroup_tags'
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheSubnetGroup_tags -timeout 180m
=== RUN   TestAccAWSElasticacheSubnetGroup_tags
=== PAUSE TestAccAWSElasticacheSubnetGroup_tags
=== CONT  TestAccAWSElasticacheSubnetGroup_tags
--- PASS: TestAccAWSElasticacheSubnetGroup_tags (181.42s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	185.284s
...

[ewbankkit]

@nikhil-goenka Thanks for the contribution 👏.
Could you please add documentation for the tags_all attribute - details very recently added to the Contributing Guide.

[ewbankkit]

LGTM 🚀

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheSubnetGroup_'                                         
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheSubnetGroup_ -timeout 180m
=== RUN   TestAccAWSElasticacheSubnetGroup_basic
=== PAUSE TestAccAWSElasticacheSubnetGroup_basic
=== RUN   TestAccAWSElasticacheSubnetGroup_update
=== PAUSE TestAccAWSElasticacheSubnetGroup_update
=== RUN   TestAccAWSElasticacheSubnetGroup_tags
=== PAUSE TestAccAWSElasticacheSubnetGroup_tags
=== CONT  TestAccAWSElasticacheSubnetGroup_basic
=== CONT  TestAccAWSElasticacheSubnetGroup_tags
=== CONT  TestAccAWSElasticacheSubnetGroup_update
--- PASS: TestAccAWSElasticacheSubnetGroup_basic (27.87s)
--- PASS: TestAccAWSElasticacheSubnetGroup_update (49.21s)
--- PASS: TestAccAWSElasticacheSubnetGroup_tags (66.08s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	68.982s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheSubnetGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheSubnetGroup_ -timeout 180m
=== RUN   TestAccAWSElasticacheSubnetGroup_basic
=== PAUSE TestAccAWSElasticacheSubnetGroup_basic
=== RUN   TestAccAWSElasticacheSubnetGroup_update
=== PAUSE TestAccAWSElasticacheSubnetGroup_update
=== RUN   TestAccAWSElasticacheSubnetGroup_tags
=== PAUSE TestAccAWSElasticacheSubnetGroup_tags
=== CONT  TestAccAWSElasticacheSubnetGroup_basic
=== CONT  TestAccAWSElasticacheSubnetGroup_update
=== CONT  TestAccAWSElasticacheSubnetGroup_tags
--- PASS: TestAccAWSElasticacheSubnetGroup_basic (32.28s)
--- PASS: TestAccAWSElasticacheSubnetGroup_update (55.46s)
--- PASS: TestAccAWSElasticacheSubnetGroup_tags (74.61s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	77.553s

[ewbankkit]

@nikhil-goenka Looks good.
I added a call to resourceAwsElasticacheSubnetGroupRead at the end of resourceAwsElasticacheSubnetGroupCreate or else the tests were showing a diff:

=== CONT  TestAccAWSElasticacheSubnetGroup_basic
    resource_aws_elasticache_subnet_group_test.go:67: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_elasticache_subnet_group.test will be updated in-place
          ~ resource "aws_elasticache_subnet_group" "test" {
                description = "Managed by Terraform"
                id          = "tf-test-cache-subnet-2146569789512030701"
                name        = "tf-test-cache-subnet-2146569789512030701"
                subnet_ids  = [
                    "subnet-0608f1320a3b2604c",
                ]
              + tags_all    = (known after apply)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

[nikhil-goenka]

@nikhil-goenka Looks good.
I added a call to resourceAwsElasticacheSubnetGroupRead at the end of resourceAwsElasticacheSubnetGroupCreate or else the tests were showing a diff:

=== CONT  TestAccAWSElasticacheSubnetGroup_basic
    resource_aws_elasticache_subnet_group_test.go:67: Step 1/2 error: After applying this test step, the plan was not empty.
        stdout:
        
        
        An execution plan has been generated and is shown below.
        Resource actions are indicated with the following symbols:
          ~ update in-place
        
        Terraform will perform the following actions:
        
          # aws_elasticache_subnet_group.test will be updated in-place
          ~ resource "aws_elasticache_subnet_group" "test" {
                description = "Managed by Terraform"
                id          = "tf-test-cache-subnet-2146569789512030701"
                name        = "tf-test-cache-subnet-2146569789512030701"
                subnet_ids  = [
                    "subnet-0608f1320a3b2604c",
                ]
              + tags_all    = (known after apply)
            }
        
        Plan: 0 to add, 1 to change, 0 to destroy.

@ewbankkit : Thanks

[ghost]

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.