Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource/aws_route53_resolver_firewall_rule_group_association: Add new resource #19164

Merged
merged 8 commits into from
Apr 29, 2021
Merged

resource/aws_route53_resolver_firewall_rule_group_association: Add new resource #19164

merged 8 commits into from
Apr 29, 2021

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Apr 29, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates: #18520
Replaces: #18731

Output from acceptance testing:

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_'                          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears (189.94s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection (203.66s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic (212.09s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags (240.66s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority (298.32s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name (388.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	391.720s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears (224.56s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic (238.91s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection (259.86s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags (270.61s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority (327.57s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name (408.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	411.195s

@ewbankkit ewbankkit requested a review from a team as a code owner April 29, 2021 19:23
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Apr 29, 2021
@ewbankkit ewbankkit mentioned this pull request Apr 29, 2021
Closed
@bflad bflad self-assigned this Apr 29, 2021
bflad
bflad approved these changes Apr 29, 2021
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things, otherwise looks good to me. 🚀

aws/internal/service/route53resolver/waiter/waiter.go Outdated Show resolved Hide resolved
aws/resource_aws_route53_resolver_firewall_rule_group_association.go Outdated Show resolved Hide resolved
aws/resource_aws_route53_resolver_firewall_rule_group_association.go Outdated Show resolved Hide resolved
aws/resource_aws_route53_resolver_firewall_rule_group_association.go Outdated Show resolved Hide resolved
ewbankkit and others added 4 commits April 29, 2021 16:31
@ewbankkit
Copy link
Contributor Author

Re-ran acceptance tests:

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_'  
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_ -timeout 180m
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== RUN   TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== PAUSE TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection
=== CONT  TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_basic (186.63s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_disappears (192.39s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_mutationProtection (207.96s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_tags (228.00s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_priority (294.59s)
--- PASS: TestAccAWSRoute53ResolverFirewallRuleGroupAssociation_name (354.24s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	357.279s

@ewbankkit ewbankkit merged commit dc6ef54 into main Apr 29, 2021
@ewbankkit ewbankkit deleted the tmp-pr18731 branch April 29, 2021 20:50
@github-actions github-actions bot added this to the v3.38.0 milestone Apr 29, 2021
github-actions bot pushed a commit that referenced this pull request Apr 29, 2021
Update CHANGELOG.md for #19164
5ef4410
@ghost
Copy link

ghost commented Apr 30, 2021

This has been released in version 3.38.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jun 1, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees

@bflad bflad

Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/route53resolver Issues and PRs that pertain to the route53resolver service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.38.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ewbankkit @bflad @gazoakley