Support CodeStar Connection data source lookup by name

[wedge-jarrad]

Update aws_codestarconnections_connection data source to allow lookups by name.

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15453

Output from acceptance testing:

$ gmake testacc TESTARGS='-run=TestAccDataSourceAwsCodeStarConnectionsConnection'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsCodeStarConnectionsConnection -timeout 180m
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== RUN   TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== PAUSE TestAccDataSourceAwsCodeStarConnectionsConnection_tags
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_basic
=== CONT  TestAccDataSourceAwsCodeStarConnectionsConnection_tags
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_tags (18.09s)
--- PASS: TestAccDataSourceAwsCodeStarConnectionsConnection_basic (18.17s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.249s

[zhelding]

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

[wedge-jarrad]

Updated acceptance test run after the merge:

$ gmake testacc TESTARGS='-run=TestAccCodeStarConnectionsConnectionDataSource' PKG_NAME=internal/service/codestarconnections
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codestarconnections/... -v -count 1 -parallel 20 -run=TestAccCodeStarConnectionsConnectionDataSource -timeout 180m
=== RUN   TestAccCodeStarConnectionsConnectionDataSource_basic
=== PAUSE TestAccCodeStarConnectionsConnectionDataSource_basic
=== RUN   TestAccCodeStarConnectionsConnectionDataSource_tags
=== PAUSE TestAccCodeStarConnectionsConnectionDataSource_tags
=== CONT  TestAccCodeStarConnectionsConnectionDataSource_basic
=== CONT  TestAccCodeStarConnectionsConnectionDataSource_tags
--- PASS: TestAccCodeStarConnectionsConnectionDataSource_tags (13.77s)
--- PASS: TestAccCodeStarConnectionsConnectionDataSource_basic (13.92s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections	13.983s

[ewbankkit]

LGTM 🚀.

% make sweep SWEEPARGS=-sweep-run=aws_codestarconnections_host
# make sweep SWEEPARGS=-sweep-run=aws_example_thing
WARNING: This will destroy infrastructure. Use only in development accounts.
go test ./internal/sweep -v -tags=sweep -sweep=us-west-2,us-east-1,us-east-2 -sweep-run=aws_codestarconnections_host -timeout 60m
2022/05/06 14:24:53 [DEBUG] Running Sweepers for region (us-west-2):
2022/05/06 14:24:53 [DEBUG] Sweeper (aws_codestarconnections_host) has dependency (aws_codestarconnections_connection), running..
2022/05/06 14:24:53 [DEBUG] Running Sweeper (aws_codestarconnections_connection) in region (us-west-2)
2022/05/06 14:24:53 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/05/06 14:24:53 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/05/06 14:24:54 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/05/06 14:24:56 [DEBUG] Completed Sweeper (aws_codestarconnections_connection) in region (us-west-2) in 3.204716576s
2022/05/06 14:24:56 [DEBUG] Running Sweeper (aws_codestarconnections_host) in region (us-west-2)
2022/05/06 14:24:56 [DEBUG] Completed Sweeper (aws_codestarconnections_host) in region (us-west-2) in 182.956826ms
2022/05/06 14:24:56 [DEBUG] Sweeper (aws_codestarconnections_connection) already ran in region (us-west-2)
2022/05/06 14:24:56 Completed Sweepers for region (us-west-2) in 3.387883982s
2022/05/06 14:24:56 Sweeper Tests for region (us-west-2) ran successfully:
	- aws_codestarconnections_connection
	- aws_codestarconnections_host
2022/05/06 14:24:56 [DEBUG] Running Sweepers for region (us-east-1):
2022/05/06 14:24:56 [DEBUG] Sweeper (aws_codestarconnections_host) has dependency (aws_codestarconnections_connection), running..
2022/05/06 14:24:56 [DEBUG] Running Sweeper (aws_codestarconnections_connection) in region (us-east-1)
2022/05/06 14:24:56 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/05/06 14:24:56 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/05/06 14:24:57 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/05/06 14:24:59 [DEBUG] Completed Sweeper (aws_codestarconnections_connection) in region (us-east-1) in 2.588793075s
2022/05/06 14:24:59 [DEBUG] Running Sweeper (aws_codestarconnections_host) in region (us-east-1)
2022/05/06 14:24:59 [DEBUG] Completed Sweeper (aws_codestarconnections_host) in region (us-east-1) in 46.946309ms
2022/05/06 14:24:59 [DEBUG] Sweeper (aws_codestarconnections_connection) already ran in region (us-east-1)
2022/05/06 14:24:59 Completed Sweepers for region (us-east-1) in 2.635781717s
2022/05/06 14:24:59 Sweeper Tests for region (us-east-1) ran successfully:
	- aws_codestarconnections_connection
	- aws_codestarconnections_host
2022/05/06 14:24:59 [DEBUG] Running Sweepers for region (us-east-2):
2022/05/06 14:24:59 [DEBUG] Running Sweeper (aws_codestarconnections_connection) in region (us-east-2)
2022/05/06 14:24:59 [INFO] Retrieved credentials from "EnvConfigCredentials"
2022/05/06 14:24:59 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/05/06 14:24:59 [DEBUG] Trying to get account information via sts:GetCallerIdentity
2022/05/06 14:24:59 [DEBUG] Completed Sweeper (aws_codestarconnections_connection) in region (us-east-2) in 655.334506ms
2022/05/06 14:24:59 [DEBUG] Sweeper (aws_codestarconnections_host) has dependency (aws_codestarconnections_connection), running..
2022/05/06 14:24:59 [DEBUG] Sweeper (aws_codestarconnections_connection) already ran in region (us-east-2)
2022/05/06 14:24:59 [DEBUG] Running Sweeper (aws_codestarconnections_host) in region (us-east-2)
2022/05/06 14:24:59 [DEBUG] Completed Sweeper (aws_codestarconnections_host) in region (us-east-2) in 64.874316ms
2022/05/06 14:24:59 Completed Sweepers for region (us-east-2) in 720.25378ms
2022/05/06 14:24:59 Sweeper Tests for region (us-east-2) ran successfully:
	- aws_codestarconnections_connection
	- aws_codestarconnections_host
ok  	github.com/hashicorp/terraform-provider-aws/internal/sweep	10.453s
% make testacc TESTS=TestAccCodeStarConnectionsConnectionDataSource_ PKG=codestarconnections ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codestarconnections/... -v -count 1 -parallel 2 -run='TestAccCodeStarConnectionsConnectionDataSource_'  -timeout 180m
=== RUN   TestAccCodeStarConnectionsConnectionDataSource_basic
=== PAUSE TestAccCodeStarConnectionsConnectionDataSource_basic
=== RUN   TestAccCodeStarConnectionsConnectionDataSource_tags
=== PAUSE TestAccCodeStarConnectionsConnectionDataSource_tags
=== CONT  TestAccCodeStarConnectionsConnectionDataSource_basic
=== CONT  TestAccCodeStarConnectionsConnectionDataSource_tags
--- PASS: TestAccCodeStarConnectionsConnectionDataSource_basic (20.49s)
--- PASS: TestAccCodeStarConnectionsConnectionDataSource_tags (20.54s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections	28.602s
% make testacc TESTS=TestAccCodeStarConnectionsConnection_ PKG=codestarconnections ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codestarconnections/... -v -count 1 -parallel 2 -run='TestAccCodeStarConnectionsConnection_'  -timeout 180m
=== RUN   TestAccCodeStarConnectionsConnection_basic
=== PAUSE TestAccCodeStarConnectionsConnection_basic
=== RUN   TestAccCodeStarConnectionsConnection_hostARN
=== PAUSE TestAccCodeStarConnectionsConnection_hostARN
=== RUN   TestAccCodeStarConnectionsConnection_disappears
=== PAUSE TestAccCodeStarConnectionsConnection_disappears
=== RUN   TestAccCodeStarConnectionsConnection_tags
=== PAUSE TestAccCodeStarConnectionsConnection_tags
=== CONT  TestAccCodeStarConnectionsConnection_basic
=== CONT  TestAccCodeStarConnectionsConnection_disappears
--- PASS: TestAccCodeStarConnectionsConnection_disappears (15.25s)
=== CONT  TestAccCodeStarConnectionsConnection_hostARN
--- PASS: TestAccCodeStarConnectionsConnection_basic (20.50s)
=== CONT  TestAccCodeStarConnectionsConnection_tags
--- PASS: TestAccCodeStarConnectionsConnection_hostARN (19.74s)
--- PASS: TestAccCodeStarConnectionsConnection_tags (47.90s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections	76.514s
% make testacc TESTS=TestAccCodeStarConnectionsHost_ PKG=codestarconnections ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/codestarconnections/... -v -count 1 -parallel 2 -run='TestAccCodeStarConnectionsHost_'  -timeout 180m
=== RUN   TestAccCodeStarConnectionsHost_basic
=== PAUSE TestAccCodeStarConnectionsHost_basic
=== RUN   TestAccCodeStarConnectionsHost_disappears
=== PAUSE TestAccCodeStarConnectionsHost_disappears
=== RUN   TestAccCodeStarConnectionsHost_vpc
=== PAUSE TestAccCodeStarConnectionsHost_vpc
=== CONT  TestAccCodeStarConnectionsHost_basic
=== CONT  TestAccCodeStarConnectionsHost_vpc
--- PASS: TestAccCodeStarConnectionsHost_basic (21.62s)
=== CONT  TestAccCodeStarConnectionsHost_disappears
--- PASS: TestAccCodeStarConnectionsHost_disappears (15.86s)
--- PASS: TestAccCodeStarConnectionsHost_vpc (494.45s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/codestarconnections	500.765s

[ewbankkit]

@wedge-jarrad Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.14.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.