Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/servicecatalog_budget_resource_association: New resource #19452

Merged
merged 11 commits into from
May 20, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 20, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #15369
Relates #18074
Relates #19122

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSServiceCatalogBudgetResourceAssociation_disappears (13.24s)
--- PASS: TestAccAWSServiceCatalogBudgetResourceAssociation_basic (15.21s)

Output from acceptance testing (GovCloud):

(partition aws-us-gov does not support budgets service)

--- SKIP: TestAccAWSServiceCatalogBudgetResourceAssociation_basic (1.23s)
--- SKIP: TestAccAWSServiceCatalogBudgetResourceAssociation_disappears (1.23s)

@YakDriver YakDriver requested a review from a team as a code owner May 20, 2021 13:07
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 20, 2021
@ewbankkit ewbankkit changed the title r/servicecatalog_budget_resource_associaton: New resource r/servicecatalog_budget_resource_association: New resource May 20, 2021
@ewbankkit ewbankkit self-assigned this May 20, 2021

Manages a Service Catalog Budget Resource Association.

-> A "resource" is either a Service Catalog portfolio or product.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogBudgetResourceAssociation_'   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogBudgetResourceAssociation_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogBudgetResourceAssociation_basic
=== PAUSE TestAccAWSServiceCatalogBudgetResourceAssociation_basic
=== RUN   TestAccAWSServiceCatalogBudgetResourceAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogBudgetResourceAssociation_disappears
=== CONT  TestAccAWSServiceCatalogBudgetResourceAssociation_basic
=== CONT  TestAccAWSServiceCatalogBudgetResourceAssociation_disappears
--- PASS: TestAccAWSServiceCatalogBudgetResourceAssociation_disappears (13.60s)
--- PASS: TestAccAWSServiceCatalogBudgetResourceAssociation_basic (15.58s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	18.569s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSServiceCatalogBudgetResourceAssociation_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogBudgetResourceAssociation_ -timeout 180m
=== RUN   TestAccAWSServiceCatalogBudgetResourceAssociation_basic
=== PAUSE TestAccAWSServiceCatalogBudgetResourceAssociation_basic
=== RUN   TestAccAWSServiceCatalogBudgetResourceAssociation_disappears
=== PAUSE TestAccAWSServiceCatalogBudgetResourceAssociation_disappears
=== CONT  TestAccAWSServiceCatalogBudgetResourceAssociation_basic
=== CONT  TestAccAWSServiceCatalogBudgetResourceAssociation_disappears
    provider_test.go:734: skipping tests; partition aws-us-gov does not support budgets service
=== CONT  TestAccAWSServiceCatalogBudgetResourceAssociation_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support budgets service
--- SKIP: TestAccAWSServiceCatalogBudgetResourceAssociation_basic (1.31s)
--- SKIP: TestAccAWSServiceCatalogBudgetResourceAssociation_disappears (1.31s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.291s

@ewbankkit ewbankkit removed their assignment May 20, 2021
@YakDriver YakDriver merged commit 3b968fa into main May 20, 2021
@YakDriver YakDriver deleted the f-servicecat-budget-resource-association branch May 20, 2021 17:30
@YakDriver YakDriver added this to the v3.43.0 milestone May 20, 2021
github-actions bot pushed a commit that referenced this pull request May 20, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/servicecatalog Issues and PRs that pertain to the servicecatalog service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants