Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/eks_addon: Use service account #19454

Merged
merged 2 commits into from
May 20, 2021
Merged

r/eks_addon: Use service account #19454

merged 2 commits into from
May 20, 2021

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented May 20, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19403
Closes #19402

Output from acceptance testing (us-west-2):

--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_duplicateTag (4.37s)
--- PASS: TestAccAWSEksAddon_ServiceAccountRoleArn (823.69s)
--- PASS: TestAccAWSEksAddon_defaultTags_updateToProviderOnly (873.03s)
--- PASS: TestAccAWSEksAddon_defaultAndIgnoreTags (877.86s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerOnly (891.51s)
--- PASS: TestAccAWSEksAddon_disappears (897.03s)
--- PASS: TestAccAWSEksAddon_Tags (906.19s)
--- PASS: TestAccAWSEksAddon_ignoreTags (920.50s)
--- PASS: TestAccAWSEksAddon_defaultTags_updateToResourceOnly (949.72s)
--- PASS: TestAccAWSEksAddon_disappears_Cluster (988.40s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_overlappingTag (1005.13s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_nonOverlappingTag (1011.28s)
--- PASS: TestAccAWSEksAddon_ResolveConflicts (1032.76s)
--- PASS: TestAccAWSEksAddon_AddonVersion (1149.38s)
--- PASS: TestAccAWSEksAddon_basic (1164.05s)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_duplicateTag (5.15s)
--- PASS: TestAccAWSEksAddon_disappears_Cluster (647.59s)
--- PASS: TestAccAWSEksAddon_defaultTags_updateToProviderOnly (663.42s)
--- PASS: TestAccAWSEksAddon_ResolveConflicts (681.14s)
--- PASS: TestAccAWSEksAddon_basic (714.48s)
--- PASS: TestAccAWSEksAddon_AddonVersion (825.23s)
--- PASS: TestAccAWSEksAddon_ignoreTags (728.63s)
--- PASS: TestAccAWSEksAddonDataSource_basic (738.06s)
--- PASS: TestAccAWSEksAddon_defaultAndIgnoreTags (738.26s)
--- PASS: TestAccAWSEksAddon_disappears (747.06s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerOnly (754.51s)
--- PASS: TestAccAWSEksAddon_ServiceAccountRoleArn (762.98s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_overlappingTag (763.24s)
--- PASS: TestAccAWSEksAddon_Tags (810.54s)
--- PASS: TestAccAWSEksAddon_defaultTags_providerAndResource_nonOverlappingTag (821.32s)
--- PASS: TestAccAWSEksAddon_defaultTags_updateToResourceOnly (831.51s)

kreativka and others added 2 commits May 17, 2021 08:58
@kreativka
Use service_account_role_arn if already provided.
6dbbe18 
AddonUpdateInput:
    // The Amazon Resource Name (ARN) of an existing IAM role to bind to the add-on's
    // service account. The role must be assigned the IAM permissions required by
    // the add-on. If you don't specify an existing IAM role, then the add-on uses
    // the permissions assigned to the node IAM role. For more information, see
    // Amazon EKS node IAM role (https://docs.aws.amazon.com/eks/latest/userguide/create-node-role.html)
    // in the Amazon EKS User Guide.
@YakDriver
r/eks_addon: Fix nil check
cdfd2ed
@YakDriver YakDriver requested a review from a team as a code owner May 20, 2021 14:50
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/eks Issues and PRs that pertain to the eks service. labels May 20, 2021
@YakDriver YakDriver self-assigned this May 20, 2021
@YakDriver YakDriver merged commit 9e69307 into main May 20, 2021
@YakDriver YakDriver deleted the useAlreadyProvidedSAarn branch May 20, 2021 16:14
@github-actions github-actions bot added this to the v3.43.0 milestone May 20, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 2, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@YakDriver YakDriver

Labels
service/eks Issues and PRs that pertain to the eks service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
v3.43.0
Development

Successfully merging this pull request may close these issues.

aws_eks_addon updates version and reverts service role arn
2 participants
@YakDriver @kreativka