-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New resource: aws_lambda_invocation #19488
New resource: aws_lambda_invocation #19488
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @pascal236 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
Dunno if it can be done without changes to this PR, what about changing the input on tf destroy phase? |
@DJAlPee Thanks a lot for your swift review. Can we merge this before it gets stale again? |
Sorry, but I'm not a member of Hashicorp/Terraform team (yet) 😄. |
If anyone knows how to push/notify this to one of the terraform-aws reviewer, please let me know :) |
Is this on the radar?? |
Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding. Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author. For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000. For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 🎉
Output of acceptance tests (us-west-2
):
% make testacc TESTS=TestAccLambdaInvocation_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaInvocation_' -timeout 180m
--- PASS: TestAccLambdaInvocation_basic (31.34s)
--- PASS: TestAccLambdaInvocation_qualifier (45.57s)
--- PASS: TestAccLambdaInvocation_complex (53.02s)
--- PASS: TestAccLambdaInvocation_triggers (68.51s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 69.753s
Output of acceptance tests (GovCloud):
% make testacc TESTS=TestAccLambdaInvocation_ PKG=lambda
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/lambda/... -v -count 1 -parallel 20 -run='TestAccLambdaInvocation_' -timeout 180m
--- PASS: TestAccLambdaInvocation_basic (33.75s)
--- PASS: TestAccLambdaInvocation_qualifier (40.24s)
--- PASS: TestAccLambdaInvocation_complex (46.88s)
--- PASS: TestAccLambdaInvocation_triggers (91.14s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/lambda 92.475s
This functionality has been released in v3.73.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #4746
Output from acceptance testing:
All credits to dedunumax #14388 (I am just fixing a stale PR)