Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_sqs_queue Deduplication Scope support #19498

Closed
slichtenthal opened this issue May 24, 2021 · 2 comments · Fixed by #19639
Closed

aws_sqs_queue Deduplication Scope support #19498

slichtenthal opened this issue May 24, 2021 · 2 comments · Fixed by #19639
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sqs Issues and PRs that pertain to the sqs service.
Milestone

Comments

@slichtenthal
Copy link

slichtenthal commented May 24, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

AWS SQS FIFO Queues have the ability to deduplicate messages either on the queue (default) or message group. Unfortunately there doesn't seem to be a way currently to set the deduplication message scope to be message group. Having support for this would be quite helpful.

New or Affected Resource(s)

  • aws_sqs_queue

Potential Terraform Configuration

I would add the following optional property to resource aws_sqs_queue:
deduplication_scope
By default it will be set to "queue" with the ability to override to "message_group".

Another option would be to have it be:
deduplication_scope_queue with a default value of true and if set to false, set to message_group. While this is easier to understand the possible values (true/false), it would prevent scaling in case AWS adds a third option.

Examples:

resource "aws_sqs_queue" "my_fifo_queue" {
  name = "my-fifo-queue"
  fifo_queue = true
  deduplication_scope="queue"
}

OR

resource "aws_sqs_queue" "my_fifo_queue" {
  name = "my-fifo-queue"
  fifo_queue = true
  deduplication_scope_queue=false
}

References

@slichtenthal slichtenthal added the enhancement Requests to existing resources that expand the functionality or scope. label May 24, 2021
@ghost ghost added the service/sqs Issues and PRs that pertain to the sqs service. label May 24, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 24, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label May 24, 2021
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 7, 2021
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/sqs Issues and PRs that pertain to the sqs service.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants