aws_ec2_capacity_reservation outpost_arn attribute support

[richardjennings]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19509

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

[richardjennings]

Missing Tests. How can outpost_arn be tested ?

[ewbankkit]

@richardjennings Thanks for the contribution 👏.
All that remains is to add a check to TestAccAWSEc2CapacityReservation_basic that outpost_arn is "" and adding a line to website/docs/r/ec2_capacity_reservation.html.markdown.

[richardjennings]

@richardjennings Thanks for the contribution 👏.
All that remains is to add a check to TestAccAWSEc2CapacityReservation_basic that outpost_arn is "" and adding a line to website/docs/r/ec2_capacity_reservation.html.markdown.

done

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEc2CapacityReservation_'                                                 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2CapacityReservation_ -timeout 180m
=== RUN   TestAccAWSEc2CapacityReservation_basic
=== PAUSE TestAccAWSEc2CapacityReservation_basic
=== RUN   TestAccAWSEc2CapacityReservation_ebsOptimized
=== PAUSE TestAccAWSEc2CapacityReservation_ebsOptimized
=== RUN   TestAccAWSEc2CapacityReservation_endDate
=== PAUSE TestAccAWSEc2CapacityReservation_endDate
=== RUN   TestAccAWSEc2CapacityReservation_endDateType
=== PAUSE TestAccAWSEc2CapacityReservation_endDateType
=== RUN   TestAccAWSEc2CapacityReservation_ephemeralStorage
=== PAUSE TestAccAWSEc2CapacityReservation_ephemeralStorage
=== RUN   TestAccAWSEc2CapacityReservation_instanceCount
=== PAUSE TestAccAWSEc2CapacityReservation_instanceCount
=== RUN   TestAccAWSEc2CapacityReservation_instanceMatchCriteria
=== PAUSE TestAccAWSEc2CapacityReservation_instanceMatchCriteria
=== RUN   TestAccAWSEc2CapacityReservation_instanceType
=== PAUSE TestAccAWSEc2CapacityReservation_instanceType
=== RUN   TestAccAWSEc2CapacityReservation_tags
=== PAUSE TestAccAWSEc2CapacityReservation_tags
=== RUN   TestAccAWSEc2CapacityReservation_disappears
=== PAUSE TestAccAWSEc2CapacityReservation_disappears
=== RUN   TestAccAWSEc2CapacityReservation_tenancy
    provider_test.go:57: EC2 Capacity Reservations do not currently support dedicated tenancy.
--- SKIP: TestAccAWSEc2CapacityReservation_tenancy (0.00s)
=== CONT  TestAccAWSEc2CapacityReservation_basic
=== CONT  TestAccAWSEc2CapacityReservation_instanceMatchCriteria
=== CONT  TestAccAWSEc2CapacityReservation_endDateType
=== CONT  TestAccAWSEc2CapacityReservation_ephemeralStorage
=== CONT  TestAccAWSEc2CapacityReservation_tags
=== CONT  TestAccAWSEc2CapacityReservation_disappears
=== CONT  TestAccAWSEc2CapacityReservation_instanceType
=== CONT  TestAccAWSEc2CapacityReservation_instanceCount
=== CONT  TestAccAWSEc2CapacityReservation_endDate
=== CONT  TestAccAWSEc2CapacityReservation_ebsOptimized
--- PASS: TestAccAWSEc2CapacityReservation_disappears (17.71s)
--- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (25.14s)
--- PASS: TestAccAWSEc2CapacityReservation_basic (25.14s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (25.59s)
--- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (25.59s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceCount (39.86s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceType (40.14s)
--- PASS: TestAccAWSEc2CapacityReservation_endDate (40.27s)
--- PASS: TestAccAWSEc2CapacityReservation_tags (49.01s)
--- PASS: TestAccAWSEc2CapacityReservation_endDateType (50.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	53.486s          

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEc2CapacityReservation_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEc2CapacityReservation_ -timeout 180m
=== RUN   TestAccAWSEc2CapacityReservation_basic
=== PAUSE TestAccAWSEc2CapacityReservation_basic
=== RUN   TestAccAWSEc2CapacityReservation_ebsOptimized
=== PAUSE TestAccAWSEc2CapacityReservation_ebsOptimized
=== RUN   TestAccAWSEc2CapacityReservation_endDate
=== PAUSE TestAccAWSEc2CapacityReservation_endDate
=== RUN   TestAccAWSEc2CapacityReservation_endDateType
=== PAUSE TestAccAWSEc2CapacityReservation_endDateType
=== RUN   TestAccAWSEc2CapacityReservation_ephemeralStorage
=== PAUSE TestAccAWSEc2CapacityReservation_ephemeralStorage
=== RUN   TestAccAWSEc2CapacityReservation_instanceCount
=== PAUSE TestAccAWSEc2CapacityReservation_instanceCount
=== RUN   TestAccAWSEc2CapacityReservation_instanceMatchCriteria
=== PAUSE TestAccAWSEc2CapacityReservation_instanceMatchCriteria
=== RUN   TestAccAWSEc2CapacityReservation_instanceType
=== PAUSE TestAccAWSEc2CapacityReservation_instanceType
=== RUN   TestAccAWSEc2CapacityReservation_tags
=== PAUSE TestAccAWSEc2CapacityReservation_tags
=== RUN   TestAccAWSEc2CapacityReservation_disappears
=== PAUSE TestAccAWSEc2CapacityReservation_disappears
=== RUN   TestAccAWSEc2CapacityReservation_tenancy
    provider_test.go:57: EC2 Capacity Reservations do not currently support dedicated tenancy.
--- SKIP: TestAccAWSEc2CapacityReservation_tenancy (0.00s)
=== CONT  TestAccAWSEc2CapacityReservation_basic
=== CONT  TestAccAWSEc2CapacityReservation_endDateType
=== CONT  TestAccAWSEc2CapacityReservation_ebsOptimized
=== CONT  TestAccAWSEc2CapacityReservation_instanceCount
=== CONT  TestAccAWSEc2CapacityReservation_instanceMatchCriteria
=== CONT  TestAccAWSEc2CapacityReservation_disappears
=== CONT  TestAccAWSEc2CapacityReservation_tags
=== CONT  TestAccAWSEc2CapacityReservation_endDate
=== CONT  TestAccAWSEc2CapacityReservation_instanceType
=== CONT  TestAccAWSEc2CapacityReservation_ephemeralStorage
--- PASS: TestAccAWSEc2CapacityReservation_disappears (25.74s)
--- PASS: TestAccAWSEc2CapacityReservation_ebsOptimized (30.08s)
--- PASS: TestAccAWSEc2CapacityReservation_ephemeralStorage (30.22s)
--- PASS: TestAccAWSEc2CapacityReservation_basic (30.39s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceMatchCriteria (30.40s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceCount (40.92s)
--- PASS: TestAccAWSEc2CapacityReservation_endDate (43.05s)
--- PASS: TestAccAWSEc2CapacityReservation_instanceType (44.63s)
--- PASS: TestAccAWSEc2CapacityReservation_endDateType (57.02s)
--- PASS: TestAccAWSEc2CapacityReservation_tags (58.78s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	62.099s

[ewbankkit]

@richardjennings Thanks for the contribution 🎉 👏.

[FireballDWF]

@richardjennings Thanks for the PR, and @ewbankkit thanks for the review and merge. I can facilitate access to the AWS Outpost Test Lab (no cost), or do the testing myself or by one of my peers.

[ghost]

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.