Add tags argument to resource/aws_elasticache_parameter_group #19551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
github-actions
bot
added
needs-triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome @pall-valmundsson 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
ewbankkit
removed
the
needs-triage
ewbankkit
approved these changes
May 27, 2021
There was a problem hiding this comment.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheParameterGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheParameterGroup_ -timeout 180m
=== RUN TestAccAWSElasticacheParameterGroup_basic
=== PAUSE TestAccAWSElasticacheParameterGroup_basic
=== RUN TestAccAWSElasticacheParameterGroup_addParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_addParameter
=== RUN TestAccAWSElasticacheParameterGroup_removeAllParameters
=== PAUSE TestAccAWSElasticacheParameterGroup_removeAllParameters
=== RUN TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_AllParameters
=== PAUSE TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_AllParameters
=== RUN TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_RemainingParameters
=== PAUSE TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_RemainingParameters
=== RUN TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
=== RUN TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== RUN TestAccAWSElasticacheParameterGroup_UppercaseName
=== PAUSE TestAccAWSElasticacheParameterGroup_UppercaseName
=== RUN TestAccAWSElasticacheParameterGroup_Description
=== PAUSE TestAccAWSElasticacheParameterGroup_Description
=== RUN TestAccAWSElasticacheParameterGroup_Tags
=== PAUSE TestAccAWSElasticacheParameterGroup_Tags
=== CONT TestAccAWSElasticacheParameterGroup_basic
=== CONT TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== CONT TestAccAWSElasticacheParameterGroup_Tags
=== CONT TestAccAWSElasticacheParameterGroup_addParameter
=== CONT TestAccAWSElasticacheParameterGroup_removeAllParameters
=== CONT TestAccAWSElasticacheParameterGroup_Description
=== CONT TestAccAWSElasticacheParameterGroup_UppercaseName
=== CONT TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
=== CONT TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_AllParameters
=== CONT TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_RemainingParameters
--- PASS: TestAccAWSElasticacheParameterGroup_basic (29.99s)
--- PASS: TestAccAWSElasticacheParameterGroup_Description (30.97s)
--- PASS: TestAccAWSElasticacheParameterGroup_UppercaseName (31.10s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeAllParameters (45.34s)
--- PASS: TestAccAWSElasticacheParameterGroup_addParameter (48.16s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_AllParameters (49.89s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_RemainingParameters (49.98s)
--- PASS: TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter (50.02s)
--- PASS: TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter (50.03s)
--- PASS: TestAccAWSElasticacheParameterGroup_Tags (63.01s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 66.295sGovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSElasticacheParameterGroup_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSElasticacheParameterGroup_ -timeout 180m
=== RUN TestAccAWSElasticacheParameterGroup_basic
=== PAUSE TestAccAWSElasticacheParameterGroup_basic
=== RUN TestAccAWSElasticacheParameterGroup_addParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_addParameter
=== RUN TestAccAWSElasticacheParameterGroup_removeAllParameters
=== PAUSE TestAccAWSElasticacheParameterGroup_removeAllParameters
=== RUN TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_AllParameters
=== PAUSE TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_AllParameters
=== RUN TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_RemainingParameters
=== PAUSE TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_RemainingParameters
=== RUN TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
=== RUN TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== PAUSE TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== RUN TestAccAWSElasticacheParameterGroup_UppercaseName
=== PAUSE TestAccAWSElasticacheParameterGroup_UppercaseName
=== RUN TestAccAWSElasticacheParameterGroup_Description
=== PAUSE TestAccAWSElasticacheParameterGroup_Description
=== RUN TestAccAWSElasticacheParameterGroup_Tags
=== PAUSE TestAccAWSElasticacheParameterGroup_Tags
=== CONT TestAccAWSElasticacheParameterGroup_basic
=== CONT TestAccAWSElasticacheParameterGroup_UppercaseName
=== CONT TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_RemainingParameters
=== CONT TestAccAWSElasticacheParameterGroup_addParameter
=== CONT TestAccAWSElasticacheParameterGroup_removeAllParameters
=== CONT TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter
=== CONT TestAccAWSElasticacheParameterGroup_Tags
=== CONT TestAccAWSElasticacheParameterGroup_Description
=== CONT TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_AllParameters
=== CONT TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter
--- PASS: TestAccAWSElasticacheParameterGroup_Description (28.78s)
--- PASS: TestAccAWSElasticacheParameterGroup_basic (29.57s)
--- PASS: TestAccAWSElasticacheParameterGroup_UppercaseName (29.83s)
--- PASS: TestAccAWSElasticacheParameterGroup_addParameter (43.50s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeAllParameters (43.79s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_AllParameters (44.79s)
--- PASS: TestAccAWSElasticacheParameterGroup_updateReservedMemoryParameter (44.93s)
--- PASS: TestAccAWSElasticacheParameterGroup_switchReservedMemoryParameter (46.46s)
--- PASS: TestAccAWSElasticacheParameterGroup_removeReservedMemoryParameter_RemainingParameters (46.88s)
--- PASS: TestAccAWSElasticacheParameterGroup_Tags (61.55s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 65.095s
|
@pall-valmundsson Thanks for the contribution 🎉 👏. |
|
Thank you for an incredibly fast turnaround! |
|
This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Closes #19550
Output from acceptance testing: