ds/servicecatalog_launch_paths: New data source

[YakDriver]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

#19459 depends on this

Acceptance testing requires a non-assumed role. See #19958

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSServiceCatalogLaunchPathsDataSource_basic (75.66s)

References:

• servicecatalog.PrincipalARN contains principal's unique ID, not ARN aws/aws-sdk-go#3920
• https://stackoverflow.com/a/67713362/2121526

[bill-rich]

I'm getting the following when I run the acceptance test

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogLaunchPathsDataSource_basic -timeout 180m
go: downloading github.com/aws/aws-sdk-go v1.38.65
=== RUN   TestAccAWSServiceCatalogLaunchPathsDataSource_basic
=== PAUSE TestAccAWSServiceCatalogLaunchPathsDataSource_basic
=== CONT  TestAccAWSServiceCatalogLaunchPathsDataSource_basic
    data_source_aws_servicecatalog_launch_paths_test.go:18: Step 1/1 error: Error running apply: exit status 1
        
        Error: error associating Service Catalog Principal with Portfolio: InvalidParametersException: Invalid parameter principalArn, assumed-role is not a recognized IAM identity type
        
          on terraform_plugin_test.tf line 80, in resource "aws_servicecatalog_principal_portfolio_association" "test":
          80: resource "aws_servicecatalog_principal_portfolio_association" "test" {
        
        
--- FAIL: TestAccAWSServiceCatalogLaunchPathsDataSource_basic (114.90s)
FAIL
FAIL	github.com/terraform-providers/terraform-provider-aws/aws	114.959s
FAIL
make: *** [GNUmakefile:28: testacc] Error 1

Question on acc test

[YakDriver]

@bill-rich You can't use an assumed role when running the test. See #19958. If you run in GovCloud or where you have non-temporary credentials, it will work for you.

[bill-rich]

LGTM

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSServiceCatalogLaunchPathsDataSource_basic -timeout 180m
=== RUN   TestAccAWSServiceCatalogLaunchPathsDataSource_basic
=== PAUSE TestAccAWSServiceCatalogLaunchPathsDataSource_basic
=== CONT  TestAccAWSServiceCatalogLaunchPathsDataSource_basic
--- PASS: TestAccAWSServiceCatalogLaunchPathsDataSource_basic (135.49s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	135.546s

[github-actions]

This functionality has been released in v3.48.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.