F data source aws appmesh mesh create

[philnichol]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17590

Output from acceptance testing:

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSAppmeshMeshDataSource_ -timeout=30m
=== RUN   TestAccAWSAppmeshMeshDataSource_basic
=== PAUSE TestAccAWSAppmeshMeshDataSource_basic
=== RUN   TestAccAWSAppmeshMeshDataSource_meshOwner
=== PAUSE TestAccAWSAppmeshMeshDataSource_meshOwner
=== RUN   TestAccAWSAppmeshMeshDataSource_specAndTagsSet
=== PAUSE TestAccAWSAppmeshMeshDataSource_specAndTagsSet
=== RUN   TestAccAWSAppmeshMeshDataSource_nonExistent
=== PAUSE TestAccAWSAppmeshMeshDataSource_nonExistent
=== CONT  TestAccAWSAppmeshMeshDataSource_basic
=== CONT  TestAccAWSAppmeshMeshDataSource_nonExistent
=== CONT  TestAccAWSAppmeshMeshDataSource_meshOwner
=== CONT  TestAccAWSAppmeshMeshDataSource_specAndTagsSet
--- PASS: TestAccAWSAppmeshMeshDataSource_nonExistent (3.52s)
--- PASS: TestAccAWSAppmeshMeshDataSource_basic (12.84s)
--- PASS: TestAccAWSAppmeshMeshDataSource_specAndTagsSet (14.62s)
--- PASS: TestAccAWSAppmeshMeshDataSource_meshOwner (14.67s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.147s
$ make lint
$ make fmt
==> Fixing source code with gofmt...
gofmt -s -w ./aws ./awsproviderlint/helper ./awsproviderlint/main.go ./awsproviderlint/passes

Thanks in advance for your review!
Wasn't sure if I was meant to include the change to provider.go, so let me know if you want this removed.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmeshMeshDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmeshMeshDataSource_ -timeout 180m
=== RUN   TestAccAWSAppmeshMeshDataSource_basic
=== PAUSE TestAccAWSAppmeshMeshDataSource_basic
=== RUN   TestAccAWSAppmeshMeshDataSource_meshOwner
=== PAUSE TestAccAWSAppmeshMeshDataSource_meshOwner
=== RUN   TestAccAWSAppmeshMeshDataSource_specAndTagsSet
=== PAUSE TestAccAWSAppmeshMeshDataSource_specAndTagsSet
=== CONT  TestAccAWSAppmeshMeshDataSource_basic
=== CONT  TestAccAWSAppmeshMeshDataSource_specAndTagsSet
=== CONT  TestAccAWSAppmeshMeshDataSource_meshOwner
--- PASS: TestAccAWSAppmeshMeshDataSource_basic (14.57s)
--- PASS: TestAccAWSAppmeshMeshDataSource_meshOwner (14.59s)
--- PASS: TestAccAWSAppmeshMeshDataSource_specAndTagsSet (14.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	17.477s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSAppmeshMeshDataSource_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAppmeshMeshDataSource_ -timeout 180m
=== RUN   TestAccAWSAppmeshMeshDataSource_basic
=== PAUSE TestAccAWSAppmeshMeshDataSource_basic
=== RUN   TestAccAWSAppmeshMeshDataSource_meshOwner
=== PAUSE TestAccAWSAppmeshMeshDataSource_meshOwner
=== RUN   TestAccAWSAppmeshMeshDataSource_specAndTagsSet
=== PAUSE TestAccAWSAppmeshMeshDataSource_specAndTagsSet
=== CONT  TestAccAWSAppmeshMeshDataSource_basic
=== CONT  TestAccAWSAppmeshMeshDataSource_specAndTagsSet
=== CONT  TestAccAWSAppmeshMeshDataSource_meshOwner
=== CONT  TestAccAWSAppmeshMeshDataSource_specAndTagsSet
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccAWSAppmeshMeshDataSource_specAndTagsSet (1.40s)
=== CONT  TestAccAWSAppmeshMeshDataSource_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
=== CONT  TestAccAWSAppmeshMeshDataSource_meshOwner
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccAWSAppmeshMeshDataSource_basic (1.40s)
--- SKIP: TestAccAWSAppmeshMeshDataSource_meshOwner (1.40s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.334s

[ewbankkit]

@philnichol Thanks for the contribution 🎉 👏.
I pushed a couple of minor changes to get this merged quickly:

• Added PreCheck and ErrorCheck to the acceptance tests to correctly handle AWS GovCloud
• Removed Optional: true from the spec attribute as it is not an input argument

[philnichol]

@ewbankkit thanks for the review and feedback! Will keep those in mind for future changes.

[github-actions]

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.