Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws_ecs_service -> launch_type needs to have EXTERNAL added #19586

Closed
nicwise opened this issue May 30, 2021 · 2 comments
Closed

aws_ecs_service -> launch_type needs to have EXTERNAL added #19586

nicwise opened this issue May 30, 2021 · 2 comments
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.

Comments

@nicwise
Copy link
Contributor

nicwise commented May 30, 2021

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

With the launch of ECS Anywhere, there is a new launch_type - EXTERNAL as well as EC2 and FARGATE. This is missing from either Terraform/AWS or the AWS API.

New or Affected Resource(s)

  • aws_ecs_service

Potential Terraform Configuration

resource "aws_ecs_service" "external_ups" {
  name    = "foo"

  cluster              = aws_ecs_cluster.cluster.id
  task_definition = "..."

  launch_type = "EXTERNAL" <------

  scheduling_strategy = "DAEMON"

}

Note that the task definition may also need EXTERNAL in it's requiresCompatibilities key

{
	"requiresCompatibilities": [
		"EXTERNAL"
	],

References

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/launch_types.html

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-anywhere.html

Amazon ECS capacity providers aren't supported. To create a service or run a standalone task on your external instances, use the EXTERNAL launch type.

https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-anywhere-runtask.html

@nicwise nicwise added the enhancement Requests to existing resources that expand the functionality or scope. label May 30, 2021
@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. service/ecs Issues and PRs that pertain to the ecs service. labels May 30, 2021
@gdavison gdavison removed the needs-triage Waiting for first response or review from a maintainer. label May 31, 2021
@gdavison
Copy link
Contributor

Thanks for raising this, @nicwise. We've merged #19557 to address this and expect to release it soon.

@github-actions
Copy link

github-actions bot commented Jul 1, 2021

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope. service/ecs Issues and PRs that pertain to the ecs service.
Projects
None yet
Development

No branches or pull requests

2 participants