Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/aws_cloudwatch_event_api_destination: Maximum value for invocation_rate_limit_per_second is 300 #19594

Merged

Conversation

ewbankkit
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #18905.

When building the Terraform AWS Provider for 32-bit platforms we get this error:

aws/resource_aws_cloudwatch_event_api_destination.go:47:41: constant 9223372036854775807 overflows int

This is caused by an incorrect maximum value for the invocation_rate_limit_per_second argument, which should be 300:

Screenshot 2021-05-31 080407

This PR corrects the maximum value allowed for this argument.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSCloudWatchEventApiDestination_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCloudWatchEventApiDestination_ -timeout 180m
=== RUN   TestAccAWSCloudWatchEventApiDestination_basic
=== PAUSE TestAccAWSCloudWatchEventApiDestination_basic
=== RUN   TestAccAWSCloudWatchEventApiDestination_optional
=== PAUSE TestAccAWSCloudWatchEventApiDestination_optional
=== RUN   TestAccAWSCloudWatchEventApiDestination_disappears
=== PAUSE TestAccAWSCloudWatchEventApiDestination_disappears
=== CONT  TestAccAWSCloudWatchEventApiDestination_basic
=== CONT  TestAccAWSCloudWatchEventApiDestination_disappears
=== CONT  TestAccAWSCloudWatchEventApiDestination_optional
--- PASS: TestAccAWSCloudWatchEventApiDestination_disappears (18.57s)
--- PASS: TestAccAWSCloudWatchEventApiDestination_optional (45.04s)
--- PASS: TestAccAWSCloudWatchEventApiDestination_basic (46.39s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	46.511s

@ewbankkit ewbankkit requested a review from a team as a code owner May 31, 2021 12:17
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. labels May 31, 2021
Copy link
Member

@breathingdust breathingdust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@ewbankkit ewbankkit merged commit 5ca2e9d into main Jun 1, 2021
@ewbankkit ewbankkit deleted the b-aws_cloudwatch_event_api_destination-32-bit-int-overflow branch June 1, 2021 15:17
@github-actions github-actions bot added this to the v3.43.0 milestone Jun 1, 2021
github-actions bot pushed a commit that referenced this pull request Jun 1, 2021
@ghost
Copy link

ghost commented Jun 1, 2021

This has been released in version 3.43.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 3, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants