Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix default status for aws_iam_access_key #19606

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

ZeePal
Copy link
Contributor

@ZeePal ZeePal commented Jun 1, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19605

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAccessKey'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSAccessKey -timeout 180m
=== RUN   TestAccAWSAccessKey_basic
=== PAUSE TestAccAWSAccessKey_basic
=== RUN   TestAccAWSAccessKey_encrypted
=== PAUSE TestAccAWSAccessKey_encrypted
=== RUN   TestAccAWSAccessKey_Status
=== PAUSE TestAccAWSAccessKey_Status
=== CONT  TestAccAWSAccessKey_basic
=== CONT  TestAccAWSAccessKey_Status
=== CONT  TestAccAWSAccessKey_encrypted
--- PASS: TestAccAWSAccessKey_encrypted (41.92s)
--- PASS: TestAccAWSAccessKey_basic (42.17s)
--- PASS: TestAccAWSAccessKey_Status (98.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	98.869s
...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. labels Jun 1, 2021
@github-actions github-actions bot added service/iam Issues and PRs that pertain to the iam service. needs-triage Waiting for first response or review from a maintainer. labels Jun 1, 2021
@ZeePal ZeePal force-pushed the b-aws_iam_access_key-defaultstatus branch from cdec9d4 to bfcc8c1 Compare June 1, 2021 08:38
@ZeePal ZeePal marked this pull request as ready for review June 1, 2021 08:41
@ZeePal ZeePal requested a review from a team as a code owner June 1, 2021 08:41
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @ZeePal 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@gdavison gdavison self-assigned this Jun 1, 2021
Copy link
Contributor

@gdavison gdavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🚀

--- PASS: TestAccAWSAccessKey_basic (68.99s)
--- PASS: TestAccAWSAccessKey_encrypted (71.24s)
--- PASS: TestAccAWSAccessKey_Status (156.06s)

@gdavison gdavison merged commit 400a0af into hashicorp:main Jun 1, 2021
@github-actions github-actions bot added this to the v3.44.0 milestone Jun 1, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
@breathingdust breathingdust removed the needs-triage Waiting for first response or review from a maintainer. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/iam Issues and PRs that pertain to the iam service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

By default aws_iam_access_key's status isn't corrected to Active
3 participants