Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/elasticache_cluster: add SetTagsDiff function to CustomizeDiff sequence #19615

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

anGie44
Copy link
Contributor

@anGie44 anGie44 commented Jun 1, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19614

Output from acceptance testing (Commercial):

--- SKIP: TestAccAWSElasticacheCluster_SecurityGroup_Ec2Classic (2.08s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Redis (13.19s)
--- PASS: TestAccAWSElasticacheCluster_Port_Redis_Default (498.22s)
--- PASS: TestAccAWSElasticacheCluster_Memcached_FinalSnapshot (2.71s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Redis (624.22s)
--- PASS: TestAccAWSElasticacheCluster_AZMode_Memcached (632.30s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Redis (652.45s)
--- PASS: TestAccAWSElasticacheCluster_Port (652.73s)
--- PASS: TestAccAWSElasticacheCluster_Engine_Memcached (654.06s)
--- PASS: TestAccAWSElasticacheCluster_multiAZInVpc (654.42s)
--- PASS: TestAccAWSElasticacheCluster_vpc (655.63s)
--- PASS: TestAccAWSElasticacheCluster_ParameterGroupName_Default (673.70s)
--- PASS: TestAccAWSElasticacheCluster_snapshotsWithUpdates (689.04s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Decrease (865.83s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_IncreaseWithPreferredAvailabilityZones (1095.04s)
--- PASS: TestAccAWSElasticacheCluster_NumCacheNodes_Increase (1132.08s)
--- PASS: TestAccAWSElasticacheCluster_Redis_FinalSnapshot (778.00s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Memcached (1283.16s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_AvailabilityZone (1384.90s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_SingleReplica (1403.37s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Memcached (1406.74s)
--- PASS: TestAccAWSElasticacheCluster_ReplicationGroupID_MultipleReplica (1405.37s)
--- PASS: TestAccAWSElasticacheCluster_NodeTypeResize_Redis (1423.06s)
--- PASS: TestAccAWSElasticacheCluster_EngineVersion_Redis (2106.66s)

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. labels Jun 1, 2021
@github-actions github-actions bot added the service/elasticache Issues and PRs that pertain to the elasticache service. label Jun 1, 2021
@anGie44 anGie44 force-pushed the b-elasticache-cluster-default-tags-customize-diff branch from 535df85 to 3d54dbc Compare June 1, 2021 17:39
@anGie44 anGie44 marked this pull request as ready for review June 1, 2021 17:40
@anGie44 anGie44 requested a review from a team as a code owner June 1, 2021 17:40
@anGie44 anGie44 added the bug Addresses a defect in current functionality. label Jun 1, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

@anGie44 anGie44 added this to the v3.44.0 milestone Jun 1, 2021
@anGie44 anGie44 merged commit 292a0ca into main Jun 1, 2021
@anGie44 anGie44 deleted the b-elasticache-cluster-default-tags-customize-diff branch June 1, 2021 20:45
github-actions bot pushed a commit that referenced this pull request Jun 1, 2021
@ghost
Copy link

ghost commented Jun 3, 2021

This has been released in version 3.44.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@github-actions
Copy link

github-actions bot commented Jul 4, 2021

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tags not changing on aws_elasticache_cluster resource when using default_tags at provider level
2 participants