Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F/aws acmpca certificate authority #19681

Merged

Conversation

nikhil-goenka
Copy link
Contributor

@nikhil-goenka nikhil-goenka commented Jun 5, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19676

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl'
=== RUN   TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
=== PAUSE TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
=== CONT  TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl (72.59s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	76.652s
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner June 5, 2021 05:31
@ghost ghost added size/M Managed by automation to categorize the size of a PR. labels Jun 5, 2021
@github-actions github-actions bot added documentation Introduces or discusses updates to documentation. service/acmpca Issues and PRs that pertain to the acmpca service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. needs-triage Waiting for first response or review from a maintainer. labels Jun 5, 2021
@ewbankkit ewbankkit added bug Addresses a defect in current functionality. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. and removed needs-triage Waiting for first response or review from a maintainer. labels Jun 7, 2021
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsAcmpcaCertificateAuthority_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAcmpcaCertificateAuthority_ -timeout 180m
=== RUN   TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
=== PAUSE TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
=== RUN   TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
=== PAUSE TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
=== CONT  TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
=== CONT  TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_basic (24.50s)
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl (24.57s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	28.178s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAwsAcmpcaCertificateAuthority_' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAwsAcmpcaCertificateAuthority_ -timeout 180m
=== RUN   TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
=== PAUSE TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
=== RUN   TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
=== PAUSE TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
=== CONT  TestAccDataSourceAwsAcmpcaCertificateAuthority_basic
=== CONT  TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_basic (24.75s)
--- PASS: TestAccDataSourceAwsAcmpcaCertificateAuthority_S3ObjectAcl (24.80s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	28.077s

@ewbankkit ewbankkit merged commit 1048fbc into hashicorp:main Jun 7, 2021
@github-actions github-actions bot added this to the v3.45.0 milestone Jun 7, 2021
@github-actions
Copy link

This functionality has been released in v3.45.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2021
@nikhil-goenka nikhil-goenka deleted the f/aws_acmpca_certificate_authority branch July 15, 2021 03:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. documentation Introduces or discusses updates to documentation. regression Pertains to a degraded workflow resulting from an upstream patch or internal enhancement. service/acmpca Issues and PRs that pertain to the acmpca service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data source aws_acmpca_certificate_authority errors with error setting tags: Invalid address to set
2 participants