Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/glue_catalog_table - fix update for schema_reference #19742

Merged
merged 3 commits into from
Jun 22, 2021
Merged

r/glue_catalog_table - fix update for schema_reference #19742

merged 3 commits into from
Jun 22, 2021

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Jun 9, 2021 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #19739

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSGlueCatalogTable_'
--- PASS: TestAccAWSGlueCatalogTable_disappears_database (37.61s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (42.69s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (42.83s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (44.73s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (45.53s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (48.85s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (49.78s)
--- PASS: TestAccAWSGlueCatalogTable_basic (50.49s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (51.91s)
--- PASS: TestAccAWSGlueCatalogTable_full (54.68s)
--- PASS: TestAccAWSGlueCatalogTable_targetTable (55.98s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn (63.22s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (78.49s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (80.36s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (80.36s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference (105.18s)

@DrFaust92 DrFaust92 requested a review from a team as a code owner June 9, 2021 22:26
@github-actions github-actions bot added service/glue Issues and PRs that pertain to the glue service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/XS Managed by automation to categorize the size of a PR. labels Jun 9, 2021
@DrFaust92 DrFaust92 added the bug Addresses a defect in current functionality. label Jun 9, 2021
@DrFaust92 DrFaust92 marked this pull request as draft June 9, 2021 22:27
@DrFaust92 DrFaust92 changed the title r/glue_catalog_table - unset columns when updating with schema_reference r/glue_catalog_table - fix update for schema_reference Jun 9, 2021
@DrFaust92 DrFaust92 marked this pull request as ready for review June 9, 2021 22:31
@DrFaust92 DrFaust92 mentioned this pull request Jun 9, 2021
Closed
ewbankkit
ewbankkit approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogTable_'   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 180m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_columnParameters
=== PAUSE TestAccAWSGlueCatalogTable_columnParameters
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears_database
=== PAUSE TestAccAWSGlueCatalogTable_disappears_database
=== RUN   TestAccAWSGlueCatalogTable_targetTable
=== PAUSE TestAccAWSGlueCatalogTable_targetTable
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_targetTable
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_disappears_database
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== CONT  TestAccAWSGlueCatalogTable_columnParameters
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
--- PASS: TestAccAWSGlueCatalogTable_disappears_database (28.20s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (30.61s)
--- PASS: TestAccAWSGlueCatalogTable_basic (31.93s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (32.39s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (32.56s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (32.74s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (34.41s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (35.42s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (35.89s)
--- PASS: TestAccAWSGlueCatalogTable_full (35.90s)
--- PASS: TestAccAWSGlueCatalogTable_targetTable (37.40s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn (39.92s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (48.11s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (49.65s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (50.02s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference (57.07s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	60.272s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSGlueCatalogTable_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSGlueCatalogTable_ -timeout 180m
=== RUN   TestAccAWSGlueCatalogTable_basic
=== PAUSE TestAccAWSGlueCatalogTable_basic
=== RUN   TestAccAWSGlueCatalogTable_columnParameters
=== PAUSE TestAccAWSGlueCatalogTable_columnParameters
=== RUN   TestAccAWSGlueCatalogTable_full
=== PAUSE TestAccAWSGlueCatalogTable_full
=== RUN   TestAccAWSGlueCatalogTable_update_addValues
=== PAUSE TestAccAWSGlueCatalogTable_update_addValues
=== RUN   TestAccAWSGlueCatalogTable_update_replaceValues
=== PAUSE TestAccAWSGlueCatalogTable_update_replaceValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== RUN   TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== PAUSE TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== RUN   TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== PAUSE TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== RUN   TestAccAWSGlueCatalogTable_disappears_database
=== PAUSE TestAccAWSGlueCatalogTable_disappears_database
=== RUN   TestAccAWSGlueCatalogTable_targetTable
=== PAUSE TestAccAWSGlueCatalogTable_targetTable
=== RUN   TestAccAWSGlueCatalogTable_disappears
=== PAUSE TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_basic
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
=== CONT  TestAccAWSGlueCatalogTable_disappears
=== CONT  TestAccAWSGlueCatalogTable_targetTable
=== CONT  TestAccAWSGlueCatalogTable_disappears_database
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesMultiple
=== CONT  TestAccAWSGlueCatalogTable_update_replaceValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
=== CONT  TestAccAWSGlueCatalogTable_partitionIndexesSingle
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock
=== CONT  TestAccAWSGlueCatalogTable_update_addValues
=== CONT  TestAccAWSGlueCatalogTable_full
=== CONT  TestAccAWSGlueCatalogTable_columnParameters
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/22 12:11:14 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Glue Registry: AccessDeniedException: Operation not allowed
        
          on terraform_plugin_test.tf line 6, in resource "aws_glue_registry" "test":
           6: resource "aws_glue_registry" "test" {
        
        
=== CONT  TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference
    provider_test.go:1103: skipping test for aws-us-gov/us-gov-west-1: Error running apply: exit status 1
        2021/06/22 12:11:14 [DEBUG] Using modified User-Agent: Terraform/0.12.31 HashiCorp-terraform-exec/0.13.3
        
        Error: error creating Glue Registry: AccessDeniedException: Operation not allowed
        
          on terraform_plugin_test.tf line 6, in resource "aws_glue_registry" "test":
           6: resource "aws_glue_registry" "test" {
        
        
--- SKIP: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReference (15.12s)
--- SKIP: TestAccAWSGlueCatalogTable_StorageDescriptor_schemaReferenceArn (15.17s)
--- PASS: TestAccAWSGlueCatalogTable_disappears_database (24.43s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_EmptyConfigurationBlock (27.61s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_EmptyConfigurationBlock (28.19s)
--- PASS: TestAccAWSGlueCatalogTable_disappears (28.54s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SkewedInfo_EmptyConfigurationBlock (29.90s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesSingle (30.42s)
--- PASS: TestAccAWSGlueCatalogTable_basic (31.58s)
--- PASS: TestAccAWSGlueCatalogTable_full (32.78s)
--- PASS: TestAccAWSGlueCatalogTable_columnParameters (32.95s)
--- PASS: TestAccAWSGlueCatalogTable_partitionIndexesMultiple (33.03s)
--- PASS: TestAccAWSGlueCatalogTable_targetTable (34.20s)
--- PASS: TestAccAWSGlueCatalogTable_update_replaceValues (44.93s)
--- PASS: TestAccAWSGlueCatalogTable_StorageDescriptor_SerDeInfo_UpdateValues (46.30s)
--- PASS: TestAccAWSGlueCatalogTable_update_addValues (46.99s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	50.895s

@ewbankkit ewbankkit merged commit 49fd2ae into hashicorp:main Jun 22, 2021
@github-actions github-actions bot added this to the v3.47.0 milestone Jun 22, 2021
@DrFaust92 DrFaust92 deleted the r/glue_table_schema_colums branch June 22, 2021 19:03
@github-actions
Copy link

This functionality has been released in v3.47.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
bug Addresses a defect in current functionality. service/glue Issues and PRs that pertain to the glue service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.47.0
Development

Successfully merging this pull request may close these issues.

aws_glue_catalog_table fails modification due to implicit column values
2 participants
@DrFaust92 @ewbankkit