F data source aws appmesh virtualservice

[philnichol]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #17590

Output from acceptance testing:

$ TF_ACC=1 go test ./aws -v -count 1 -parallel 10 -run=TestAccAWSAppmeshVirtualServiceDataSource_ -timeout=30m
=== RUN   TestAccAWSAppmeshVirtualServiceDataSource_virtualNode
=== PAUSE TestAccAWSAppmeshVirtualServiceDataSource_virtualNode
=== RUN   TestAccAWSAppmeshVirtualServiceDataSource_virtualRouter
=== PAUSE TestAccAWSAppmeshVirtualServiceDataSource_virtualRouter
=== CONT  TestAccAWSAppmeshVirtualServiceDataSource_virtualNode
=== CONT  TestAccAWSAppmeshVirtualServiceDataSource_virtualRouter
--- PASS: TestAccAWSAppmeshVirtualServiceDataSource_virtualNode (15.69s)
--- PASS: TestAccAWSAppmeshVirtualServiceDataSource_virtualRouter (16.83s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	19.608s

Thanks in advance for the review!

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSAppmesh'   
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSAppmesh -timeout 180m
=== RUN   TestAccDataSourceAWSAppmeshMesh_basic
=== PAUSE TestAccDataSourceAWSAppmeshMesh_basic
=== RUN   TestAccDataSourceAWSAppmeshMesh_meshOwner
=== PAUSE TestAccDataSourceAWSAppmeshMesh_meshOwner
=== RUN   TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== PAUSE TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== RUN   TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== PAUSE TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== RUN   TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== PAUSE TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== CONT  TestAccDataSourceAWSAppmeshMesh_basic
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== CONT  TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== CONT  TestAccDataSourceAWSAppmeshMesh_meshOwner
--- PASS: TestAccDataSourceAWSAppmeshMesh_basic (15.74s)
--- PASS: TestAccDataSourceAWSAppmeshMesh_meshOwner (15.76s)
--- PASS: TestAccDataSourceAWSAppmeshMesh_specAndTagsSet (15.94s)
--- PASS: TestAccDataSourceAWSAppmeshVirtualService_virtualRouter (20.17s)
--- PASS: TestAccDataSourceAWSAppmeshVirtualService_virtualNode (21.00s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	24.400s

GovCloud

% make testacc TEST=./aws TESTARGS='-run=TestAccDataSourceAWSAppmesh' 
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccDataSourceAWSAppmesh -timeout 180m
=== RUN   TestAccDataSourceAWSAppmeshMesh_basic
=== PAUSE TestAccDataSourceAWSAppmeshMesh_basic
=== RUN   TestAccDataSourceAWSAppmeshMesh_meshOwner
=== PAUSE TestAccDataSourceAWSAppmeshMesh_meshOwner
=== RUN   TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== PAUSE TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== RUN   TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== PAUSE TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== RUN   TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== PAUSE TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== CONT  TestAccDataSourceAWSAppmeshMesh_basic
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualNode
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
=== CONT  TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
=== CONT  TestAccDataSourceAWSAppmeshMesh_meshOwner
=== CONT  TestAccDataSourceAWSAppmeshMesh_basic
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshMesh_basic (1.41s)
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualNode
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshVirtualService_virtualNode (1.41s)
=== CONT  TestAccDataSourceAWSAppmeshVirtualService_virtualRouter
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshVirtualService_virtualRouter (1.41s)
=== CONT  TestAccDataSourceAWSAppmeshMesh_specAndTagsSet
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshMesh_specAndTagsSet (1.41s)
=== CONT  TestAccDataSourceAWSAppmeshMesh_meshOwner
    provider_test.go:734: skipping tests; partition aws-us-gov does not support appmesh service
--- SKIP: TestAccDataSourceAWSAppmeshMesh_meshOwner (1.41s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	4.685s

[ewbankkit]

@philnichol Thanks for the contribution 🎉 👏.
All looks great.
I tweaked the acceptance tests names slightly (#17847).

[github-actions]

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.