-
Notifications
You must be signed in to change notification settings - Fork 9.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/ecs _cluster - add configuration
block + refactor to user finder and waiters package
#19785
Conversation
Co-authored-by: Kit Ewbank <Kit_Ewbank@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsCluster_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsCluster_ -timeout 180m
=== RUN TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== RUN TestAccAWSEcsCluster_disappears
=== PAUSE TestAccAWSEcsCluster_disappears
=== RUN TestAccAWSEcsCluster_Tags
=== PAUSE TestAccAWSEcsCluster_Tags
=== RUN TestAccAWSEcsCluster_SingleCapacityProvider
=== PAUSE TestAccAWSEcsCluster_SingleCapacityProvider
=== RUN TestAccAWSEcsCluster_CapacityProviders
=== PAUSE TestAccAWSEcsCluster_CapacityProviders
=== RUN TestAccAWSEcsCluster_CapacityProvidersUpdate
=== PAUSE TestAccAWSEcsCluster_CapacityProvidersUpdate
=== RUN TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== PAUSE TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== RUN TestAccAWSEcsCluster_containerInsights
=== PAUSE TestAccAWSEcsCluster_containerInsights
=== RUN TestAccAWSEcsCluster_configuration
=== PAUSE TestAccAWSEcsCluster_configuration
=== CONT TestAccAWSEcsCluster_basic
=== CONT TestAccAWSEcsCluster_CapacityProvidersUpdate
=== CONT TestAccAWSEcsCluster_SingleCapacityProvider
=== CONT TestAccAWSEcsCluster_CapacityProviders
=== CONT TestAccAWSEcsCluster_configuration
=== CONT TestAccAWSEcsCluster_containerInsights
=== CONT TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== CONT TestAccAWSEcsCluster_disappears
=== CONT TestAccAWSEcsCluster_Tags
--- PASS: TestAccAWSEcsCluster_disappears (24.45s)
--- PASS: TestAccAWSEcsCluster_basic (27.26s)
--- PASS: TestAccAWSEcsCluster_Tags (46.39s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (49.02s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (53.20s)
--- PASS: TestAccAWSEcsCluster_configuration (53.92s)
--- PASS: TestAccAWSEcsCluster_containerInsights (63.10s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (81.81s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (97.50s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 100.935s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEcsCluster_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEcsCluster_ -timeout 180m
=== RUN TestAccAWSEcsCluster_basic
=== PAUSE TestAccAWSEcsCluster_basic
=== RUN TestAccAWSEcsCluster_disappears
=== PAUSE TestAccAWSEcsCluster_disappears
=== RUN TestAccAWSEcsCluster_Tags
=== PAUSE TestAccAWSEcsCluster_Tags
=== RUN TestAccAWSEcsCluster_SingleCapacityProvider
=== PAUSE TestAccAWSEcsCluster_SingleCapacityProvider
=== RUN TestAccAWSEcsCluster_CapacityProviders
=== PAUSE TestAccAWSEcsCluster_CapacityProviders
=== RUN TestAccAWSEcsCluster_CapacityProvidersUpdate
=== PAUSE TestAccAWSEcsCluster_CapacityProvidersUpdate
=== RUN TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== PAUSE TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== RUN TestAccAWSEcsCluster_containerInsights
=== PAUSE TestAccAWSEcsCluster_containerInsights
=== RUN TestAccAWSEcsCluster_configuration
=== PAUSE TestAccAWSEcsCluster_configuration
=== CONT TestAccAWSEcsCluster_basic
=== CONT TestAccAWSEcsCluster_CapacityProvidersUpdate
=== CONT TestAccAWSEcsCluster_Tags
=== CONT TestAccAWSEcsCluster_disappears
=== CONT TestAccAWSEcsCluster_containerInsights
=== CONT TestAccAWSEcsCluster_CapacityProvidersNoStrategy
=== CONT TestAccAWSEcsCluster_configuration
=== CONT TestAccAWSEcsCluster_CapacityProviders
=== CONT TestAccAWSEcsCluster_SingleCapacityProvider
--- PASS: TestAccAWSEcsCluster_disappears (28.08s)
--- PASS: TestAccAWSEcsCluster_basic (34.10s)
--- PASS: TestAccAWSEcsCluster_CapacityProviders (57.16s)
--- PASS: TestAccAWSEcsCluster_Tags (58.03s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersNoStrategy (59.41s)
--- PASS: TestAccAWSEcsCluster_configuration (61.74s)
--- PASS: TestAccAWSEcsCluster_containerInsights (76.23s)
--- PASS: TestAccAWSEcsCluster_CapacityProvidersUpdate (83.11s)
--- PASS: TestAccAWSEcsCluster_SingleCapacityProvider (101.99s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 105.047s
This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #18334.
Output from acceptance testing: