EKS node group scaling_config.min_size can be 0 as well as desired

[MRostanski]

As aws/containers-roadmap#724 (comment)

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates #13984

resource/aws_eks_node_group: Allow for 0 min_size and desired_size for scaling config of a node group.

[github-actions]

Welcome @MRostanski 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

[ewbankkit]

API Reference.

[ewbankkit]

@MRostanski Thanks for the contribution 🎉 👏.
I pushed a CHANGELOG entry file and added an acceptance test.

[ewbankkit]

LGTM 🚀.

Commercial

% make testacc TEST=./aws TESTARGS='-run=TestAccAWSEksNodeGroup_'                                      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSEksNodeGroup_ -timeout 180m
=== RUN   TestAccAWSEksNodeGroup_basic
=== PAUSE TestAccAWSEksNodeGroup_basic
=== RUN   TestAccAWSEksNodeGroup_Name_Generated
=== PAUSE TestAccAWSEksNodeGroup_Name_Generated
=== RUN   TestAccAWSEksNodeGroup_NamePrefix
=== PAUSE TestAccAWSEksNodeGroup_NamePrefix
=== RUN   TestAccAWSEksNodeGroup_disappears
=== PAUSE TestAccAWSEksNodeGroup_disappears
=== RUN   TestAccAWSEksNodeGroup_AmiType
=== PAUSE TestAccAWSEksNodeGroup_AmiType
=== RUN   TestAccAWSEksNodeGroup_CapacityType_Spot
=== PAUSE TestAccAWSEksNodeGroup_CapacityType_Spot
=== RUN   TestAccAWSEksNodeGroup_DiskSize
=== PAUSE TestAccAWSEksNodeGroup_DiskSize
=== RUN   TestAccAWSEksNodeGroup_ForceUpdateVersion
=== PAUSE TestAccAWSEksNodeGroup_ForceUpdateVersion
=== RUN   TestAccAWSEksNodeGroup_InstanceTypes_Multiple
=== PAUSE TestAccAWSEksNodeGroup_InstanceTypes_Multiple
=== RUN   TestAccAWSEksNodeGroup_InstanceTypes_Single
=== PAUSE TestAccAWSEksNodeGroup_InstanceTypes_Single
=== RUN   TestAccAWSEksNodeGroup_Labels
=== PAUSE TestAccAWSEksNodeGroup_Labels
=== RUN   TestAccAWSEksNodeGroup_LaunchTemplate_Id
=== PAUSE TestAccAWSEksNodeGroup_LaunchTemplate_Id
=== RUN   TestAccAWSEksNodeGroup_LaunchTemplate_Name
=== PAUSE TestAccAWSEksNodeGroup_LaunchTemplate_Name
=== RUN   TestAccAWSEksNodeGroup_LaunchTemplate_Version
=== PAUSE TestAccAWSEksNodeGroup_LaunchTemplate_Version
=== RUN   TestAccAWSEksNodeGroup_ReleaseVersion
=== PAUSE TestAccAWSEksNodeGroup_ReleaseVersion
=== RUN   TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey
=== PAUSE TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey
=== RUN   TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds
=== PAUSE TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds
=== RUN   TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize
=== PAUSE TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize
=== RUN   TestAccAWSEksNodeGroup_ScalingConfig_MaxSize
=== PAUSE TestAccAWSEksNodeGroup_ScalingConfig_MaxSize
=== RUN   TestAccAWSEksNodeGroup_ScalingConfig_MinSize
=== PAUSE TestAccAWSEksNodeGroup_ScalingConfig_MinSize
=== RUN   TestAccAWSEksNodeGroup_ScalingConfig_Zero_DesiredSize_MinSize
=== PAUSE TestAccAWSEksNodeGroup_ScalingConfig_Zero_DesiredSize_MinSize
=== RUN   TestAccAWSEksNodeGroup_Tags
=== PAUSE TestAccAWSEksNodeGroup_Tags
=== RUN   TestAccAWSEksNodeGroup_Taints
=== PAUSE TestAccAWSEksNodeGroup_Taints
=== RUN   TestAccAWSEksNodeGroup_Version
=== PAUSE TestAccAWSEksNodeGroup_Version
=== CONT  TestAccAWSEksNodeGroup_basic
=== CONT  TestAccAWSEksNodeGroup_LaunchTemplate_Version
=== CONT  TestAccAWSEksNodeGroup_Version
=== CONT  TestAccAWSEksNodeGroup_ReleaseVersion
=== CONT  TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize
=== CONT  TestAccAWSEksNodeGroup_ForceUpdateVersion
=== CONT  TestAccAWSEksNodeGroup_LaunchTemplate_Name
=== CONT  TestAccAWSEksNodeGroup_LaunchTemplate_Id
=== CONT  TestAccAWSEksNodeGroup_Labels
=== CONT  TestAccAWSEksNodeGroup_InstanceTypes_Single
=== CONT  TestAccAWSEksNodeGroup_InstanceTypes_Multiple
=== CONT  TestAccAWSEksNodeGroup_NamePrefix
=== CONT  TestAccAWSEksNodeGroup_ScalingConfig_MinSize
=== CONT  TestAccAWSEksNodeGroup_disappears
=== CONT  TestAccAWSEksNodeGroup_AmiType
=== CONT  TestAccAWSEksNodeGroup_DiskSize
=== CONT  TestAccAWSEksNodeGroup_ScalingConfig_MaxSize
=== CONT  TestAccAWSEksNodeGroup_CapacityType_Spot
=== CONT  TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey
=== CONT  TestAccAWSEksNodeGroup_Name_Generated
=== CONT  TestAccAWSEksNodeGroup_Version
--- PASS: TestAccAWSEksNodeGroup_Version (3788.64s)
=== CONT  TestAccAWSEksNodeGroup_Tags
=== CONT  TestAccAWSEksNodeGroup_ForceUpdateVersion
--- PASS: TestAccAWSEksNodeGroup_ForceUpdateVersion (3851.48s)
=== CONT  TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Multiple (1026.53s)
=== CONT  TestAccAWSEksNodeGroup_ScalingConfig_Zero_DesiredSize_MinSize
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_Ec2SshKey (1069.54s)
=== CONT  TestAccAWSEksNodeGroup_Taints
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Single (1073.42s)
--- PASS: TestAccAWSEksNodeGroup_Name_Generated (1078.76s)
--- PASS: TestAccAWSEksNodeGroup_basic (1086.98s)
--- PASS: TestAccAWSEksNodeGroup_disappears (1091.57s)
--- PASS: TestAccAWSEksNodeGroup_CapacityType_Spot (1097.75s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1111.68s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1060.49s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1136.55s)
--- PASS: TestAccAWSEksNodeGroup_NamePrefix (1216.80s)
--- PASS: TestAccAWSEksNodeGroup_DiskSize (1227.80s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1053.41s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1242.50s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1269.00s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Id (1411.06s)
--- PASS: TestAccAWSEksNodeGroup_AmiType (1447.82s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Name (1478.13s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Version (2138.93s)
--- PASS: TestAccAWSEksNodeGroup_Taints (1092.71s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_Zero_DesiredSize_MinSize (1205.66s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (3749.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	3855.073s

GovCloud

--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_Zero_DesiredSize_MinSize (799.89s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Multiple (1027.95s)
--- FAIL: TestAccAWSEksNodeGroup_LaunchTemplate_Version (1047.20s)
--- PASS: TestAccAWSEksNodeGroup_InstanceTypes_Single (1059.16s)
--- PASS: TestAccAWSEksNodeGroup_CapacityType_Spot (1007.91s)
--- FAIL: TestAccAWSEksNodeGroup_ScalingConfig_MaxSize (1089.03s)
--- PASS: TestAccAWSEksNodeGroup_RemoteAccess_SourceSecurityGroupIds (1090.82s)
--- SKIP: TestAccAWSEksNodeGroup_AmiType (1092.48s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_MinSize (1094.83s)
--- PASS: TestAccAWSEksNodeGroup_ScalingConfig_DesiredSize (1113.64s)
--- PASS: TestAccAWSEksNodeGroup_Tags (1119.80s)
--- PASS: TestAccAWSEksNodeGroup_Taints (1120.22s)
--- PASS: TestAccAWSEksNodeGroup_NamePrefix (1057.82s)
--- PASS: TestAccAWSEksNodeGroup_basic (1122.85s)
--- PASS: TestAccAWSEksNodeGroup_Labels (1160.89s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Id (1436.30s)
--- PASS: TestAccAWSEksNodeGroup_LaunchTemplate_Name (1489.91s)
--- PASS: TestAccAWSEksNodeGroup_disappears (939.99s)
--- PASS: TestAccAWSEksNodeGroup_Name_Generated (975.15s)
--- PASS: TestAccAWSEksNodeGroup_ReleaseVersion (3490.06s)

[github-actions]

This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.