-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
r/cognito_identity_provider - fix updating idp_identifiers
crash
#19819
r/cognito_identity_provider - fix updating idp_identifiers
crash
#19819
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀.
Commercial
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoIdentityProvider_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoIdentityProvider_ -timeout 180m
=== RUN TestAccAWSCognitoIdentityProvider_basic
=== PAUSE TestAccAWSCognitoIdentityProvider_basic
=== RUN TestAccAWSCognitoIdentityProvider_idpIdentifiers
=== PAUSE TestAccAWSCognitoIdentityProvider_idpIdentifiers
=== RUN TestAccAWSCognitoIdentityProvider_disappears
=== PAUSE TestAccAWSCognitoIdentityProvider_disappears
=== RUN TestAccAWSCognitoIdentityProvider_disappears_userPool
=== PAUSE TestAccAWSCognitoIdentityProvider_disappears_userPool
=== CONT TestAccAWSCognitoIdentityProvider_basic
=== CONT TestAccAWSCognitoIdentityProvider_disappears_userPool
=== CONT TestAccAWSCognitoIdentityProvider_disappears
=== CONT TestAccAWSCognitoIdentityProvider_idpIdentifiers
--- PASS: TestAccAWSCognitoIdentityProvider_disappears_userPool (21.96s)
--- PASS: TestAccAWSCognitoIdentityProvider_disappears (24.54s)
--- PASS: TestAccAWSCognitoIdentityProvider_idpIdentifiers (36.80s)
--- PASS: TestAccAWSCognitoIdentityProvider_basic (37.35s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 41.015s
GovCloud
% make testacc TEST=./aws TESTARGS='-run=TestAccAWSCognitoIdentityProvider_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSCognitoIdentityProvider_ -timeout 180m
=== RUN TestAccAWSCognitoIdentityProvider_basic
=== PAUSE TestAccAWSCognitoIdentityProvider_basic
=== RUN TestAccAWSCognitoIdentityProvider_idpIdentifiers
=== PAUSE TestAccAWSCognitoIdentityProvider_idpIdentifiers
=== RUN TestAccAWSCognitoIdentityProvider_disappears
=== PAUSE TestAccAWSCognitoIdentityProvider_disappears
=== RUN TestAccAWSCognitoIdentityProvider_disappears_userPool
=== PAUSE TestAccAWSCognitoIdentityProvider_disappears_userPool
=== CONT TestAccAWSCognitoIdentityProvider_basic
=== CONT TestAccAWSCognitoIdentityProvider_disappears_userPool
=== CONT TestAccAWSCognitoIdentityProvider_disappears
=== CONT TestAccAWSCognitoIdentityProvider_idpIdentifiers
--- PASS: TestAccAWSCognitoIdentityProvider_disappears_userPool (17.22s)
--- PASS: TestAccAWSCognitoIdentityProvider_disappears (19.94s)
--- PASS: TestAccAWSCognitoIdentityProvider_idpIdentifiers (36.92s)
--- PASS: TestAccAWSCognitoIdentityProvider_basic (36.93s)
PASS
ok github.com/terraform-providers/terraform-provider-aws/aws 40.355s
@DrFaust92 Thanks for the contribution 🎉 👏. |
This functionality has been released in v3.46.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Community Note
Closes #19792
Output from acceptance testing: